FUNK [FU North Korea] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

FUNK.swapBnbForTokens(uint256) (#813-830) sends eth to arbitrary user
Dangerous calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#820-827)
FUNK.swapBack() (#899-935) sends eth to arbitrary user
Dangerous calls:
- distributor.deposit{value: amountBNBReflection}() (#923)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in FUNK._transferFrom(address,address,uint256) (#724-767):
External calls:
- swapBack() (#739)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp.add(300)) (#906-934)
- distributor.deposit{value: amountBNBReflection}() (#923)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
- buyBackTokens() (#742)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#820-827)
External calls sending eth:
- swapBack() (#739)
- distributor.deposit{value: amountBNBReflection}() (#923)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
- buyBackTokens() (#742)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#820-827)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#746-749)
- amountReceived = takeFee(sender,recipient,amount) (#751)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#792)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#752)
- buyBackTokens() (#742)
- inSwap = true (#678)
- inSwap = false (#680)
Apply the check-effects-interactions pattern.

Additional information: link

SafeToken.withdraw(address,uint256) (#253-255) ignores return value by IBEP20(_token).transfer(owner(),_amount) (#254)
DividendDistributor.distributeDividend(address) (#429-446) ignores return value by BUSD.transfer(shareholder,amount) (#437)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Reentrancy in DividendDistributor.distributeDividend(address) (#429-446):
External calls:
- BUSD.transfer(shareholder,amount) (#437)
State variables written after the call(s):
- shares[shareholder].totalRealised = shares[shareholder].totalRealised.add(amount) (#439-441)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#442-444)
Reentrancy in DividendDistributor.process(uint256) (#391-417):
External calls:
- distributeDividend(shareholders[currentIndex]) (#409)
- BUSD.transfer(shareholder,amount) (#437)
State variables written after the call(s):
- currentIndex ++ (#414)
Reentrancy in DividendDistributor.setShare(address,uint256) (#322-348):
External calls:
- distributeDividend(shareholder) (#328)
- BUSD.transfer(shareholder,amount) (#437)
State variables written after the call(s):
- shares[shareholder].amount = amount (#344)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#345-347)
Apply the check-effects-interactions pattern.

Additional information: link

FUNK.swapBack() (#899-935) ignores return value by address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
Ensure that the return value of a low-level call is checked or logged.

Additional information: link

FUNK.swapBack().e (#926) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

DividendDistributor.constructor(address).owner (#306) shadows:
- Ownable.owner() (#91-93) (function)
Rename the local variables that shadow another component.

Additional information: link

DividendDistributor.setDistributionCriteria(uint256,uint256,uint256) (#312-320) should emit an event for:
- minPeriod = _minPeriod (#317)
- minDistribution = _minDistribution (#318)
FUNK.setDistributorSettings(uint256) (#719-722) should emit an event for:
- distributorGas = gas (#721)
FUNK.setTxLimit(uint256) (#832-834) should emit an event for:
- _maxTxAmount = amount (#833)
FUNK.setFees(uint256,uint256,uint256,uint256) (#857-869) should emit an event for:
- burnFee = _burnFee (#863)
- reflectionFee = _reflectionFee (#864)
- marketingFee = _marketingFee (#865)
- totalFee = _burnFee.add(_reflectionFee).add(_marketingFee) (#866)
- feeDenominator = _feeDenominator (#867)
FUNK.setSwapBackSettings(bool,uint256) (#875-881) should emit an event for:
- swapThreshold = _amount (#880)
FUNK.setBuyBackEnable(uint256,bool) (#937-943) should emit an event for:
- buyBackUpperLimit = _buyBackUpperLimit (#941)
Emit an event for critical parameter changes.

Additional information: link

Ownable.constructor().msgSender (#83) lacks a zero-check on :
- _owner = msgSender (#84)
FUNK.constructor().owner_ (#691) lacks a zero-check on :
- marketing = owner_ (#701)
FUNK.setMarketingWallet(address)._marketing (#871) lacks a zero-check on :
- marketing = _marketing (#872)
Check that the address is not zero.

Additional information: link

DividendDistributor.distributeDividend(address) (#429-446) has external calls inside a loop: BUSD.transfer(shareholder,amount) (#437)
Favor pull over push strategy for external calls.

Additional information: link

Variable 'FUNK.swapBack().e (#926)' in FUNK.swapBack() (#899-935) potentially used before declaration: SwapBackFailed(string(abi.encodePacked(SwapBack failed with error ,e))) (#927-929)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in FUNK.constructor() (#683-708):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#685)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = ~ uint256(0) (#686)
- _balances[owner_] = _totalSupply (#703)
- _maxTxAmount = _totalSupply (#707)
- distributor = new DividendDistributor(msg.sender) (#689)
- excludeDividend[pair] = true (#695)
- excludeDividend[address(this)] = true (#696)
- excludeDividend[DEAD] = true (#699)
- excludeFee[owner_] = true (#693)
- excludeFee[address(this)] = true (#697)
- excludeMaxTxn[owner_] = true (#694)
- excludeMaxTxn[address(this)] = true (#698)
- marketing = owner_ (#701)
- pairs[pair] = true (#687)
- swapThreshold = _totalSupply / 5000 (#706)
Reentrancy in DividendDistributor.deposit() (#372-389):
External calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: msg.value}(0,path,address(this),block.timestamp) (#379-381)
State variables written after the call(s):
- dividendsPerShare = dividendsPerShare.add(dividendsPerShareAccuracyFactor.mul(amount).div(totalShares)) (#386-388)
- totalDividends = totalDividends.add(amount) (#385)
Reentrancy in DividendDistributor.distributeDividend(address) (#429-446):
External calls:
- BUSD.transfer(shareholder,amount) (#437)
State variables written after the call(s):
- shareholderClaims[shareholder] = block.timestamp (#438)
Reentrancy in DividendDistributor.setShare(address,uint256) (#322-348):
External calls:
- distributeDividend(shareholder) (#328)
- BUSD.transfer(shareholder,amount) (#437)
State variables written after the call(s):
- addShareholder(shareholder) (#335)
- shareholderIndexes[shareholder] = shareholders.length (#483)
- removeShareholder(shareholder) (#340)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#491-493)
- addShareholder(shareholder) (#335)
- shareholders.push(shareholder) (#484)
- removeShareholder(shareholder) (#340)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#488-490)
- shareholders.pop() (#494)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#343)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in FUNK._transferFrom(address,address,uint256) (#724-767):
External calls:
- swapBack() (#739)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp.add(300)) (#906-934)
- distributor.deposit{value: amountBNBReflection}() (#923)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
- buyBackTokens() (#742)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#820-827)
External calls sending eth:
- swapBack() (#739)
- distributor.deposit{value: amountBNBReflection}() (#923)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
- buyBackTokens() (#742)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#820-827)
Event emitted after the call(s):
- SwapBNBForTokens(amount,path) (#829)
- buyBackTokens() (#742)
- Transfer(sender,address(this),feeAmount) (#793)
- amountReceived = takeFee(sender,recipient,amount) (#751)
Reentrancy in FUNK._transferFrom(address,address,uint256) (#724-767):
External calls:
- swapBack() (#739)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp.add(300)) (#906-934)
- distributor.deposit{value: amountBNBReflection}() (#923)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
- buyBackTokens() (#742)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#820-827)
- distributor.setShare(sender,_balances[sender]) (#755)
- distributor.setShare(recipient,_balances[recipient]) (#758-760)
- distributor.process(distributorGas) (#763)
External calls sending eth:
- swapBack() (#739)
- distributor.deposit{value: amountBNBReflection}() (#923)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
- buyBackTokens() (#742)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#820-827)
Event emitted after the call(s):
- Transfer(sender,recipient,amountReceived) (#765)
Reentrancy in FUNK.constructor() (#683-708):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#685)
Event emitted after the call(s):
- Transfer(address(0),owner_,_totalSupply) (#704)
Reentrancy in FUNK.swapBack() (#899-935):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp.add(300)) (#906-934)
- distributor.deposit{value: amountBNBReflection}() (#923)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
External calls sending eth:
- distributor.deposit{value: amountBNBReflection}() (#923)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
Event emitted after the call(s):
- SwapBackSuccess(swapThreshold) (#925)
Reentrancy in FUNK.swapBack() (#899-935):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp.add(300)) (#906-934)
Event emitted after the call(s):
- SwapBackFailed(string(abi.encodePacked(SwapBack failed with error ,e))) (#927-929)
- SwapBackFailed(SwapBack failed without an error message from pancakeSwap) (#931-933)
Reentrancy in FUNK.swapBnbForTokens(uint256) (#813-830):
External calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#820-827)
Event emitted after the call(s):
- SwapBNBForTokens(amount,path) (#829)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.getAccount(address) (#350-370) uses timestamp for comparisons
Dangerous comparisons:
- nextClaimTime > block.timestamp (#367-369)
DividendDistributor.shouldDistribute(address) (#419-427) uses timestamp for comparisons
Dangerous comparisons:
- shareholderClaims[shareholder] + minPeriod < block.timestamp && getUnpaidEarnings(shareholder) > minDistribution (#424-426)
Avoid relying on block.timestamp.

Additional information: link

DividendDistributor.process(uint256) (#391-417) has costly operations inside a loop:
- currentIndex = 0 (#405)
DividendDistributor.distributeDividend(address) (#429-446) has costly operations inside a loop:
- totalDistributed = totalDistributed.add(amount) (#436)
DividendDistributor.process(uint256) (#391-417) has costly operations inside a loop:
- currentIndex ++ (#414)
Use a local variable to hold the loop computation result.

Additional information: link

BASEToken._transferFrom(address,address,uint256) (#582-588) is never used and should be removed
Context._msgData() (#65-68) is never used and should be removed
Remove unused functions.

Additional information: link

FUNK.totalFee (#665) is set pre-construction with a non-constant function or state variable:
- burnFee.add(reflectionFee).add(marketingFee)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Low level call in FUNK.swapBack() (#899-935):
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#924)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IDEXRouter.WETH() (#177) is not in mixedCase
Parameter SafeToken.withdraw(address,uint256)._token (#253) is not in mixedCase
Parameter SafeToken.withdraw(address,uint256)._amount (#253) is not in mixedCase
Parameter SafeToken.withdrawBNB(uint256)._amount (#257) is not in mixedCase
Parameter DividendDistributor.setDistributionCriteria(uint256,uint256,uint256)._minPeriod (#313) is not in mixedCase
Parameter DividendDistributor.setDistributionCriteria(uint256,uint256,uint256)._minDistribution (#314) is not in mixedCase
Parameter DividendDistributor.setDistributionCriteria(uint256,uint256,uint256)._minimumTokenBalanceForDividends (#315) is not in mixedCase
Parameter DividendDistributor.getAccount(address)._account (#350) is not in mixedCase
Variable DividendDistributor._token (#264) is not in mixedCase
Variable DividendDistributor.BUSD (#272) is not in mixedCase
Variable DividendDistributor.WBNB (#273) is not in mixedCase
Parameter LockToken.includeToWhiteList(address[])._users (#515) is not in mixedCase
Variable BASEToken.WBNB (#525) is not in mixedCase
Variable BASEToken.DEAD (#526) is not in mixedCase
Variable BASEToken.ZERO (#527) is not in mixedCase
Variable BASEToken._balances (#529) is not in mixedCase
Variable BASEToken._allowances (#530) is not in mixedCase
Variable BASEToken._name (#532) is not in mixedCase
Variable BASEToken._symbol (#533) is not in mixedCase
Variable BASEToken._decimals (#534) is not in mixedCase
Variable BASEToken._totalSupply (#535) is not in mixedCase
Parameter FUNK.changeDex(address)._dex (#710) is not in mixedCase
Parameter FUNK.setDex(address,bool)._dex (#714) is not in mixedCase
Parameter FUNK.setFees(uint256,uint256,uint256,uint256)._burnFee (#858) is not in mixedCase
Parameter FUNK.setFees(uint256,uint256,uint256,uint256)._reflectionFee (#859) is not in mixedCase
Parameter FUNK.setFees(uint256,uint256,uint256,uint256)._marketingFee (#860) is not in mixedCase
Parameter FUNK.setFees(uint256,uint256,uint256,uint256)._feeDenominator (#861) is not in mixedCase
Parameter FUNK.setMarketingWallet(address)._marketing (#871) is not in mixedCase
Parameter FUNK.setSwapBackSettings(bool,uint256)._enabled (#875) is not in mixedCase
Parameter FUNK.setSwapBackSettings(bool,uint256)._amount (#875) is not in mixedCase
Parameter FUNK.setDistributionCriteria(uint256,uint256,uint256)._minPeriod (#884) is not in mixedCase
Parameter FUNK.setDistributionCriteria(uint256,uint256,uint256)._minDistribution (#885) is not in mixedCase
Parameter FUNK.setDistributionCriteria(uint256,uint256,uint256)._minimumTokenBalanceForDividends (#886) is not in mixedCase
Parameter FUNK.setBuyBackEnable(uint256,bool)._buyBackUpperLimit (#937) is not in mixedCase
Variable FUNK._maxTxAmount (#650) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#66)" inContext (#60-69)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#182) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#183)
Variable BASEToken._totalSupply (#535) is too similar to BASEToken.constructor(string,string,uint256,uint8).totalSupply_ (#540)
Prevent variables from having similar names.

Additional information: link

DividendDistributor.slitherConstructorVariables() (#262-496) uses literals with too many digits:
- minimumTokenBalanceForDividends = 6800000000 * (10 ** 9) (#290)
FUNK.setDistributorSettings(uint256) (#719-722) uses literals with too many digits:
- require(bool)(gas <= 1000000) (#720)
FUNK.slitherConstructorVariables() (#638-945) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#526)
FUNK.slitherConstructorVariables() (#638-945) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#527)
FUNK.slitherConstructorVariables() (#638-945) uses literals with too many digits:
- distributorGas = 500000 (#660)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

BASEToken.DEAD (#526) should be constant
BASEToken.WBNB (#525) should be constant
BASEToken.ZERO (#527) should be constant
DividendDistributor.WBNB (#273) should be constant
DividendDistributor.dividendsPerShareAccuracyFactor (#286) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#110-113)
getAccount(address) should be declared external:
- DividendDistributor.getAccount(address) (#350-370)
approve(address,uint256) should be declared external:
- BASEToken.approve(address,uint256) (#551-559)
getCirculatingSupply() should be declared external:
- BASEToken.getCirculatingSupply() (#590-592)
changeDex(address) should be declared external:
- FUNK.changeDex(address) (#710-712)
setDex(address,bool) should be declared external:
- FUNK.setDex(address,bool) (#714-717)
setBuyBackEnable(uint256,bool) should be declared external:
- FUNK.setBuyBackEnable(uint256,bool) (#937-943)
Use the external attribute for functions never called from the contract.

Additional information: link

Contract has 11% buy tax and 11% sell tax.
Taxes are high (over 10%) but contract ownership is renounced.

Average 30d PancakeSwap liquidity is low.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token on CoinGecko

Additional information: link

Unable to find token contract audit

Unable to find audit link on the website

Unable to find token on CoinHunt

Additional information: link

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has relatively low CoinMarketCap rank