FindShibby is the new token on ETH & BSC that has actual real-world usecases.
With FindShibby you can earn any BSC token as rewards, rescue pets via the FindShibby app, help streetdogs and other animals by donating to charity and help to develop unique, healthy dog treats manufactured using 100% renewable energy!
FindShibby.addLiquidity(uint256,uint256) (#1930-1945) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1936-1943)
Ensure that an arbitrary user cannot withdraw unauthorized funds.
Additional information: link
Reentrancy in FindShibby.buyBackTokensWithNoFees() (#1725-1753):
External calls:
- uniswapV2Router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: ethAmount}(0,path,address(msg.sender),block.timestamp + 360) (#1743-1748)
State variables written after the call(s):
- _isExcludedFromFees[msg.sender] = prevExclusion (#1750)
Apply the check-effects-interactions pattern.
Additional information: link
Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains
FindShibby.swapBack().success (#1900) is written in both
(success,None) = address(dividendTracker).call{value: bnbForRewards}() (#1902)
(success,None) = address(shibbyWallet).call{value: bnbForBuyBack}() (#1903)
Fix or remove the writes.
Additional information: link
Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
FindShibby._transfer(address,address,uint256) (#1781-1871) performs a multiplication on the result of a division:
-fees = amount.mul(sellTotalFees).div(100) (#1841)
-_charityTokensToSwap += fees * sellCharityFee / sellTotalFees (#1846)
Consider ordering multiplication before division.
Additional information: link
Reentrancy in FindShibby.updateDividendTracker(address) (#1438-1454):
External calls:
- newDividendTracker.excludeFromDividends(address(newDividendTracker)) (#1445)
- newDividendTracker.excludeFromDividends(address(this)) (#1446)
- newDividendTracker.excludeFromDividends(owner()) (#1447)
- newDividendTracker.excludeFromDividends(address(uniswapV2Router)) (#1448)
- newDividendTracker.excludeFromDividends(address(0xdead)) (#1449)
State variables written after the call(s):
- dividendTracker = newDividendTracker (#1453)
Apply the check-effects-interactions pattern.
Additional information: link
FindShibby._transfer(address,address,uint256).iterations (#1865) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.
Additional information: link
FindShibby.addLiquidity(uint256,uint256) (#1930-1945) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1936-1943)
Ensure that all the return values of the function calls are used.
Additional information: link
FindShibby.constructor().totalSupply (#1381) shadows:
- ERC20.totalSupply() (#519-521) (function)
- IERC20.totalSupply() (#86) (function)
Rename the local variables that shadow another component.
Additional information: link
FindShibby.updateSellFees(uint256,uint256,uint256,uint256,uint256) (#1558-1566) should emit an event for:
- sellOperationsFee = _operationsFee (#1559)
- sellRewardsFee = _rewardsFee (#1560)
- sellLiquidityFee = _liquidityFee (#1561)
- sellBuybackFee = _buybackFee (#1562)
- sellCharityFee = _charityFee (#1563)
- sellTotalFees = sellRewardsFee + sellLiquidityFee + sellOperationsFee + sellBuybackFee + sellCharityFee (#1564)
Emit an event for critical parameter changes.
Additional information: link
DividendPayingToken.setCharityAddress(address).wallet (#864) lacks a zero-check on :
- charityAddress = address(wallet) (#865)
Check that the address is not zero.
Additional information: link
FindShibby.airdropToWallets(address[],uint256[]) (#1511-1519) has external calls inside a loop: dividendTracker.setBalance(address(wallet),balanceOf(wallet)) (#1517)
Favor pull over push strategy for external calls.
Additional information: link
Variable 'FindShibby._transfer(address,address,uint256).iterations (#1865)' in FindShibby._transfer(address,address,uint256) (#1781-1871) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1866)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.
Additional information: link
Reentrancy in DividendPayingToken.swapETHForTokens(address,uint256) (#810-851):
External calls:
- swapRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: ethAmount}(1,path,address(recipient),block.timestamp + 360) (#829-839)
- (success) = recipient.call{gas: 3000,value: ethAmount}() (#843)
State variables written after the call(s):
- withdrawnDividends[recipient] = withdrawnDividends[recipient].sub(ethAmount) (#846)
Apply the check-effects-interactions pattern.
Additional information: link
Reentrancy in FindShibby.updateDividendTracker(address) (#1438-1454):
External calls:
- newDividendTracker.excludeFromDividends(address(newDividendTracker)) (#1445)
- newDividendTracker.excludeFromDividends(address(this)) (#1446)
- newDividendTracker.excludeFromDividends(owner()) (#1447)
- newDividendTracker.excludeFromDividends(address(uniswapV2Router)) (#1448)
- newDividendTracker.excludeFromDividends(address(0xdead)) (#1449)
Event emitted after the call(s):
- UpdateDividendTracker(newAddress,address(dividendTracker)) (#1451)
Apply the check-effects-interactions pattern.
Additional information: link
DividendTracker.canAutoClaim(uint256) (#2153-2159) uses timestamp for comparisons
Dangerous comparisons:
- lastClaimTime > block.timestamp (#2154)
- block.timestamp.sub(lastClaimTime) >= claimWait (#2158)
Avoid relying on block.timestamp.
Additional information: link
FindShibby.isContract(address) (#1595-1604) uses assembly
- INLINE ASM (#1602)
Do not use evm assembly.
Additional information: link
FindShibby.setRewardTokenWithCustomAMM(address,address) (#1700-1708) compares to a boolean constant:
-require(bool,string)(isAMMWhitelisted(ammContractAddress) == true,Findshibby: setRewardToken:: AMM is not whitelisted!) (#1705)
Remove the equality to the boolean constant.
Additional information: link
SafeMathInt.mul(int256,int256) (#248-255) is never used and should be removed
Remove unused functions.
Additional information: link
solc-0.8.9 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Low level call in FindShibby.swapBack() (#1873-1907):
- (success) = address(operationsWallet).call{value: bnbForMarketing}() (#1900)
- (success,None) = address(charityWallet).call{value: bnbForCharity}() (#1901)
- (success,None) = address(dividendTracker).call{value: bnbForRewards}() (#1902)
- (success,None) = address(shibbyWallet).call{value: bnbForBuyBack}() (#1903)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
Parameter DividendTracker.getAccount(address)._account (#2089) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Redundant expression "this (#21)" inContext (#15-24)
Remove redundant statements if they congest code but offer no value.
Additional information: link
Variable DividendPayingToken._withdrawDividendOfUser(address)._withdrawableDividend (#950) is too similar to DividendTracker.getAccount(address).withdrawableDividends (#2094)
Prevent variables from having similar names.
Additional information: link
DividendTracker.getAccountAtIndex(uint256) (#2134-2151) uses literals with too many digits:
- (0x0000000000000000000000000000000000000000,- 1,- 1,0,0,0,0,0) (#2145)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
SafeMathInt.MAX_INT256 (#243) is never used in SafeMathInt (#241-299)
Remove unused state variables.
Additional information: link
size(IterableMapping.Map) should be declared external:
- IterableMapping.size(IterableMapping.Map) (#1988-1990)
Use the external attribute for functions never called from the contract.
Additional information: link
Average 30d PancakeSwap volume is low.
Average PancakeSwap trading volume, liqudity, number of swaps are low. Token seems to be inactive.
Token is deployed only at one blockchain
Token has only one trading pair
Unable to find PancakeSwap trading pair to compute liquidity.
Unable to find PancakeSwap trading pair to compute number of swaps.
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of price dump / death
Young tokens have high risks of price dump / death
Young tokens have high risks of price dump / death
Token has relatively low CoinGecko rank
Token has relatively low CoinMarketCap rank
Twitter account link seems to be invalid