DDETH [Daddy Ethereum] Token

DDETH.swapAndSendToMarketing(uint256) (#1839-1847) sends eth to arbitrary user
Dangerous calls:
- marketingWallet.transfer(newBalance) (#1846)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in DDETH._transfer(address,address,uint256) (#1744-1837):
External calls:
- swapAndSendToMarketing(marketingTokens) (#1777)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1858-1864)
- swapAndSendDividends(sellTokens) (#1782)
- success = IERC20(ETH).transfer(address(dividendTracker),newBalance) (#1894-1897)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1876-1882)
- dividendTracker.distributeETHDividends(newBalance) (#1900)
External calls sending eth:
- swapAndSendToMarketing(marketingTokens) (#1777)
- marketingWallet.transfer(newBalance) (#1846)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#1809)
- _balances[sender] = senderBalance - amount (#1060)
- _balances[recipient] += amount (#1062)
- super._transfer(from,deadWallet,burnAmount) (#1810)
- _balances[sender] = senderBalance - amount (#1060)
- _balances[recipient] += amount (#1062)
- super._transfer(from,to,amount) (#1814)
- _balances[sender] = senderBalance - amount (#1060)
- _balances[recipient] += amount (#1062)
- swapping = false (#1784)
Apply the check-effects-interactions pattern.

Additional information: link

DDETH.claimStuckTokens(address) (#1542-1551) ignores return value by erc20token.transfer(owner(),balance) (#1550)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Reentrancy in DDETH.updateDividendTracker(address) (#1504-1528):
External calls:
- newDividendTracker.excludeFromDividends(address(newDividendTracker)) (#1519)
- newDividendTracker.excludeFromDividends(address(this)) (#1520)
- newDividendTracker.excludeFromDividends(owner()) (#1521)
- newDividendTracker.excludeFromDividends(deadWallet) (#1522)
- newDividendTracker.excludeFromDividends(address(uniswapV2Router)) (#1523)
State variables written after the call(s):
- dividendTracker = newDividendTracker (#1527)
Apply the check-effects-interactions pattern.

Additional information: link

DDETH._transfer(address,address,uint256).iterations (#1823) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

DDETH._transfer(address,address,uint256) (#1744-1837) ignores return value by dividendTracker.process(gas) (#1822-1835)
Ensure that all the return values of the function calls are used.

Additional information: link

DDETH.setSellFees(uint16,uint16,uint16)._burn (#1593) shadows:
- ERC20._burn(address,uint256) (#1101-1116) (function)
Rename the local variables that shadow another component.

Additional information: link

DDETH.setSwapTokens(uint256) (#1614-1616) should emit an event for:
- swapTokensAtAmount = amount (#1615)
Emit an event for critical parameter changes.

Additional information: link

DDETH.setWallets(address)._marketing (#1574) lacks a zero-check on :
- marketingWallet = _marketing (#1575)
Check that the address is not zero.

Additional information: link

Variable 'DDETH._transfer(address,address,uint256).claims (#1824)' in DDETH._transfer(address,address,uint256) (#1744-1837) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1827-1834)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in DDETH.updateUniswapV2Router(address) (#1530-1540):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(uniswapV2Router.factory()).createPair(address(this),uniswapV2Router.WETH()) (#1537-1538)
State variables written after the call(s):
- uniswapV2Pair = _uniswapV2Pair (#1539)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in DDETH.updateDividendTracker(address) (#1504-1528):
External calls:
- newDividendTracker.excludeFromDividends(address(newDividendTracker)) (#1519)
- newDividendTracker.excludeFromDividends(address(this)) (#1520)
- newDividendTracker.excludeFromDividends(owner()) (#1521)
- newDividendTracker.excludeFromDividends(deadWallet) (#1522)
- newDividendTracker.excludeFromDividends(address(uniswapV2Router)) (#1523)
Event emitted after the call(s):
- UpdateDividendTracker(newAddress,address(dividendTracker)) (#1525)
Apply the check-effects-interactions pattern.

Additional information: link

TOKENDividendTracker.canAutoClaim(uint256) (#2064-2070) uses timestamp for comparisons
Dangerous comparisons:
- lastClaimTime > block.timestamp (#2065)
- block.timestamp.sub(lastClaimTime) >= claimWait (#2069)
Avoid relying on block.timestamp.

Additional information: link

Different versions of Solidity is used:
- Version used: ['>=0.5.0', '>=0.6.2', '^0.8.0', '^0.8.8']
- >=0.6.2 (#4)
- >=0.6.2 (#102)
- >=0.5.0 (#148)
- ^0.8.8 (#169)
- ^0.8.8 (#236)
- ^0.8.8 (#264)
- ^0.8.8 (#303)
- ^0.8.8 (#373)
- ^0.8.0 (#391)
- ^0.8.0 (#620)
- ^0.8.0 (#646)
- ^0.8.0 (#719)
- ^0.8.0 (#803)
- ^0.8.0 (#832)
- ^0.8.8 (#1188)
- ^0.8.8 (#1363)
Use one Solidity version.

Additional information: link

SafeMathInt.mul(int256,int256) (#316-323) is never used and should be removed
Remove unused functions.

Additional information: link

solc-0.8.8 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Parameter TOKENDividendTracker.getAccount(address)._account (#1983) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Reentrancy in DDETH._transfer(address,address,uint256) (#1744-1837):
External calls:
- swapAndSendToMarketing(marketingTokens) (#1777)
- marketingWallet.transfer(newBalance) (#1846)
State variables written after the call(s):
- swapAndSendDividends(sellTokens) (#1782)
- _allowances[owner][spender] = amount (#1139)
- super._transfer(from,address(this),fees) (#1809)
- _balances[sender] = senderBalance - amount (#1060)
- _balances[recipient] += amount (#1062)
- super._transfer(from,deadWallet,burnAmount) (#1810)
- _balances[sender] = senderBalance - amount (#1060)
- _balances[recipient] += amount (#1062)
- super._transfer(from,to,amount) (#1814)
- _balances[sender] = senderBalance - amount (#1060)
- _balances[recipient] += amount (#1062)
- swapping = false (#1784)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#1140)
- swapAndSendDividends(sellTokens) (#1782)
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1827-1834)
- SendDividends(tokens,newBalance) (#1901)
- swapAndSendDividends(sellTokens) (#1782)
- Transfer(sender,recipient,amount) (#1064)
- super._transfer(from,address(this),fees) (#1809)
- Transfer(sender,recipient,amount) (#1064)
- super._transfer(from,deadWallet,burnAmount) (#1810)
- Transfer(sender,recipient,amount) (#1064)
- super._transfer(from,to,amount) (#1814)
Apply the check-effects-interactions pattern.

Additional information: link

Variable DividendPayingToken._withdrawDividendOfUser(address)._withdrawableDividend (#1261) is too similar to TOKENDividendTracker.getAccount(address).withdrawableDividends (#1990)
Prevent variables from having similar names.

Additional information: link

TOKENDividendTracker.getAccountAtIndex(uint256) (#2032-2062) uses literals with too many digits:
- (0x0000000000000000000000000000000000000000,- 1,- 1,0,0,0,0,0) (#2047-2056)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

SafeMathInt.MAX_INT256 (#311) is never used in SafeMathInt (#309-367)
Remove unused state variables.

Additional information: link

process(uint256) should be declared external:
- TOKENDividendTracker.process(uint256) (#2091-2143)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Token was delisted (assigned to inactive / untracked listing) from CoinMarketCap

Additional information: link

Unable to find token contract audit

Unable to find audit link on the website

Unable to find Twitter link on the website

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Young tokens have high risks of price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinMarketCap listing / rank

Token has relatively low CoinGecko rank