CHARLIECAKE [Charlie And The Cake Factory] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Too many vulnerabilities (Unchecked transfer, Reentrancy vulnerability, etc.). High risk of a scam. DYOR & manual audit are advised.

CharlieCakeV2.swapBack() (#648-692) sends eth to arbitrary user
Dangerous calls:
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in CharlieCakeV2._transferFrom(address,address,uint256) (#583-624):
External calls:
- swapBack() (#593)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#658-664)
- dividendDistributor.deposit{value: amountBNBReflection}() (#674)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
External calls sending eth:
- swapBack() (#593)
- dividendDistributor.deposit{value: amountBNBReflection}() (#674)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#601)
- _balances[recipient] = _balances[recipient].add(finalAmount) (#609)
- finalAmount = takeFee(sender,recipient,amount) (#608)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#638)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.distributeDividend(address) (#264-275) ignores return value by RewardToken.transfer(shareholder,amount) (#270)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

CharlieCakeV2.swapBack().tmpSuccess (#676) is written in both
(tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
tmpSuccess = false (#679)
Fix or remove the writes.

Additional information: link

Token is flagged by TokenSniffer (admin)

Contract ownership is not renounced (belongs to a wallet)

Not a direct threat, but may indicate unreliable intentions of developer. Widespread names (e.g. Elon, King, Moon, Doge) are common among meme-tokens and scams. The allow to gain free hype and attract unexperienced investors.

DividendDistributor.distributeDividend(address) (#264-275) has external calls inside a loop: RewardToken.transfer(shareholder,amount) (#270)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in DividendDistributor.process(uint256) (#235-257):
External calls:
- distributeDividend(shareholders[currentIndex]) (#249)
- RewardToken.transfer(shareholder,amount) (#270)
State variables written after the call(s):
- currentIndex ++ (#254)
Reentrancy in DividendDistributor.distributeDividend(address) (#264-275):
External calls:
- RewardToken.transfer(shareholder,amount) (#270)
State variables written after the call(s):
- shares[shareholder].totalRealised = shares[shareholder].totalRealised.add(amount) (#272)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#273)
Reentrancy in DividendDistributor.setShare(address,uint256) (#198-213):
External calls:
- distributeDividend(shareholder) (#201)
- RewardToken.transfer(shareholder,amount) (#270)
State variables written after the call(s):
- shares[shareholder].amount = amount (#211)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#212)
Apply the check-effects-interactions pattern.

Additional information: link

CharlieCakeV2.swapBack() (#648-692) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
Ensure that all the return values of the function calls are used.

Additional information: link

CharlieCakeV2.changeFees(uint256,uint256,uint256,uint256) (#535-543) should emit an event for:
- liquidityFee = newLiqFee (#536)
- rewardsFee = newRewardFee (#537)
- totalFee = liquidityFee.add(marketingFee).add(rewardsFee) (#541)
- totalFeeIfSelling = totalFee.add(extraFeeOnSell) (#542)
DividendDistributor.setDistributionCriteria(uint256,uint256) (#193-196) should emit an event for:
- minPeriod = newMinPeriod (#194)
- minDistribution = newMinDistribution (#195)
Emit an event for critical parameter changes.

Additional information: link

CharlieCakeV2.changeFeeReceivers(address,address).newMarketingWallet (#545) lacks a zero-check on :
- marketingWallet = newMarketingWallet (#547)
Auth.transferOwnership(address).adr (#364) lacks a zero-check on :
- owner = adr (#365)
CharlieCakeV2.changeFeeReceivers(address,address).newLiquidityReceiver (#545) lacks a zero-check on :
- autoLiquidityReceiver = newLiquidityReceiver (#546)
Check that the address is not zero.

Additional information: link

Reentrancy in DividendDistributor.deposit() (#215-233):
External calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: msg.value}(0,path,address(this),block.timestamp) (#223-228)
State variables written after the call(s):
- dividendsPerShare = dividendsPerShare.add(dividendsPerShareAccuracyFactor.mul(amount).div(totalShares)) (#232)
- totalDividends = totalDividends.add(amount) (#231)
Reentrancy in CharlieCakeV2._transferFrom(address,address,uint256) (#583-624):
External calls:
- swapBack() (#593)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#658-664)
- dividendDistributor.deposit{value: amountBNBReflection}() (#674)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
External calls sending eth:
- swapBack() (#593)
- dividendDistributor.deposit{value: amountBNBReflection}() (#674)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
State variables written after the call(s):
- launch() (#597)
- launchedAt = block.number (#497)
Reentrancy in DividendDistributor.setShare(address,uint256) (#198-213):
External calls:
- distributeDividend(shareholder) (#201)
- RewardToken.transfer(shareholder,amount) (#270)
State variables written after the call(s):
- addShareholder(shareholder) (#205)
- shareholderIndexes[shareholder] = shareholders.length (#299)
- removeShareholder(shareholder) (#207)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#305)
- addShareholder(shareholder) (#205)
- shareholders.push(shareholder) (#300)
- removeShareholder(shareholder) (#207)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#304)
- shareholders.pop() (#306)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#210)
Reentrancy in DividendDistributor.distributeDividend(address) (#264-275):
External calls:
- RewardToken.transfer(shareholder,amount) (#270)
State variables written after the call(s):
- shareholderClaims[shareholder] = block.timestamp (#271)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in CharlieCakeV2.swapBack() (#648-692):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#658-664)
- dividendDistributor.deposit{value: amountBNBReflection}() (#674)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
External calls sending eth:
- dividendDistributor.deposit{value: amountBNBReflection}() (#674)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#690)
Reentrancy in CharlieCakeV2._transferFrom(address,address,uint256) (#583-624):
External calls:
- swapBack() (#593)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#658-664)
- dividendDistributor.deposit{value: amountBNBReflection}() (#674)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
External calls sending eth:
- swapBack() (#593)
- dividendDistributor.deposit{value: amountBNBReflection}() (#674)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#639)
- finalAmount = takeFee(sender,recipient,amount) (#608)
Reentrancy in CharlieCakeV2._transferFrom(address,address,uint256) (#583-624):
External calls:
- swapBack() (#593)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#658-664)
- dividendDistributor.deposit{value: amountBNBReflection}() (#674)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
- dividendDistributor.setShare(sender,_balances[sender]) (#613)
- dividendDistributor.setShare(recipient,_balances[recipient]) (#617)
- dividendDistributor.process(distributorGas) (#620)
External calls sending eth:
- swapBack() (#593)
- dividendDistributor.deposit{value: amountBNBReflection}() (#674)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#682-689)
Event emitted after the call(s):
- Transfer(sender,recipient,finalAmount) (#622)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.shouldDistribute(address) (#259-262) uses timestamp for comparisons
Dangerous comparisons:
- shareholderClaims[shareholder] + minPeriod < block.timestamp && getUnpaidEarnings(shareholder) > minDistribution (#260-261)
Avoid relying on block.timestamp.

Additional information: link

DividendDistributor.distributeDividend(address) (#264-275) has costly operations inside a loop:
- totalDistributed = totalDistributed.add(amount) (#269)
DividendDistributor.process(uint256) (#235-257) has costly operations inside a loop:
- currentIndex ++ (#254)
DividendDistributor.process(uint256) (#235-257) has costly operations inside a loop:
- currentIndex = 0 (#246)
Use a local variable to hold the loop computation result.

Additional information: link

CharlieCakeV2._maxTxAmount (#387) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 2 / 800
CharlieCakeV2._walletMax (#388) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 2 / 100
CharlieCakeV2.swapThreshold (#424) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 5 / 4000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.7.4 (#34) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in CharlieCakeV2.swapBack() (#648-692):
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountBNBMarketing}() (#676)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable DividendDistributor.RewardToken (#159) is not in mixedCase
Variable CharlieCakeV2._maxTxAmount (#387) is not in mixedCase
Constant CharlieCakeV2._name (#377) is not in UPPER_CASE_WITH_UNDERSCORES
Constant CharlieCakeV2._decimals (#379) is not in UPPER_CASE_WITH_UNDERSCORES
Function PCSv2Router.WETH() (#93) is not in mixedCase
Variable CharlieCakeV2._balances (#392) is not in mixedCase
Variable CharlieCakeV2.RewardToken (#384) is not in mixedCase
Variable DividendDistributor._token (#149) is not in mixedCase
Variable CharlieCakeV2._totalSupply (#386) is not in mixedCase
Variable CharlieCakeV2._walletMax (#388) is not in mixedCase
Constant CharlieCakeV2._symbol (#378) is not in UPPER_CASE_WITH_UNDERSCORES
Variable CharlieCakeV2.ZERO (#382) is not in mixedCase
Variable CharlieCakeV2.DEAD (#381) is not in mixedCase
Variable CharlieCakeV2._allowances (#393) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable PCSv2Router.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#98) is too similar to PCSv2Router.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#99)
Prevent variables from having similar names.

Additional information: link

CharlieCakeV2.slitherConstructorVariables() (#373-697) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#381)
CharlieCakeV2.slitherConstructorVariables() (#373-697) uses literals with too many digits:
- distributorGas = 500000 (#418)
CharlieCakeV2.slitherConstructorVariables() (#373-697) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#382)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

CharlieCakeV2.RewardToken (#384) is never used in CharlieCakeV2 (#373-697)
Remove unused state variables.

Additional information: link

CharlieCakeV2.RewardToken (#384) should be constant
CharlieCakeV2._totalSupply (#386) should be constant
DividendDistributor.routerAddress (#158) should be constant
CharlieCakeV2.routerAddress (#383) should be constant
CharlieCakeV2.DEAD (#381) should be constant
CharlieCakeV2.ZERO (#382) should be constant
DividendDistributor.dividendsPerShareAccuracyFactor (#170) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

unauthorize(address) should be declared external:
- Auth.unauthorize(address) (#343-345)
getCirculatingSupply() should be declared external:
- CharlieCakeV2.getCirculatingSupply() (#475-477)
excludeMultipleAccountsFromFees(address[],bool) should be declared external:
- CharlieCakeV2.excludeMultipleAccountsFromFees(address[],bool) (#565-569)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#364-368)
tradingStatus(bool) should be declared external:
- CharlieCakeV2.tradingStatus(bool) (#644-646)
authorize(address) should be declared external:
- Auth.authorize(address) (#336-338)
Use the external attribute for functions never called from the contract.

Additional information: link

Contract has 15% buy tax and 100% sell tax.
Taxes are extremely high (over 30%)

Additional information: link

Token has no transactions for more than 100 days. It seems dead / abandoned.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Swap operations require suspiciously high gas. Contract logic is complex and may disguise some form of scam.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Token is marked as scam (rug pull, honeypot, phishing, etc.)

Additional information: link

Token has a considerable age, but we're still unable to find its website

Token has no active CoinMarketCap listing / rank

Token has no active CoinGecko listing / rank

Token has a considerable age, but social accounts / website are missing or have few users

Token has a considerable age, but average PancakeSwap 30d trading volume is low