CHAKRA [BNB Shinobi] Token

BNBShinobi.swapAndLiquify(uint256) (#1901-1956) sends eth to arbitrary user
Dangerous calls:
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
BNBShinobi.addLiquidity(uint256,uint256) (#1979-1994) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
BNBShinobi.sendToOperationsWallet(uint256) (#2012-2014) sends eth to arbitrary user
Dangerous calls:
- address(operationsWallet).transfer(amount) (#2013)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in BNBShinobi._transfer(address,address,uint256) (#1770-1899):
External calls:
- swapAndLiquify(swapTokens) (#1850)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
- swapAndSendDividends(sellTokens) (#1853)
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
External calls sending eth:
- swapAndLiquify(swapTokens) (#1850)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
- swapAndSendDividends(sellTokens) (#1853)
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#1882)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#655)
- _balances[recipient] = _balances[recipient].add(amount) (#656)
- super._transfer(from,to,amount) (#1885)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#655)
- _balances[recipient] = _balances[recipient].add(amount) (#656)
- _holderLastSellDate[from] = block.timestamp (#1876)
- swapping = false (#1855)
Reentrancy in DividendPayingToken._withdrawDividendOfUser(address) (#937-964):
External calls:
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#946)
State variables written after the call(s):
- rawBNBWithdrawnDividends[user] = rawBNBWithdrawnDividends[user].sub(_withdrawableDividend) (#950)
- withdrawnDividends[user] = withdrawnDividends[user].sub(_withdrawableDividend) (#949)
Reentrancy in BNBShinobi.buyBackTokensWithNoFees() (#1717-1745):
External calls:
- uniswapV2Router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: ethAmount}(0,path,address(msg.sender),block.timestamp + 360) (#1735-1740)
State variables written after the call(s):
- _isExcludedFromFees[msg.sender] = prevExclusion (#1742)
Reentrancy in DividendPayingToken.swapETHForTokens(address,uint256) (#808-851):
External calls:
- swapRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: ethAmount}(1,path,address(recipient),block.timestamp + 360) (#827-837)
- (success) = recipient.call{gas: 3000,value: ethAmount}() (#842)
State variables written after the call(s):
- rawBNBWithdrawnDividends[recipient] = rawBNBWithdrawnDividends[recipient].sub(ethAmount) (#846)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains

BNBShinobi._transfer(address,address,uint256) (#1770-1899) uses a dangerous strict equality:
- _holderLastSellDate[to] == block.timestamp (#1806)
BNBShinobi.getHolderSellFactor(address) (#1602-1618) uses a dangerous strict equality:
- _holderLastSellDate[holder] == 0 (#1607)
Don't use strict equality to determine if an account has enough Ether or tokens.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

BNBShinobi.getHolderSellFactor(address) (#1602-1618) performs a multiplication on the result of a division:
-timeSinceLastSale = (block.timestamp.sub(_holderLastSellDate[holder])).div(1209600) (#1604)
-sellFeeIncreaseFactor - (timeSinceLastSale.mul(10)) (#1617)
BNBShinobi._transfer(address,address,uint256) (#1770-1899) performs a multiplication on the result of a division:
-amount = amount.mul(_maxSellPercent).div(100) (#1823)
-fees = amount.mul(totalFees).div(100) (#1868)
BNBShinobi._transfer(address,address,uint256) (#1770-1899) performs a multiplication on the result of a division:
-rewardSellFee = amount.mul(BNBRewardsFee).div(100).mul(rewardFeeSellFactor).div(100) (#1872)
BNBShinobi._transfer(address,address,uint256) (#1770-1899) performs a multiplication on the result of a division:
-otherSellFee = amount.mul(liquidityFee).div(100).mul(getHolderSellFactor(from)).div(100) (#1873)
Consider ordering multiplication before division.

Additional information: link

Reentrancy in BNBShinobi.updateDividendTracker(address) (#1421-1436):
External calls:
- newDividendTracker.excludeFromDividends(address(newDividendTracker)) (#1428)
- newDividendTracker.excludeFromDividends(address(this)) (#1429)
- newDividendTracker.excludeFromDividends(owner()) (#1430)
- newDividendTracker.excludeFromDividends(address(uniswapV2Router)) (#1431)
State variables written after the call(s):
- dividendTracker = newDividendTracker (#1435)
Apply the check-effects-interactions pattern.

Additional information: link

BNBShinobi._transfer(address,address,uint256).claims (#1893) is a local variable never initialized
BNBShinobi._transfer(address,address,uint256).iterations (#1893) is a local variable never initialized
DividendPayingToken.swapETHForTokens(address,uint256).swapSuccess (#813) is a local variable never initialized
BNBShinobi._transfer(address,address,uint256).lastProcessedIndex (#1893) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

BNBShinobi.claim() (#1748-1750) ignores return value by dividendTracker.processAccount(address(msg.sender),false) (#1749)
BNBShinobi._transfer(address,address,uint256) (#1770-1899) ignores return value by dividendTracker.process(gas) (#1893-1897)
BNBShinobi.addLiquidity(uint256,uint256) (#1979-1994) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
Ensure that all the return values of the function calls are used.

Additional information: link

DividendPayingToken.constructor(string,string,uint8)._name (#794) shadows:
- ERC20._name (#475) (state variable)
DividendPayingToken.constructor(string,string,uint8)._symbol (#794) shadows:
- ERC20._symbol (#476) (state variable)
DividendPayingToken.constructor(string,string,uint8)._decimals (#794) shadows:
- ERC20._decimals (#477) (state variable)
DividendPayingToken.dividendOf(address)._owner (#970) shadows:
- Ownable._owner (#37) (state variable)
DividendPayingToken.withdrawableDividendOf(address)._owner (#977) shadows:
- Ownable._owner (#37) (state variable)
DividendPayingToken.withdrawnDividendOf(address)._owner (#984) shadows:
- Ownable._owner (#37) (state variable)
DividendPayingToken.accumulativeDividendOf(address)._owner (#994) shadows:
- Ownable._owner (#37) (state variable)
Rename the local variables that shadow another component.

Additional information: link

BNBShinobi.updateSwapTokensAtAmount(uint256) (#1409-1413) should emit an event for:
- swapTokensAtAmount = newAmount (#1411)
BNBShinobi.updateMaxTxn(uint256) (#1439-1441) should emit an event for:
- maxSellTransactionAmount = maxTxnAmount (#1440)
BNBShinobi.setMaxSellPercent(uint256) (#2016-2019) should emit an event for:
- _maxSellPercent = maxSellPercent (#2018)
Emit an event for critical parameter changes.

Additional information: link

DividendPayingToken._withdrawDividendOfUser(address) (#937-964) has external calls inside a loop: (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#946)
DividendPayingToken.swapETHForTokens(address,uint256) (#808-851) has external calls inside a loop: path[0] = swapRouter.WETH() (#823)
DividendPayingToken.swapETHForTokens(address,uint256) (#808-851) has external calls inside a loop: swapRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: ethAmount}(1,path,address(recipient),block.timestamp + 360) (#827-837)
DividendPayingToken.swapETHForTokens(address,uint256) (#808-851) has external calls inside a loop: (success) = recipient.call{gas: 3000,value: ethAmount}() (#842)
Favor pull over push strategy for external calls.

Additional information: link

Variable 'BNBShinobi._transfer(address,address,uint256).claims (#1893)' in BNBShinobi._transfer(address,address,uint256) (#1770-1899) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1894)
Variable 'BNBShinobi._transfer(address,address,uint256).iterations (#1893)' in BNBShinobi._transfer(address,address,uint256) (#1770-1899) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1894)
Variable 'BNBShinobi._transfer(address,address,uint256).lastProcessedIndex (#1893)' in BNBShinobi._transfer(address,address,uint256) (#1770-1899) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1894)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in BNBShinobi._transfer(address,address,uint256) (#1770-1899):
External calls:
- swapAndLiquify(swapTokens) (#1850)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
- swapAndSendDividends(sellTokens) (#1853)
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
External calls sending eth:
- swapAndLiquify(swapTokens) (#1850)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
- swapAndSendDividends(sellTokens) (#1853)
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
State variables written after the call(s):
- swapAndSendDividends(sellTokens) (#1853)
- _allowances[owner][spender] = amount (#721)
Reentrancy in BNBShinobi.constructor() (#1350-1394):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#1363-1364)
State variables written after the call(s):
- uniswapV2Pair = _uniswapV2Pair (#1367)
- uniswapV2Router = _uniswapV2Router (#1366)
Reentrancy in BNBShinobi.constructor() (#1350-1394):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#1363-1364)
- _setAutomatedMarketMakerPair(_uniswapV2Pair,true) (#1369)
- dividendTracker.excludeFromDividends(pair) (#1765)
- dividendTracker.excludeFromDividends(address(dividendTracker)) (#1372)
- dividendTracker.excludeFromDividends(address(this)) (#1373)
- dividendTracker.excludeFromDividends(liquidityWallet) (#1374)
- dividendTracker.excludeFromDividends(address(0x000000000000000000000000000000000000dEaD)) (#1375)
- dividendTracker.excludeFromDividends(address(_uniswapV2Router)) (#1376)
State variables written after the call(s):
- _mint(owner(),100000000000000 * (10 ** 9)) (#1393)
- _balances[account] = _balances[account].add(amount) (#675)
- _isAllowedDuringDisabled[address(this)] = true (#1385)
- _isAllowedDuringDisabled[owner()] = true (#1386)
- _isAllowedDuringDisabled[liquidityWallet] = true (#1387)
- excludeFromFees(liquidityWallet,true) (#1379)
- _isExcludedFromFees[account] = excluded (#1467)
- excludeFromFees(address(this),true) (#1380)
- _isExcludedFromFees[account] = excluded (#1467)
- excludeFromFees(address(dividendTracker),true) (#1381)
- _isExcludedFromFees[account] = excluded (#1467)
- excludeFromFees(address(operationsWallet),true) (#1382)
- _isExcludedFromFees[account] = excluded (#1467)
- excludeFromFees(address(buyBackWallet),true) (#1383)
- _isExcludedFromFees[account] = excluded (#1467)
- _mint(owner(),100000000000000 * (10 ** 9)) (#1393)
- _totalSupply = _totalSupply.add(amount) (#674)
Reentrancy in BNBShinobiDividendTracker.processAccount(address,bool) (#2289-2299):
External calls:
- amount = _withdrawDividendOfUser(account) (#2290)
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#946)
- swapRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: ethAmount}(1,path,address(recipient),block.timestamp + 360) (#827-837)
- (success) = recipient.call{gas: 3000,value: ethAmount}() (#842)
State variables written after the call(s):
- lastClaimTimes[account] = block.timestamp (#2293)
Reentrancy in BNBShinobi.swapAndLiquify(uint256) (#1901-1956):
External calls:
- swapTokensForEth(half) (#1927)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- addLiquidity(otherHalf,newBalance) (#1933)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1933)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (#1933)
- _allowances[owner][spender] = amount (#721)
Reentrancy in BNBShinobi.swapAndLiquify(uint256) (#1901-1956):
External calls:
- swapTokensForEth(half) (#1927)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- addLiquidity(otherHalf,newBalance) (#1933)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- swapTokensForEth(tokensForBuyBackAndOperations) (#1935)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1933)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
State variables written after the call(s):
- swapTokensForEth(tokensForBuyBackAndOperations) (#1935)
- _allowances[owner][spender] = amount (#721)
Reentrancy in DividendPayingToken.swapETHForTokens(address,uint256) (#808-851):
External calls:
- swapRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: ethAmount}(1,path,address(recipient),block.timestamp + 360) (#827-837)
State variables written after the call(s):
- rawBNBWithdrawnDividends[recipient] = rawBNBWithdrawnDividends[recipient].add(ethAmount) (#841)
Reentrancy in DividendPayingToken.swapETHForTokens(address,uint256) (#808-851):
External calls:
- swapRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: ethAmount}(1,path,address(recipient),block.timestamp + 360) (#827-837)
- (success) = recipient.call{gas: 3000,value: ethAmount}() (#842)
State variables written after the call(s):
- withdrawnDividends[recipient] = withdrawnDividends[recipient].sub(ethAmount) (#845)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in BNBShinobi._setAutomatedMarketMakerPair(address,bool) (#1760-1768):
External calls:
- dividendTracker.excludeFromDividends(pair) (#1765)
Event emitted after the call(s):
- SetAutomatedMarketMakerPair(pair,value) (#1767)
Reentrancy in BNBShinobi._transfer(address,address,uint256) (#1770-1899):
External calls:
- swapAndLiquify(swapTokens) (#1850)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
- swapAndSendDividends(sellTokens) (#1853)
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
External calls sending eth:
- swapAndLiquify(swapTokens) (#1850)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
- swapAndSendDividends(sellTokens) (#1853)
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#722)
- swapAndSendDividends(sellTokens) (#1853)
- SendDividends(tokens,dividends) (#2002)
- swapAndSendDividends(sellTokens) (#1853)
- Transfer(sender,recipient,amount) (#657)
- super._transfer(from,to,amount) (#1885)
- Transfer(sender,recipient,amount) (#657)
- super._transfer(from,address(this),fees) (#1882)
Reentrancy in BNBShinobi._transfer(address,address,uint256) (#1770-1899):
External calls:
- swapAndLiquify(swapTokens) (#1850)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
- swapAndSendDividends(sellTokens) (#1853)
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- dividendTracker.setBalance(address(from),balanceOf(from)) (#1887)
- dividendTracker.setBalance(address(to),balanceOf(to)) (#1888)
- dividendTracker.process(gas) (#1893-1897)
External calls sending eth:
- swapAndLiquify(swapTokens) (#1850)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
- swapAndSendDividends(sellTokens) (#1853)
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
Event emitted after the call(s):
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1894)
Reentrancy in BNBShinobi.buyBackTokensWithNoFees() (#1717-1745):
External calls:
- uniswapV2Router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: ethAmount}(0,path,address(msg.sender),block.timestamp + 360) (#1735-1740)
Event emitted after the call(s):
- BuyBackWithNoFees(msg.sender,ethAmount) (#1743)
Reentrancy in BNBShinobi.constructor() (#1350-1394):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#1363-1364)
- _setAutomatedMarketMakerPair(_uniswapV2Pair,true) (#1369)
- dividendTracker.excludeFromDividends(pair) (#1765)
Event emitted after the call(s):
- SetAutomatedMarketMakerPair(pair,value) (#1767)
- _setAutomatedMarketMakerPair(_uniswapV2Pair,true) (#1369)
Reentrancy in BNBShinobi.constructor() (#1350-1394):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#1363-1364)
- _setAutomatedMarketMakerPair(_uniswapV2Pair,true) (#1369)
- dividendTracker.excludeFromDividends(pair) (#1765)
- dividendTracker.excludeFromDividends(address(dividendTracker)) (#1372)
- dividendTracker.excludeFromDividends(address(this)) (#1373)
- dividendTracker.excludeFromDividends(liquidityWallet) (#1374)
- dividendTracker.excludeFromDividends(address(0x000000000000000000000000000000000000dEaD)) (#1375)
- dividendTracker.excludeFromDividends(address(_uniswapV2Router)) (#1376)
Event emitted after the call(s):
- ExcludeFromFees(account,excluded) (#1468)
- excludeFromFees(address(this),true) (#1380)
- ExcludeFromFees(account,excluded) (#1468)
- excludeFromFees(liquidityWallet,true) (#1379)
- ExcludeFromFees(account,excluded) (#1468)
- excludeFromFees(address(buyBackWallet),true) (#1383)
- ExcludeFromFees(account,excluded) (#1468)
- excludeFromFees(address(operationsWallet),true) (#1382)
- ExcludeFromFees(account,excluded) (#1468)
- excludeFromFees(address(dividendTracker),true) (#1381)
- Transfer(address(0),account,amount) (#676)
- _mint(owner(),100000000000000 * (10 ** 9)) (#1393)
Reentrancy in BNBShinobiDividendTracker.processAccount(address,bool) (#2289-2299):
External calls:
- amount = _withdrawDividendOfUser(account) (#2290)
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#946)
- swapRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: ethAmount}(1,path,address(recipient),block.timestamp + 360) (#827-837)
- (success) = recipient.call{gas: 3000,value: ethAmount}() (#842)
Event emitted after the call(s):
- Claim(account,amount,automatic) (#2294)
Reentrancy in BNBShinobi.processDividendTracker(uint256) (#1753-1756):
External calls:
- (iterations,claims,lastProcessedIndex) = dividendTracker.process(gas) (#1754)
Event emitted after the call(s):
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,false,gas,tx.origin) (#1755)
Reentrancy in BNBShinobi.swapAndLiquify(uint256) (#1901-1956):
External calls:
- swapTokensForEth(half) (#1927)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- addLiquidity(otherHalf,newBalance) (#1933)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1933)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#722)
- addLiquidity(otherHalf,newBalance) (#1933)
Reentrancy in BNBShinobi.swapAndLiquify(uint256) (#1901-1956):
External calls:
- swapTokensForEth(half) (#1927)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- addLiquidity(otherHalf,newBalance) (#1933)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- swapTokensForEth(tokensForBuyBackAndOperations) (#1935)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1933)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#722)
- swapTokensForEth(tokensForBuyBackAndOperations) (#1935)
Reentrancy in BNBShinobi.swapAndLiquify(uint256) (#1901-1956):
External calls:
- swapTokensForEth(half) (#1927)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- addLiquidity(otherHalf,newBalance) (#1933)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- swapTokensForEth(tokensForBuyBackAndOperations) (#1935)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1933)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1985-1992)
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
Event emitted after the call(s):
- SwapAndLiquify(half,newBalance,otherHalf) (#1954)
Reentrancy in BNBShinobi.swapAndSendDividends(uint256) (#1996-2004):
External calls:
- swapTokensForEth(tokens) (#1997)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1969-1975)
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
External calls sending eth:
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
Event emitted after the call(s):
- SendDividends(tokens,dividends) (#2002)
Reentrancy in BNBShinobi.updateDividendTracker(address) (#1421-1436):
External calls:
- newDividendTracker.excludeFromDividends(address(newDividendTracker)) (#1428)
- newDividendTracker.excludeFromDividends(address(this)) (#1429)
- newDividendTracker.excludeFromDividends(owner()) (#1430)
- newDividendTracker.excludeFromDividends(address(uniswapV2Router)) (#1431)
Event emitted after the call(s):
- UpdateDividendTracker(newAddress,address(dividendTracker)) (#1433)
Apply the check-effects-interactions pattern.

Additional information: link

BNBShinobi.getHolderSellFactor(address) (#1602-1618) uses timestamp for comparisons
Dangerous comparisons:
- _holderLastSellDate[holder] == 0 (#1607)
- timeSinceLastSale >= 7 (#1612)
BNBShinobi._transfer(address,address,uint256) (#1770-1899) uses timestamp for comparisons
Dangerous comparisons:
- amount == 0 (#1788)
- require(bool,string)(_holderLastTransferTimestamp[to] < block.timestamp,_transfer:: Transfer Delay enabled. Please try again later.) (#1797)
- _holderLastSellDate[to] == block.timestamp (#1806)
- _holderLastSellDate[to] >= block.timestamp (#1814)
- require(bool,string)(amount <= maxSellTransactionAmount,BEP20: Exceeds max sell amount) (#1821)
- canSwap = contractTokenBalance >= swapTokensAtAmount (#1828)
- canSwap && ! swapping && isSwapAndLiquifyEnabled && ! automatedMarketMakerPairs[from] && from != liquidityWallet && to != liquidityWallet && from != operationsWallet && to != operationsWallet && from != buyBackWallet && to != buyBackWallet && ! _isExcludedFromFees[to] && ! _isExcludedFromFees[from] && from != address(this) && from != address(dividendTracker) (#1831-1844)
BNBShinobiDividendTracker.getAccount(address) (#2153-2196) uses timestamp for comparisons
Dangerous comparisons:
- nextClaimTime > block.timestamp (#2193-2195)
BNBShinobiDividendTracker.canAutoClaim(uint256) (#2217-2223) uses timestamp for comparisons
Dangerous comparisons:
- lastClaimTime > block.timestamp (#2218)
- block.timestamp.sub(lastClaimTime) >= claimWait (#2222)
Avoid relying on block.timestamp.

Additional information: link

BNBShinobi.isContract(address) (#1569-1578) uses assembly
- INLINE ASM (#1576)
Do not use evm assembly.

Additional information: link

DividendPayingToken.setRewardToken(address,address,address) (#870-888) compares to a boolean constant:
-userHasCustomRewardToken[holder] == true (#871)
BNBShinobi.setRewardTokenWithCustomAMM(address,address) (#1694-1702) compares to a boolean constant:
-require(bool,string)(isAMMWhitelisted(ammContractAddress) == true,BNB Shinobi: setRewardToken:: AMM is not whitelisted!) (#1699)
Remove the equality to the boolean constant.

Additional information: link

Context._msgData() (#30-33) is never used and should be removed
DividendPayingToken._transfer(address,address,uint256) (#1004-1010) is never used and should be removed
SafeMath.mod(uint256,uint256) (#444-446) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#460-463) is never used and should be removed
SafeMathInt.abs(int256) (#299-302) is never used and should be removed
SafeMathInt.div(int256,int256) (#270-276) is never used and should be removed
SafeMathInt.mul(int256,int256) (#258-265) is never used and should be removed
Remove unused functions.

Additional information: link

BNBShinobi.totalFees (#1285) is set pre-construction with a non-constant function or state variable:
- BNBRewardsFee.add(liquidityFee)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Low level call in DividendPayingToken.swapETHForTokens(address,uint256) (#808-851):
- (success) = recipient.call{gas: 3000,value: ethAmount}() (#842)
Low level call in DividendPayingToken._withdrawDividendOfUser(address) (#937-964):
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#946)
Low level call in BNBShinobi.swapAndLiquify(uint256) (#1901-1956):
- (success,None) = address(operationsWallet).call{value: operationsBalance}() (#1943)
- (success,None) = address(buyBackWallet).call{value: buyBackBalance}() (#1950)
Low level call in BNBShinobi.swapAndSendDividends(uint256) (#1996-2004):
- (success) = address(dividendTracker).call{value: dividends}() (#1999)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Parameter DividendPayingToken.dividendOf(address)._owner (#970) is not in mixedCase
Parameter DividendPayingToken.withdrawableDividendOf(address)._owner (#977) is not in mixedCase
Parameter DividendPayingToken.withdrawnDividendOf(address)._owner (#984) is not in mixedCase
Parameter DividendPayingToken.accumulativeDividendOf(address)._owner (#994) is not in mixedCase
Constant DividendPayingToken.magnitude (#759) is not in UPPER_CASE_WITH_UNDERSCORES
Function IUniswapV2Router01.WETH() (#1049) is not in mixedCase
Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#1216) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#1217) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#1234) is not in mixedCase
Variable BNBShinobi._isAllowedDuringDisabled (#1263) is not in mixedCase
Variable BNBShinobi._isIgnoredAddress (#1264) is not in mixedCase
Variable BNBShinobi._holderLastSellDate (#1280) is not in mixedCase
Variable BNBShinobi.BNBRewardsFee (#1283) is not in mixedCase
Variable BNBShinobi._maxSellPercent (#1289) is not in mixedCase
Parameter BNBShinobiDividendTracker.getAccount(address)._account (#2153) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#31)" inContext (#25-34)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#1054) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#1055)
Variable DividendPayingToken._withdrawDividendOfUser(address)._withdrawableDividend (#938) is too similar to BNBShinobiDividendTracker.getAccount(address).withdrawableDividends (#2158)
Prevent variables from having similar names.

Additional information: link

BNBShinobi.constructor() (#1350-1394) uses literals with too many digits:
- dividendTracker.excludeFromDividends(address(0x000000000000000000000000000000000000dEaD)) (#1375)
BNBShinobi.constructor() (#1350-1394) uses literals with too many digits:
- _mint(owner(),100000000000000 * (10 ** 9)) (#1393)
BNBShinobi.updateGasForProcessing(uint256) (#1543-1548) uses literals with too many digits:
- require(bool,string)(newValue >= 200000 && newValue <= 500000,BNB Shinobi: gasForProcessing must be between 200,000 and 500,000) (#1544)
BNBShinobi.slitherConstructorVariables() (#1252-2020) uses literals with too many digits:
- maxSellTransactionAmount = 100000000000000 * (10 ** 9) (#1271)
BNBShinobi.slitherConstructorVariables() (#1252-2020) uses literals with too many digits:
- swapTokensAtAmount = 1000000000 * (10 ** 9) (#1272)
BNBShinobi.slitherConstructorVariables() (#1252-2020) uses literals with too many digits:
- gasForProcessing = 300000 (#1303)
BNBShinobiDividendTracker.constructor() (#2104-2107) uses literals with too many digits:
- minimumTokenBalanceForDividends = 100000000 * (10 ** 9) (#2106)
BNBShinobiDividendTracker.getAccountAtIndex(uint256) (#2198-2215) uses literals with too many digits:
- (0x0000000000000000000000000000000000000000,- 1,- 1,0,0,0,0,0) (#2209)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

SafeMathInt.MAX_INT256 (#253) is never used in SafeMathInt (#251-309)
Remove unused state variables.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#72-75)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#81-85)
name() should be declared external:
- ERC20.name() (#497-499)
symbol() should be declared external:
- ERC20.symbol() (#505-507)
decimals() should be declared external:
- ERC20.decimals() (#522-524)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#548-551)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#556-558)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#567-570)
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#585-593)
increaseAllowance(address,uint256) should be declared external:
- ERC20.increaseAllowance(address,uint256) (#607-610)
decreaseAllowance(address,uint256) should be declared external:
- ERC20.decreaseAllowance(address,uint256) (#626-629)
withdrawDividend() should be declared external:
- BNBShinobiDividendTracker.withdrawDividend() (#2113-2115)
- DividendPayingToken.withdrawDividend() (#931-933)
dividendOf(address) should be declared external:
- DividendPayingToken.dividendOf(address) (#970-972)
withdrawnDividendOf(address) should be declared external:
- DividendPayingToken.withdrawnDividendOf(address) (#984-986)
updateDividendTracker(address) should be declared external:
- BNBShinobi.updateDividendTracker(address) (#1421-1436)
getUserCurrentRewardToken(address) should be declared external:
- BNBShinobi.getUserCurrentRewardToken(address) (#1580-1582)
getUserHasCustomRewardToken(address) should be declared external:
- BNBShinobi.getUserHasCustomRewardToken(address) (#1584-1586)
getRewardTokenSelectionCount(address) should be declared external:
- BNBShinobi.getRewardTokenSelectionCount(address) (#1588-1590)
isExcludedFromFees(address) should be declared external:
- BNBShinobi.isExcludedFromFees(address) (#1632-1634)
withdrawableDividendOf(address) should be declared external:
- BNBShinobi.withdrawableDividendOf(address) (#1636-1638)
dividendTokenBalanceOf(address) should be declared external:
- BNBShinobi.dividendTokenBalanceOf(address) (#1640-1642)
getBNBAvailableForHolderBuyBack(address) should be declared external:
- BNBShinobi.getBNBAvailableForHolderBuyBack(address) (#1674-1676)
setRewardToken(address) should be declared external:
- BNBShinobi.setRewardToken(address) (#1685-1691)
setRewardTokenWithCustomAMM(address,address) should be declared external:
- BNBShinobi.setRewardTokenWithCustomAMM(address,address) (#1694-1702)
unsetRewardToken() should be declared external:
- BNBShinobi.unsetRewardToken() (#1705-1708)
activateContract() should be declared external:
- BNBShinobi.activateContract() (#1711-1714)
recoverContractBNB(uint256) should be declared external:
- BNBShinobi.recoverContractBNB(uint256) (#2006-2011)
setMaxSellPercent(uint256) should be declared external:
- BNBShinobi.setMaxSellPercent(uint256) (#2016-2019)
get(IterableMapping.Map,address) should be declared external:
- IterableMapping.get(IterableMapping.Map,address) (#2031-2033)
getIndexOfKey(IterableMapping.Map,address) should be declared external:
- IterableMapping.getIndexOfKey(IterableMapping.Map,address) (#2035-2040)
getKeyAtIndex(IterableMapping.Map,uint256) should be declared external:
- IterableMapping.getKeyAtIndex(IterableMapping.Map,uint256) (#2042-2044)
size(IterableMapping.Map) should be declared external:
- IterableMapping.size(IterableMapping.Map) (#2048-2050)
getAccountAtIndex(uint256) should be declared external:
- BNBShinobiDividendTracker.getAccountAtIndex(uint256) (#2198-2215)
process(uint256) should be declared external:
- BNBShinobiDividendTracker.process(uint256) (#2242-2287)
Use the external attribute for functions never called from the contract.

Additional information: link

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Contract has 9% buy tax and 14% sell tax.
Taxes are high (over 10%) but contract ownership is renounced.

Swap operations require suspiciously high gas. Contract logic is complex and may disguise some form of scam.

Average 30d PancakeSwap volume is low.

Average PancakeSwap trading volume, liqudity, number of swaps are low. Token seems to be inactive.

Token is deployed only at one blockchain

Token has only one trading pair

Young tokens have high risks of price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death

Token has relatively low CoinGecko rank

Token has relatively low CoinMarketCap rank