BiShares provides safe crypto diversification and yield farming through decentralized Exchange Traded Funds (dETFs) and yield farming on multiple chains.
BISON is BiShares governance token and is used to vote for all the proposals related to the protocol, holders earn platform fees.
Bison._writeCheckpoint(address,uint32,uint96,uint96) (contracts/governance/Bison.sol#390-412) uses a dangerous strict equality:
- nCheckpoints > 0 && checkpoints[delegatee][nCheckpoints - 1].fromBlock == blockNumber (contracts/governance/Bison.sol#402-403)
Don't use strict equality to determine if an account has enough Ether or tokens.
Additional information: link
Bison.constructor(address,address,uint256).minter_ (contracts/governance/Bison.sol#85) lacks a zero-check on :
- minter = minter_ (contracts/governance/Bison.sol#92)
Bison.setMinter(address).minter_ (contracts/governance/Bison.sol#101) lacks a zero-check on :
- minter = minter_ (contracts/governance/Bison.sol#104)
Check that the address is not zero.
Additional information: link
Bison.constructor(address,address,uint256) (contracts/governance/Bison.sol#85-95) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(mintingAllowedAfter_ >= block.timestamp,bison::constructor: minting can only begin after deployment) (contracts/governance/Bison.sol#86-89)
Bison.mint(address,uint256) (contracts/governance/Bison.sol#112-131) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(block.timestamp >= mintingAllowedAfter,Bison::mint: minting not allowed yet) (contracts/governance/Bison.sol#114)
Bison.permit(address,address,uint256,uint256,uint8,bytes32,bytes32) (contracts/governance/Bison.sol#155-200) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(now <= deadline,Bison::permit: signature expired) (contracts/governance/Bison.sol#195)
Bison.delegateBySig(address,uint256,uint256,uint8,bytes32,bytes32) (contracts/governance/Bison.sol#244-271) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(now <= expiry,Bison::delegateBySig: signature expired) (contracts/governance/Bison.sol#269)
Avoid relying on block.timestamp.
Additional information: link
Bison.getChainId() (contracts/governance/Bison.sol#451-457) uses assembly
- INLINE ASM (contracts/governance/Bison.sol#453-455)
Do not use evm assembly.
Additional information: link
Different versions of Solidity is used:
- Version used: ['>=0.6.0<0.8.0', '^0.6.0']
- >=0.6.0<0.8.0 (@openzeppelin/contracts/math/SafeMath.sol#3)
- ^0.6.0 (contracts/governance/Bison.sol#2)
- ABIEncoderV2 (contracts/governance/Bison.sol#3)
Use one Solidity version.
Additional information: link
SafeMath.div(uint256,uint256,string) (@openzeppelin/contracts/math/SafeMath.sol#190-193) is never used and should be removed
SafeMath.mod(uint256,uint256) (@openzeppelin/contracts/math/SafeMath.sol#152-155) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (@openzeppelin/contracts/math/SafeMath.sol#210-213) is never used and should be removed
SafeMath.sub(uint256,uint256) (@openzeppelin/contracts/math/SafeMath.sol#101-104) is never used and should be removed
SafeMath.sub(uint256,uint256,string) (@openzeppelin/contracts/math/SafeMath.sol#170-173) is never used and should be removed
SafeMath.tryAdd(uint256,uint256) (@openzeppelin/contracts/math/SafeMath.sol#24-28) is never used and should be removed
SafeMath.tryDiv(uint256,uint256) (@openzeppelin/contracts/math/SafeMath.sol#60-63) is never used and should be removed
SafeMath.tryMod(uint256,uint256) (@openzeppelin/contracts/math/SafeMath.sol#70-73) is never used and should be removed
SafeMath.tryMul(uint256,uint256) (@openzeppelin/contracts/math/SafeMath.sol#45-53) is never used and should be removed
SafeMath.trySub(uint256,uint256) (@openzeppelin/contracts/math/SafeMath.sol#35-38) is never used and should be removed
Remove unused functions.
Additional information: link
Pragma version>=0.6.0<0.8.0 (@openzeppelin/contracts/math/SafeMath.sol#3) is too complex
Pragma version^0.6.0 (contracts/governance/Bison.sol#2) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Constant Bison.mintCap (contracts/governance/Bison.sol#25) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Bison.minimumTimeBetweenMints (contracts/governance/Bison.sol#28) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.
Additional information: link
delegate(address) should be declared external:
- Bison.delegate(address) (contracts/governance/Bison.sol#240-242)
delegateBySig(address,uint256,uint256,uint8,bytes32,bytes32) should be declared external:
- Bison.delegateBySig(address,uint256,uint256,uint8,bytes32,bytes32) (contracts/governance/Bison.sol#244-271)
getPriorVotes(address,uint256) should be declared external:
- Bison.getPriorVotes(address,uint256) (contracts/governance/Bison.sol#278-315)
Use the external attribute for functions never called from the contract.
Additional information: link
Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.
Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.
Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.
Average 30d number of PancakeSwap swaps is low.
Token has a considerable age, but average PancakeSwap 30d trading volume is low
Token has relatively low CoinGecko rank
Last post in Twitter was more than 30 days ago
Unable to find Youtube account