Binance Smart Chain (BSC) is the most viable and efficient blockchain network nowadays, with multiple advantages regarding transaction speed, gas fee, flexibility, scalability, security, and real use cases. Since May 2021, there have been more than 10 million daily transactions on average on BSC, according to BscScan, and this record-breaking number far exceeds the number of daily transactions on the most dominant blockchain competition, Ethereum. Being in the same ecosystem as Binance, the world’s biggest crypto exchange, BSC has a clear competitive advantage in liquidity. In the future, BSC is likely to prevail in the decentralized economy with thousands of BUIDLers working around the clock to improve the ecosystem.
BSC Army is the first DAO (decentralized autonomous organization) for social media industries on BSC, and a community-centered initiative that strives to promote the adoption of BSC and blockchain in general.
This program is for those who are passionate about BSC, Binance, and BNB token (BSC's native token). By advocating for BSC as well as helping potential investors and projects to use BSC, members of BSC Army can receive passive incomes in BARMY token.
Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
Reentrancy in BscArmy._transfer(address,address,uint256) (#1048-1092):
External calls:
- swapAndLiquify(contractTokenBalance) (#1079)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1140-1147)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1126-1132)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (#1079)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1140-1147)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#1091)
- _rOwned[address(this)] = _rOwned[address(this)].add(rLiquidity) (#995)
- _rOwned[sender] = _rOwned[sender].sub(rAmount) (#1184)
- _rOwned[sender] = _rOwned[sender].sub(rAmount) (#1173)
- _rOwned[recipient] = _rOwned[recipient].add(rTransferAmount) (#1174)
- _rOwned[sender] = _rOwned[sender].sub(rAmount) (#889)
- _rOwned[sender] = _rOwned[sender].sub(rAmount) (#1197)
- _rOwned[recipient] = _rOwned[recipient].add(rTransferAmount) (#1198)
- _rOwned[recipient] = _rOwned[recipient].add(rTransferAmount) (#1186)
- _rOwned[_armyFoundation] = _rOwned[_armyFoundation].add(rArmy) (#1176)
- _rOwned[recipient] = _rOwned[recipient].add(rTransferAmount) (#891)
- _rOwned[_armyFoundation] = _rOwned[_armyFoundation].add(rArmy) (#1188)
- _rOwned[_armyFoundation] = _rOwned[_armyFoundation].add(rArmy) (#1200)
- _rOwned[_armyFoundation] = _rOwned[_armyFoundation].add(rArmy) (#893)
- _tokenTransfer(from,to,amount,takeFee) (#1091)
- _rTotal = _rTotal.sub(rFee) (#938)
- _tokenTransfer(from,to,amount,takeFee) (#1091)
- _tOwned[address(this)] = _tOwned[address(this)].add(tLiquidity) (#997)
- _tOwned[sender] = _tOwned[sender].sub(tAmount) (#888)
- _tOwned[sender] = _tOwned[sender].sub(tAmount) (#1196)
- _tOwned[recipient] = _tOwned[recipient].add(tTransferAmount) (#1185)
- _tOwned[_armyFoundation] = _tOwned[_armyFoundation].add(tArmy) (#1175)
- _tOwned[recipient] = _tOwned[recipient].add(tTransferAmount) (#890)
- _tOwned[_armyFoundation] = _tOwned[_armyFoundation].add(tArmy) (#1199)
- _tOwned[_armyFoundation] = _tOwned[_armyFoundation].add(tArmy) (#1187)
- _tOwned[_armyFoundation] = _tOwned[_armyFoundation].add(tArmy) (#892)
Apply the check-effects-interactions pattern.
Additional information: link
BscArmy._getRValues(uint256,uint256,uint256,uint256,uint256).rVal (#957) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.
Additional information: link
BscArmy.addLiquidity(uint256,uint256) (#1135-1148) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1140-1147)
Ensure that all the return values of the function calls are used.
Additional information: link
BscArmy._approve(address,address,uint256).owner (#1040) shadows:
- Ownable.owner() (#429-431) (function)
Rename the local variables that shadow another component.
Additional information: link
BscArmy.setMaxTxPercent(uint256) (#923-927) should emit an event for:
- _maxTxAmount = _tTotal.mul(maxTxPercent).div(10 ** 2) (#924-926)
Emit an event for critical parameter changes.
Additional information: link
BscArmy.setArmyFoundation(address).armyFoundation (#915) lacks a zero-check on :
- _armyFoundation = armyFoundation (#916)
Check that the address is not zero.
Additional information: link
Reentrancy in BscArmy.transferFrom(address,address,uint256) (#814-818):
External calls:
- _transfer(sender,recipient,amount) (#815)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1140-1147)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1126-1132)
External calls sending eth:
- _transfer(sender,recipient,amount) (#815)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1140-1147)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#816)
- _allowances[owner][spender] = amount (#1044)
Apply the check-effects-interactions pattern.
Additional information: link
Reentrancy in BscArmy.transferFrom(address,address,uint256) (#814-818):
External calls:
- _transfer(sender,recipient,amount) (#815)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1140-1147)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1126-1132)
External calls sending eth:
- _transfer(sender,recipient,amount) (#815)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1140-1147)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#1045)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#816)
Apply the check-effects-interactions pattern.
Additional information: link
Ownable.unlock() (#476-481) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(now > _lockTime,Contract is locked until 7 days) (#478)
Avoid relying on block.timestamp.
Additional information: link
Address._functionCallWithValue(address,bytes,uint256,string) (#374-395) uses assembly
- INLINE ASM (#387-390)
Do not use evm assembly.
Additional information: link
SafeMath.mod(uint256,uint256,string) (#242-245) is never used and should be removed
Remove unused functions.
Additional information: link
BscArmy._previousArmyReward (#728) is set pre-construction with a non-constant function or state variable:
- _armyReward
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Additional information: link
Low level call in Address._functionCallWithValue(address,bytes,uint256,string) (#374-395):
- (success,returndata) = target.call{value: weiValue}(data) (#378)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
Variable BscArmy._maxTxAmount (#736) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Redundant expression "this (#254)" inContext (#248-257)
Remove redundant statements if they congest code but offer no value.
Additional information: link
Variable BscArmy._transferFromExcluded(address,address,uint256).rTransferAmount (#1195) is too similar to BscArmy._transferFromExcluded(address,address,uint256).tTransferAmount (#1195)
Prevent variables from having similar names.
Additional information: link
BscArmy.slitherConstructorVariables() (#698-1210) uses literals with too many digits:
- numTokensSellToAddToLiquidity = 500000 * 10 ** 3 * 10 ** 9 (#737)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
BscArmy.numTokensSellToAddToLiquidity (#737) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
isExcludedFromFee(address) should be declared external:
- BscArmy.isExcludedFromFee(address) (#1036-1038)
Use the external attribute for functions never called from the contract.
Additional information: link
Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.
Token is deployed only at one blockchain
Token has only one trading pair
Unable to find PancakeSwap trading pair to compute liquidity.
Unable to find PancakeSwap trading pair to compute volume.
Unable to find PancakeSwap trading pair to compute number of swaps.
BscScan page for the token does not contain additional info: website, socials, description, etc.
Additional information: link
Token was delisted (assigned to inactive / untracked listing) from CoinMarketCap
Additional information: link
Unable to find token contract audit
Unable to find audit link on the website
Unable to find whitepaper link on the website
Unable to find token on CoinHunt
Additional information: link
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of scam / price dump / death
Token has no active CoinMarketCap listing / rank
Token has a considerable age, but social accounts / website are missing or have few users
Token has a considerable age, but average PancakeSwap 30d trading volume is low
Young tokens have high risks of price dump / death
Token has relatively low CoinGecko rank
Telegram account link seems to be invalid
Twitter account link seems to be invalid
Unable to find Discord account