BABYDRIP Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Reentrancy in BABYDRIP._transferFrom(address,address,uint256) (contracts/babydrip.sol#573-614):
External calls:
- swapBack() (contracts/babydrip.sol#583)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (contracts/babydrip.sol#657-663)
- dividendDistributor.deposit{value: amountBNBReflection}() (contracts/babydrip.sol#672)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
External calls sending eth:
- swapBack() (contracts/babydrip.sol#583)
- dividendDistributor.deposit{value: amountBNBReflection}() (contracts/babydrip.sol#672)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (contracts/babydrip.sol#591)
- _balances[recipient] = _balances[recipient].add(finalAmount) (contracts/babydrip.sol#599)
- finalAmount = takeFee(sender,recipient,amount) (contracts/babydrip.sol#598)
- _balances[address(this)] = _balances[address(this)].add(rewardAmount) (contracts/babydrip.sol#633)
- _balances[wm] = _balances[wm].add(marketingAmount) (contracts/babydrip.sol#637)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.distributeDividend(address) (contracts/babydrip.sol#258-269) ignores return value by RewardToken.transfer(shareholder,amount) (contracts/babydrip.sol#264)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (contracts/babydrip.sol#87) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (contracts/babydrip.sol#88)
Prevent variables from having similar names.

Additional information: link

Reentrancy in DividendDistributor.distributeDividend(address) (contracts/babydrip.sol#258-269):
External calls:
- RewardToken.transfer(shareholder,amount) (contracts/babydrip.sol#264)
State variables written after the call(s):
- shares[shareholder].totalRealised = shares[shareholder].totalRealised.add(amount) (contracts/babydrip.sol#266)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (contracts/babydrip.sol#267)
Reentrancy in DividendDistributor.process(uint256) (contracts/babydrip.sol#229-251):
External calls:
- distributeDividend(shareholders[currentIndex]) (contracts/babydrip.sol#243)
- RewardToken.transfer(shareholder,amount) (contracts/babydrip.sol#264)
State variables written after the call(s):
- currentIndex ++ (contracts/babydrip.sol#248)
Reentrancy in DividendDistributor.setShare(address,uint256) (contracts/babydrip.sol#192-207):
External calls:
- distributeDividend(shareholder) (contracts/babydrip.sol#195)
- RewardToken.transfer(shareholder,amount) (contracts/babydrip.sol#264)
State variables written after the call(s):
- shares[shareholder].amount = amount (contracts/babydrip.sol#205)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (contracts/babydrip.sol#206)
Apply the check-effects-interactions pattern.

Additional information: link

BABYDRIP.swapBack() (contracts/babydrip.sol#647-686) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
Ensure that all the return values of the function calls are used.

Additional information: link

DividendDistributor.setDistributionCriteria(uint256,uint256) (contracts/babydrip.sol#182-185) should emit an event for:
- minPeriod = newMinPeriod (contracts/babydrip.sol#183)
- minDistribution = newMinDistribution (contracts/babydrip.sol#184)
BABYDRIP.changeFees(uint256,uint256,uint256,uint256) (contracts/babydrip.sol#525-534) should emit an event for:
- marketingFee = newMarketingFee (contracts/babydrip.sol#526)
- liquidityFee = newLiqFee (contracts/babydrip.sol#527)
- rewardsFee = newRewardFee (contracts/babydrip.sol#528)
- totalFee = liquidityFee.add(rewardsFee) (contracts/babydrip.sol#532)
- totalFeeIfSelling = totalFee.add(extraFeeOnSell) (contracts/babydrip.sol#533)
Emit an event for critical parameter changes.

Additional information: link

Auth.constructor(address)._owner (contracts/babydrip.sol#308) lacks a zero-check on :
- owner = _owner (contracts/babydrip.sol#309)
Auth.transferOwnership(address).adr (contracts/babydrip.sol#358) lacks a zero-check on :
- owner = adr (contracts/babydrip.sol#359)
BABYDRIP.changeFeeReceivers(address).newLiquidityReceiver (contracts/babydrip.sol#536) lacks a zero-check on :
- autoLiquidityReceiver = newLiquidityReceiver (contracts/babydrip.sol#537)
Check that the address is not zero.

Additional information: link

DividendDistributor.distributeDividend(address) (contracts/babydrip.sol#258-269) has external calls inside a loop: RewardToken.transfer(shareholder,amount) (contracts/babydrip.sol#264)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in BABYDRIP._transferFrom(address,address,uint256) (contracts/babydrip.sol#573-614):
External calls:
- swapBack() (contracts/babydrip.sol#583)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (contracts/babydrip.sol#657-663)
- dividendDistributor.deposit{value: amountBNBReflection}() (contracts/babydrip.sol#672)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
External calls sending eth:
- swapBack() (contracts/babydrip.sol#583)
- dividendDistributor.deposit{value: amountBNBReflection}() (contracts/babydrip.sol#672)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
State variables written after the call(s):
- launch() (contracts/babydrip.sol#587)
- launchedAt = block.number (contracts/babydrip.sol#491)
Reentrancy in BABYDRIP.constructor() (contracts/babydrip.sol#428-456):
External calls:
- pair = IDEXFactory(router.factory()).createPair(router.WETH(),address(this)) (contracts/babydrip.sol#431)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = uint256(- 1) (contracts/babydrip.sol#432)
- _balances[msg.sender] = _totalSupply (contracts/babydrip.sol#452)
- dividendDistributor = new DividendDistributor(address(router)) (contracts/babydrip.sol#434)
- isDividendExempt[pair] = true (contracts/babydrip.sol#442)
- isDividendExempt[msg.sender] = true (contracts/babydrip.sol#443)
- isDividendExempt[address(this)] = true (contracts/babydrip.sol#444)
- isDividendExempt[DEAD] = true (contracts/babydrip.sol#445)
- isDividendExempt[ZERO] = true (contracts/babydrip.sol#446)
- isFeeExempt[msg.sender] = true (contracts/babydrip.sol#436)
- isFeeExempt[address(this)] = true (contracts/babydrip.sol#437)
- isTxLimitExempt[msg.sender] = true (contracts/babydrip.sol#439)
- isTxLimitExempt[pair] = true (contracts/babydrip.sol#440)
- totalFee = liquidityFee.add(rewardsFee) (contracts/babydrip.sol#448)
- totalFee = totalFee.add(marketingFee) (contracts/babydrip.sol#449)
- totalFeeIfSelling = totalFee.add(extraFeeOnSell) (contracts/babydrip.sol#450)
Reentrancy in DividendDistributor.deposit() (contracts/babydrip.sol#209-227):
External calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: msg.value}(0,path,address(this),block.timestamp) (contracts/babydrip.sol#217-222)
State variables written after the call(s):
- dividendsPerShare = dividendsPerShare.add(dividendsPerShareAccuracyFactor.mul(amount).div(totalShares)) (contracts/babydrip.sol#226)
- totalDividends = totalDividends.add(amount) (contracts/babydrip.sol#225)
Reentrancy in DividendDistributor.distributeDividend(address) (contracts/babydrip.sol#258-269):
External calls:
- RewardToken.transfer(shareholder,amount) (contracts/babydrip.sol#264)
State variables written after the call(s):
- shareholderClaims[shareholder] = block.timestamp (contracts/babydrip.sol#265)
Reentrancy in DividendDistributor.setShare(address,uint256) (contracts/babydrip.sol#192-207):
External calls:
- distributeDividend(shareholder) (contracts/babydrip.sol#195)
- RewardToken.transfer(shareholder,amount) (contracts/babydrip.sol#264)
State variables written after the call(s):
- addShareholder(shareholder) (contracts/babydrip.sol#199)
- shareholderIndexes[shareholder] = shareholders.length (contracts/babydrip.sol#293)
- removeShareholder(shareholder) (contracts/babydrip.sol#201)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (contracts/babydrip.sol#299)
- addShareholder(shareholder) (contracts/babydrip.sol#199)
- shareholders.push(shareholder) (contracts/babydrip.sol#294)
- removeShareholder(shareholder) (contracts/babydrip.sol#201)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (contracts/babydrip.sol#298)
- shareholders.pop() (contracts/babydrip.sol#300)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (contracts/babydrip.sol#204)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in BABYDRIP._transferFrom(address,address,uint256) (contracts/babydrip.sol#573-614):
External calls:
- swapBack() (contracts/babydrip.sol#583)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (contracts/babydrip.sol#657-663)
- dividendDistributor.deposit{value: amountBNBReflection}() (contracts/babydrip.sol#672)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
- dividendDistributor.setShare(sender,_balances[sender]) (contracts/babydrip.sol#603)
- dividendDistributor.setShare(recipient,_balances[recipient]) (contracts/babydrip.sol#607)
- dividendDistributor.process(distributorGas) (contracts/babydrip.sol#610)
External calls sending eth:
- swapBack() (contracts/babydrip.sol#583)
- dividendDistributor.deposit{value: amountBNBReflection}() (contracts/babydrip.sol#672)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
Event emitted after the call(s):
- Transfer(sender,recipient,finalAmount) (contracts/babydrip.sol#612)
Reentrancy in BABYDRIP._transferFrom(address,address,uint256) (contracts/babydrip.sol#573-614):
External calls:
- swapBack() (contracts/babydrip.sol#583)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (contracts/babydrip.sol#657-663)
- dividendDistributor.deposit{value: amountBNBReflection}() (contracts/babydrip.sol#672)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
External calls sending eth:
- swapBack() (contracts/babydrip.sol#583)
- dividendDistributor.deposit{value: amountBNBReflection}() (contracts/babydrip.sol#672)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
Event emitted after the call(s):
- Transfer(sender,address(this),rewardAmount) (contracts/babydrip.sol#634)
- finalAmount = takeFee(sender,recipient,amount) (contracts/babydrip.sol#598)
- Transfer(sender,wm,marketingAmount) (contracts/babydrip.sol#638)
- finalAmount = takeFee(sender,recipient,amount) (contracts/babydrip.sol#598)
Reentrancy in BABYDRIP.constructor() (contracts/babydrip.sol#428-456):
External calls:
- pair = IDEXFactory(router.factory()).createPair(router.WETH(),address(this)) (contracts/babydrip.sol#431)
Event emitted after the call(s):
- Transfer(address(0),msg.sender,_totalSupply) (contracts/babydrip.sol#453)
Reentrancy in BABYDRIP.swapBack() (contracts/babydrip.sol#647-686):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (contracts/babydrip.sol#657-663)
- dividendDistributor.deposit{value: amountBNBReflection}() (contracts/babydrip.sol#672)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
External calls sending eth:
- dividendDistributor.deposit{value: amountBNBReflection}() (contracts/babydrip.sol#672)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (contracts/babydrip.sol#676-683)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (contracts/babydrip.sol#684)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.shouldDistribute(address) (contracts/babydrip.sol#253-256) uses timestamp for comparisons
Dangerous comparisons:
- shareholderClaims[shareholder] + minPeriod < block.timestamp && getUnpaidEarnings(shareholder) > minDistribution (contracts/babydrip.sol#254-255)
Avoid relying on block.timestamp.

Additional information: link

DividendDistributor.process(uint256) (contracts/babydrip.sol#229-251) has costly operations inside a loop:
- currentIndex = 0 (contracts/babydrip.sol#240)
DividendDistributor.distributeDividend(address) (contracts/babydrip.sol#258-269) has costly operations inside a loop:
- totalDistributed = totalDistributed.add(amount) (contracts/babydrip.sol#263)
DividendDistributor.process(uint256) (contracts/babydrip.sol#229-251) has costly operations inside a loop:
- currentIndex ++ (contracts/babydrip.sol#248)
Use a local variable to hold the loop computation result.

Additional information: link

BABYDRIP._maxTxAmount (contracts/babydrip.sol#382) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 2 / 200
BABYDRIP._walletMax (contracts/babydrip.sol#383) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 1 / 100
BABYDRIP.swapThreshold (contracts/babydrip.sol#420) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 5 / 4000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Function IDEXRouter.WETH() (contracts/babydrip.sol#82) is not in mixedCase
Variable DividendDistributor._token (contracts/babydrip.sol#138) is not in mixedCase
Variable DividendDistributor.RewardToken (contracts/babydrip.sol#148) is not in mixedCase
Constant BABYDRIP._name (contracts/babydrip.sol#371) is not in UPPER_CASE_WITH_UNDERSCORES
Constant BABYDRIP._symbol (contracts/babydrip.sol#372) is not in UPPER_CASE_WITH_UNDERSCORES
Constant BABYDRIP._decimals (contracts/babydrip.sol#373) is not in UPPER_CASE_WITH_UNDERSCORES
Variable BABYDRIP.DEAD (contracts/babydrip.sol#375) is not in mixedCase
Variable BABYDRIP.ZERO (contracts/babydrip.sol#376) is not in mixedCase
Variable BABYDRIP.RewardToken (contracts/babydrip.sol#378) is not in mixedCase
Variable BABYDRIP._totalSupply (contracts/babydrip.sol#381) is not in mixedCase
Variable BABYDRIP._maxTxAmount (contracts/babydrip.sol#382) is not in mixedCase
Variable BABYDRIP._walletMax (contracts/babydrip.sol#383) is not in mixedCase
Variable BABYDRIP._balances (contracts/babydrip.sol#387) is not in mixedCase
Variable BABYDRIP._allowances (contracts/babydrip.sol#388) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

BABYDRIP.slitherConstructorVariables() (contracts/babydrip.sol#367-691) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (contracts/babydrip.sol#375)
BABYDRIP.slitherConstructorVariables() (contracts/babydrip.sol#367-691) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (contracts/babydrip.sol#376)
BABYDRIP.slitherConstructorVariables() (contracts/babydrip.sol#367-691) uses literals with too many digits:
- distributorGas = 500000 (contracts/babydrip.sol#414)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

BABYDRIP.RewardToken (contracts/babydrip.sol#378) is never used in BABYDRIP (contracts/babydrip.sol#367-691)
BABYDRIP.marketingWallet (contracts/babydrip.sol#379) is never used in BABYDRIP (contracts/babydrip.sol#367-691)
Remove unused state variables.

Additional information: link

BABYDRIP.DEAD (contracts/babydrip.sol#375) should be constant
BABYDRIP.RewardToken (contracts/babydrip.sol#378) should be constant
BABYDRIP.ZERO (contracts/babydrip.sol#376) should be constant
BABYDRIP._totalSupply (contracts/babydrip.sol#381) should be constant
BABYDRIP.marketingWallet (contracts/babydrip.sol#379) should be constant
BABYDRIP.routerAddress (contracts/babydrip.sol#377) should be constant
BABYDRIP.wm (contracts/babydrip.sol#408) should be constant
DividendDistributor.dividendsPerShareAccuracyFactor (contracts/babydrip.sol#159) should be constant
DividendDistributor.routerAddress (contracts/babydrip.sol#147) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

setRewardToken(address) should be declared external:
- DividendDistributor.setRewardToken(address) (contracts/babydrip.sol#188-190)
authorize(address) should be declared external:
- Auth.authorize(address) (contracts/babydrip.sol#330-332)
unauthorize(address) should be declared external:
- Auth.unauthorize(address) (contracts/babydrip.sol#337-339)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (contracts/babydrip.sol#358-362)
getCirculatingSupply() should be declared external:
- BABYDRIP.getCirculatingSupply() (contracts/babydrip.sol#467-469)
tradingStatus(bool) should be declared external:
- BABYDRIP.tradingStatus(bool) (contracts/babydrip.sol#643-645)
Use the external attribute for functions never called from the contract.

Additional information: link