AoE [aGold] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

aGold.addLiquidity(uint256,uint256) (#1191-1206) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#1197-1204)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

aGold.swapAndSendToFee(address,uint256) (#1118-1125) ignores return value by IERC20(BUSD).transfer(recipient,newBalance) (#1124)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

aGold.addLiquidity(uint256,uint256) (#1191-1206) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#1197-1204)
Ensure that all the return values of the function calls are used.

Additional information: link

aGold.setMaxWalletToken(uint256) (#1022-1024) should emit an event for:
- maxWalletTokens = maxToken (#1023)
Emit an event for critical parameter changes.

Additional information: link

aGold.whitelistDxSale(address,address)._presaleAddress (#1026) lacks a zero-check on :
- presaleAddress = _presaleAddress (#1027)
Check that the address is not zero.

Additional information: link

Reentrancy in aGold.updateUniswapV2Router(address) (#953-960):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(uniswapV2Router.factory()).createPair(address(this),uniswapV2Router.WETH()) (#957-958)
State variables written after the call(s):
- uniswapV2Pair = _uniswapV2Pair (#959)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in aGold._transfer(address,address,uint256) (#1043-1116):
External calls:
- swapAndSendToFee(_marketingWalletAddress,marketingTokens) (#1089)
- IERC20(BUSD).transfer(recipient,newBalance) (#1124)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1182-1188)
- swapAndSendToFee(_developmentWalletAddress,developmentTokens) (#1092)
- IERC20(BUSD).transfer(recipient,newBalance) (#1124)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1182-1188)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#1112)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#775)
- _balances[recipient] = _balances[recipient].add(amount) (#776)
- super._transfer(from,to,amount) (#1115)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#775)
- _balances[recipient] = _balances[recipient].add(amount) (#776)
- swapping = false (#1094)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in aGold.swapAndLiquify(uint256) (#1127-1148):
External calls:
- swapTokensForEth(half) (#1139)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1162-1168)
- addLiquidity(otherHalf,newBalance) (#1145)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#1197-1204)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1145)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#1197-1204)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#842)
- addLiquidity(otherHalf,newBalance) (#1145)
- SwapAndLiquify(half,newBalance,otherHalf) (#1147)
Apply the check-effects-interactions pattern.

Additional information: link

aGold.swapTokensForEth(uint256) (#1151-1170) is never used and should be removed
Remove unused functions.

Additional information: link

aGold.totalFees (#893) is set pre-construction with a non-constant function or state variable:
- developmentFee.add(marketingFee)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.6.2 (#562) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Variable aGold._ownerWallet (#897) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#106)" inContext (#100-109)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#123) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#124)
Prevent variables from having similar names.

Additional information: link

aGold.slitherConstructorVariables() (#866-1208) uses literals with too many digits:
- deadWallet = 0x000000000000000000000000000000000000dEaD (#874)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

aGold.deadWallet (#874) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

isExcludedFromFees(address) should be declared external:
- aGold.isExcludedFromFees(address) (#1039-1041)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Token was delisted (assigned to inactive / untracked listing) from CoinMarketCap

Additional information: link

Unable to find token contract audit

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find token on CoinHunt

Additional information: link

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death

Token has relatively low CoinGecko rank