Winnings [Show Me the Money] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Winnings.swapBack() (#868-896) sends eth to arbitrary user
Dangerous calls:
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#889)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

JackPot.random(uint256,uint8) (#460-550) uses a weak PRNG: "_rnd = _rnd % _totalPlayers (#548)"
Do not use block.timestamp, now or blockhash as a source of randomness

Additional information: link

Reentrancy in Winnings._transferFrom(address,address,uint256) (#785-807):
External calls:
- swapBack() (#792)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp) (#876-895)
- distributor.deposit{value: amountBNBReflection}() (#888)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#889)
External calls sending eth:
- swapBack() (#792)
- distributor.deposit{value: amountBNBReflection}() (#888)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#889)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#794)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#797)
- amountReceived = takeFee(sender,recipient,amount) (#796)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#847)
Apply the check-effects-interactions pattern.

Additional information: link

SafeToken.withdraw(address,uint256) (#382-385) ignores return value by IBEP20(_token).transfer(safeManager,_amount) (#384)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Not a direct threat, but may indicate unreliable intentions of developer. Widespread names (e.g. Elon, King, Moon, Doge) are common among meme-tokens and scams. The allow to gain free hype and attract unexperienced investors.

Reentrancy in DividendDistributor.setShare(address,uint256) (#242-256):
External calls:
- distributeDividend(shareholder) (#244)
- BUSD.transfer(shareholder,amount) (#332)
State variables written after the call(s):
- shares[shareholder].amount = amount (#254)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#255)
Apply the check-effects-interactions pattern.

Additional information: link

Winnings.swapBack() (#868-896) ignores return value by address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#889)
Ensure that the return value of a low-level call is checked or logged.

Additional information: link

Winnings.swapBack().e (#891) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

Winnings.setSwapBackSettings(bool,uint256) (#936-939) should emit an event for:
- swapThreshold = _amount (#938)
Emit an event for critical parameter changes.

Additional information: link

Winnings.setFeeReceivers(address)._marketingFeeReceiver (#932) lacks a zero-check on :
- marketingFeeReceiver = _marketingFeeReceiver (#933)
Check that the address is not zero.

Additional information: link

Variable 'Winnings.swapBack().e (#891)' in Winnings.swapBack() (#868-896) potentially used before declaration: SwapBackFailed(string(abi.encodePacked(SwapBack failed with error ,e))) (#892)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in DividendDistributor.setShare(address,uint256) (#242-256):
External calls:
- distributeDividend(shareholder) (#244)
- BUSD.transfer(shareholder,amount) (#332)
State variables written after the call(s):
- addShareholder(shareholder) (#248)
- shareholderIndexes[shareholder] = shareholders.length (#359)
- removeShareholder(shareholder) (#250)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#365)
- addShareholder(shareholder) (#248)
- shareholders.push(shareholder) (#360)
- removeShareholder(shareholder) (#250)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#364)
- shareholders.pop() (#366)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#253)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in Winnings.swapBack() (#868-896):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp) (#876-895)
Event emitted after the call(s):
- SwapBackFailed(string(abi.encodePacked(SwapBack failed with error ,e))) (#892)
- SwapBackFailed(SwapBack failed without an error message from pancakeSwap) (#894)
Apply the check-effects-interactions pattern.

Additional information: link

JackPot._checkLottery(address) (#552-570) uses timestamp for comparisons
Dangerous comparisons:
- block.timestamp > lastTimeWin.add(minPeriod) (#566)
Avoid relying on block.timestamp.

Additional information: link

DividendDistributor.process(uint256) (#295-319) has costly operations inside a loop:
- currentIndex ++ (#316)
Use a local variable to hold the loop computation result.

Additional information: link

Context._msgData() (#52-55) is never used and should be removed
Remove unused functions.

Additional information: link

Winnings.swapThreshold (#722) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 5000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

solc-0.8.6 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Winnings.swapBack() (#868-896):
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#889)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable Winnings._allowances (#694) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#53)" inContext (#47-56)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Reentrancy in JackPot.distributeLottery(address,uint256) (#578-607):
External calls:
- address(_winnerAddress).transfer(winAmount) (#582)
State variables written after the call(s):
- _allWon = _allWon.add(winAmount) (#597)
- addWinner(_winnerAddress,winAmount) (#596)
- lastTimeWin = block.timestamp (#644)
- addWinner(_winnerAddress,winAmount) (#596)
- lastWinner_address = userAddress (#643)
- addWinner(_winnerAddress,winAmount) (#596)
- lastWinner_value = _lastWon (#642)
- transactionsSinceLastLottery = 0 (#600)
- userByAddress[_winnerAddress].lastWon = winAmount (#589)
- userByAddress[_winnerAddress].totalWon = totalWon (#590)
- userByIndex[_index].lastWon = winAmount (#592)
- userByIndex[_index].totalWon = totalWon (#593)
Event emitted after the call(s):
- LotteryWon(_winnerAddress,winAmount) (#584)
Apply the check-effects-interactions pattern.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#138) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#139)
Prevent variables from having similar names.

Additional information: link

Winnings.slitherConstructorVariables() (#679-985) uses literals with too many digits:
- distributorGas = 500000 (#719)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

JackPot.BUSD (#438) is never used in Winnings (#679-985)
Remove unused state variables.

Additional information: link

Winnings.launchedAt (#714) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

isOverLiquified(uint256,uint256) should be declared external:
- Winnings.isOverLiquified(uint256,uint256) (#958-960)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Token is marked as scam (rug pull, honeypot, phishing, etc.)

Additional information: link

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death