Magic Academy is a revolutionary game that combines NFT and the new IDLE RPG. With a fascinating plot and diverse characters, Magic Academy will open an interesting magical adventure and battle journey for all players.
Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
sappToken._approve(address,address,uint256).owner (#357) shadows:
- Ownables.owner() (#125-127) (function)
Rename the local variables that shadow another component.
Additional information: link
sappToken.updateFee(uint256,uint256,uint256) (#331-338) should emit an event for:
- _TAX_FEE = _txFee * 100 (#332)
- _BURN_FEE = _burnFee * 100 (#333)
- _CHARITY_FEE = _charityFee * 100 (#334)
- ORIG_TAX_FEE = _TAX_FEE (#335)
- ORIG_BURN_FEE = _BURN_FEE (#336)
- ORIG_CHARITY_FEE = _CHARITY_FEE (#337)
Emit an event for critical parameter changes.
Additional information: link
sappToken.constructor(string,string,uint256,uint256,uint256,uint256,uint256,address,address).tokenOwner (#181) lacks a zero-check on :
- _owner = tokenOwner (#196)
Check that the address is not zero.
Additional information: link
Address._functionCallWithValue(address,bytes,uint256,string) (#102-120) uses assembly
- INLINE ASM (#112-115)
Do not use evm assembly.
Additional information: link
sappToken._transferToExcluded(address,address,uint256) (#407-416) is never used and should be removed
Remove unused functions.
Additional information: link
solc-0.8.4 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Low level call in Address._functionCallWithValue(address,bytes,uint256,string) (#102-120):
- (success,returndata) = target.call{value: weiValue}(data) (#106)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
Variable sappToken.ORIG_CHARITY_FEE (#179) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Redundant expression "this (#20)" inContext (#15-23)
Remove redundant statements if they congest code but offer no value.
Additional information: link
Variable sappToken._transferToExcluded(address,address,uint256).rTransferAmount (#409) is too similar to sappToken._transferBothExcluded(address,address,uint256).tTransferAmount (#444)
Prevent variables from having similar names.
Additional information: link
sappToken._MAX (#161) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
startMint() should be declared external:
- sappToken.startMint() (#544-547)
Use the external attribute for functions never called from the contract.
Additional information: link
BscScan page for the token does not contain additional info: website, socials, description, etc.
Additional information: link
Unable to find token/project description on the website or on BscScan, CoinMarketCap
Unable to find token contract audit
Unable to verify token contract address on the website
Unable to find audit link on the website
Unable to find whitepaper link on the website
Unable to find Telegram link on the website
Unable to find Twitter link on the website
Unable to find token on CoinHunt
Additional information: link
Young tokens have high risks of price dump / death
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of price dump / death
Token has relatively low CoinGecko rank
Token has relatively low CoinMarketCap rank
Twitter account link seems to be invalid
Unable to find Blog account (Reddit or Medium)
Unable to find Youtube account
Unable to find Discord account