SMBR [SOMBRA] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Sombra.addLiquidity(uint256,uint256) (#986-996) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#988-995)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in Sombra._transfer(address,address,uint256) (#800-840):
External calls:
- this.swapAndLiquify(numTokens) (#827)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#839)
- _rOwned[address(this)] = _rOwned[address(this)] + rLiquidity (#763)
- _rOwned[sender] -= rAmount (#906)
- _rOwned[sender] -= rAmount (#862)
- _rOwned[recipient] += rTransferAmount (#931)
- _rOwned[recipient] += rTransferAmount (#864)
- _tokenTransfer(from,to,amount,takeFee) (#839)
- _rSupply = _rSupply - rFee (#753)
- _rSupply -= rLiquidity (#760)
- _rSupply += rAmount (#934)
- _rSupply += (rAmount - rTransferAmount) (#888)
- _rSupply -= rTransferAmount (#911)
- _tokenTransfer(from,to,amount,takeFee) (#839)
- _tOwned[address(this)] = _tOwned[address(this)] + tLiquidity (#759)
- _tOwned[sender] -= tAmount (#883)
- _tOwned[sender] -= tAmount (#929)
- _tOwned[recipient] += tTransferAmount (#908)
- _tOwned[recipient] += tTransferAmount (#885)
- _tokenTransfer(from,to,amount,takeFee) (#839)
- _tSupply -= tLiquidity (#761)
- _tSupply -= tTransferAmount (#912)
- _tSupply += tAmount (#935)
- _tSupply += (tAmount - tTransferAmount) (#889)
Apply the check-effects-interactions pattern.

Additional information: link

Sombra.addLiquidity(uint256,uint256) (#986-996) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#988-995)
Ensure that all the return values of the function calls are used.

Additional information: link

Sombra._approve(address,address,uint256).owner (#780) shadows:
- Ownable.owner() (#368-370) (function)
Rename the local variables that shadow another component.

Additional information: link

Timelock.executeTransaction(address,uint256,string,bytes,uint256).target (#1306) lacks a zero-check on :
- (success,returnData) = target.call{value: value}(callData) (#1327)
Check that the address is not zero.

Additional information: link

Reentrancy in Sombra.transferFrom(address,address,uint256) (#533-542):
External calls:
- _transfer(sender,recipient,amount) (#534)
- this.swapAndLiquify(numTokens) (#827)
State variables written after the call(s):
- _approve(sender,_msgSender(),currentAllowance - amount) (#539)
- _allowances[owner][spender] = amount (#784)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in Sombra.transferFrom(address,address,uint256) (#533-542):
External calls:
- _transfer(sender,recipient,amount) (#534)
- this.swapAndLiquify(numTokens) (#827)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#785)
- _approve(sender,_msgSender(),currentAllowance - amount) (#539)
Apply the check-effects-interactions pattern.

Additional information: link

Timelock.executeTransaction(address,uint256,string,bytes,uint256) (#1306-1333) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(getBlockTimestamp() >= eta,Timelock::executeTransaction: Transaction hasn't surpassed time lock.) (#1311)
- require(bool,string)(getBlockTimestamp() <= eta + GRACE_PERIOD,Timelock::executeTransaction: Transaction is stale.) (#1313)
Avoid relying on block.timestamp.

Additional information: link

Address.verifyCallResult(bool,bytes,string) (#218-238) uses assembly
- INLINE ASM (#230-233)
Do not use evm assembly.

Additional information: link

Context._msgData() (#23-25) is never used and should be removed
Remove unused functions.

Additional information: link

solc-0.8.7 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Timelock.executeTransaction(address,uint256,string,bytes,uint256) (#1306-1333):
- (success,returnData) = target.call{value: value}(callData) (#1327)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable Timelock.admin_initialized (#1237) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#1074) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#1075)
Prevent variables from having similar names.

Additional information: link

Sombra.slitherConstructorConstantVariables() (#407-997) uses literals with too many digits:
- TOTAL_SUPPLY = 100000000 * 10 ** DECIMALS (#422)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

executeTransaction(address,uint256,string,bytes,uint256) should be declared external:
- Timelock.executeTransaction(address,uint256,string,bytes,uint256) (#1306-1333)
Use the external attribute for functions never called from the contract.

Additional information: link

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute number of swaps.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token contract audit

Unable to find audit link on the website

Unable to find token on CoinHunt

Additional information: link

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death

Token has relatively low CoinGecko rank

Token has relatively low CoinMarketCap rank