SGI [Shinigami] Token

Shinigami.swapBack() (#373-414) sends eth to arbitrary user
Dangerous calls:
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#398)
- (devSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBdev}() (#400)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in Shinigami._transferFrom(address,address,uint256) (#297-326):
External calls:
- swapBack() (#315)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#384-390)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#398)
- (devSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBdev}() (#400)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#404-411)
External calls sending eth:
- swapBack() (#315)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#398)
- (devSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBdev}() (#400)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#404-411)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#319)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#322)
- amountReceived = takeFee(sender,recipient,amount) (#321)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#352)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ownership is not renounced (belongs to a wallet)

Shinigami.slitherConstructorVariables() (#193-510) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#197)
Shinigami.slitherConstructorVariables() (#193-510) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#198)
Shinigami.slitherConstructorVariables() (#193-510) uses literals with too many digits:
- _totalSupply = 10000000000 * (10 ** _decimals) (#205)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

Shinigami.DEAD (#197) should be constant
Shinigami.WBNB (#196) should be constant
Shinigami.ZERO (#198) should be constant
Shinigami._totalSupply (#205) should be constant
Shinigami.routerAddress (#199) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

Shinigami.slitherConstructorVariables() (#193-510) performs a multiplication on the result of a division:
-swapThreshold = _totalSupply / 1000 * 1 (#234)
Consider ordering multiplication before division.

Additional information: link

Shinigami.swapBack() (#373-414) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#404-411)
Ensure that all the return values of the function calls are used.

Additional information: link

Shinigami.setFees(uint256,uint256,uint256,uint256) (#443-450) should emit an event for:
- liquidityFee = _liquidityFee (#444)
- marketingFee = _marketingFee (#445)
- devFee = _devFee (#446)
- totalFee = _liquidityFee.add(_marketingFee).add(_devFee) (#447)
- feeDenominator = _feeDenominator (#448)
Shinigami.setSellMultiplier(uint256) (#465-467) should emit an event for:
- _sellMultiplier = multiplier (#466)
Shinigami.setTxLimit(uint256) (#473-476) should emit an event for:
- _maxTxAmount = amountBuy (#474)
Emit an event for critical parameter changes.

Additional information: link

Auth.transferOwnership(address).adr (#132) lacks a zero-check on :
- owner = adr (#133)
Shinigami.setFeeReceiver(address,address)._marketingFeeReceiver (#468) lacks a zero-check on :
- marketingFeeReceiver = _marketingFeeReceiver (#469)
Shinigami.setFeeReceiver(address,address)._devFeeReceiver (#468) lacks a zero-check on :
- devFeeReceiver = _devFeeReceiver (#470)
Check that the address is not zero.

Additional information: link

Reentrancy in Shinigami._transferFrom(address,address,uint256) (#297-326):
External calls:
- swapBack() (#315)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#384-390)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#398)
- (devSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBdev}() (#400)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#404-411)
External calls sending eth:
- swapBack() (#315)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#398)
- (devSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBdev}() (#400)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#404-411)
State variables written after the call(s):
- launch() (#317)
- launchedAt = block.number (#434)
Reentrancy in Shinigami.constructor() (#243-263):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#245)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = type()(uint256).max (#246)
- _balances[_owner] = _totalSupply (#261)
- isFeeExempt[msg.sender] = true (#249)
- isTimelockExempt[msg.sender] = true (#256)
- isTimelockExempt[DEAD] = true (#257)
- isTimelockExempt[address(this)] = true (#258)
- isTxLimitExempt[msg.sender] = true (#251)
- isTxLimitExempt[address(this)] = true (#252)
- isTxLimitExempt[routerAddress] = true (#253)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in Shinigami._transferFrom(address,address,uint256) (#297-326):
External calls:
- swapBack() (#315)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#384-390)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#398)
- (devSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBdev}() (#400)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#404-411)
External calls sending eth:
- swapBack() (#315)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#398)
- (devSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBdev}() (#400)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#404-411)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#353)
- amountReceived = takeFee(sender,recipient,amount) (#321)
- Transfer(sender,recipient,amountReceived) (#324)
Reentrancy in Shinigami.constructor() (#243-263):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#245)
Event emitted after the call(s):
- Transfer(address(0),_owner,_totalSupply) (#262)
Reentrancy in Shinigami.swapBack() (#373-414):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#384-390)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#398)
- (devSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBdev}() (#400)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#404-411)
External calls sending eth:
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#398)
- (devSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBdev}() (#400)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#404-411)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#412)
Apply the check-effects-interactions pattern.

Additional information: link

Shinigami._transferFrom(address,address,uint256) (#297-326) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(cooldownTimer[recipient] < block.timestamp,Please wait for 1min between two operations) (#312)
Avoid relying on block.timestamp.

Additional information: link

Shinigami.buyTokens(uint256,address) (#416-427) is never used and should be removed
Remove unused functions.

Additional information: link

Shinigami._maxTxAmount (#206) is set pre-construction with a non-constant function or state variable:
- (_totalSupply * 2) / 100
Shinigami._maxWalletSize (#207) is set pre-construction with a non-constant function or state variable:
- (_totalSupply * 3) / 100
Shinigami.swapThreshold (#234) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 1000 * 1
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.8.11 (#14) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.11 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Shinigami.swapBack() (#373-414):
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#398)
- (devSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBdev}() (#400)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable Auth._intAddr (#79) is not in mixedCase
Function IDEXRouter.WETH() (#147) is not in mixedCase
Parameter Shinigami.tradingStatus(bool)._status (#359) is not in mixedCase
Parameter Shinigami.setFees(uint256,uint256,uint256,uint256)._liquidityFee (#443) is not in mixedCase
Parameter Shinigami.setFees(uint256,uint256,uint256,uint256)._marketingFee (#443) is not in mixedCase
Parameter Shinigami.setFees(uint256,uint256,uint256,uint256)._devFee (#443) is not in mixedCase
Parameter Shinigami.setFees(uint256,uint256,uint256,uint256)._feeDenominator (#443) is not in mixedCase
Parameter Shinigami.cooldownEnabled(bool,uint8)._status (#452) is not in mixedCase
Parameter Shinigami.cooldownEnabled(bool,uint8)._interval (#452) is not in mixedCase
Parameter Shinigami.setFeeReceiver(address,address)._marketingFeeReceiver (#468) is not in mixedCase
Parameter Shinigami.setFeeReceiver(address,address)._devFeeReceiver (#468) is not in mixedCase
Parameter Shinigami.setSwapBackSettings(bool,uint256)._enabled (#477) is not in mixedCase
Parameter Shinigami.setSwapBackSettings(bool,uint256)._amount (#477) is not in mixedCase
Parameter Shinigami.blacklistAddress(address,bool)._address (#482) is not in mixedCase
Parameter Shinigami.blacklistAddress(address,bool)._value (#482) is not in mixedCase
Parameter Shinigami.transferForeignToken(address)._token (#490) is not in mixedCase
Variable Shinigami.WBNB (#196) is not in mixedCase
Variable Shinigami.DEAD (#197) is not in mixedCase
Variable Shinigami.ZERO (#198) is not in mixedCase
Constant Shinigami._name (#201) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Shinigami._symbol (#202) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Shinigami._decimals (#203) is not in UPPER_CASE_WITH_UNDERSCORES
Variable Shinigami._totalSupply (#205) is not in mixedCase
Variable Shinigami._maxTxAmount (#206) is not in mixedCase
Variable Shinigami._maxWalletSize (#207) is not in mixedCase
Variable Shinigami._balances (#209) is not in mixedCase
Variable Shinigami._allowances (#210) is not in mixedCase
Variable Shinigami._sellMultiplier (#222) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#152) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#153)
Prevent variables from having similar names.

Additional information: link

authorize(address) should be declared external:
- Auth.authorize(address) (#103-105)
unauthorize(address) should be declared external:
- Auth.unauthorize(address) (#111-113)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#132-136)
tradingStatus(bool) should be declared external:
- Shinigami.tradingStatus(bool) (#359-364)
cooldownEnabled(bool,uint8) should be declared external:
- Shinigami.cooldownEnabled(bool,uint8) (#452-455)
blacklistAddress(address,bool) should be declared external:
- Shinigami.blacklistAddress(address,bool) (#482-484)
transferForeignToken(address) should be declared external:
- Shinigami.transferForeignToken(address) (#490-494)
isOverLiquified(uint256,uint256) should be declared external:
- Shinigami.isOverLiquified(uint256,uint256) (#504-506)
Use the external attribute for functions never called from the contract.

Additional information: link

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Contract has 10% buy tax and 10% sell tax.
Taxes are low but contract ownership is not renounced. Token has a high risk of becoming a honeypot.

Average 30d PancakeSwap volume is low.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find website, listings and other project-related information

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank