RFI [Renren Finance] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

RFIToken.allowance(address,address).owner (#568) shadows:
- Ownable.owner() (#447-449) (function)
RFIToken._approve(address,address,uint256).owner (#653) shadows:
- Ownable.owner() (#447-449) (function)
Rename the local variables that shadow another component.

Additional information: link

RFIToken.setFundAddress(address)._fundAddress (#538) lacks a zero-check on :
- fundAddress = _fundAddress (#539)
Check that the address is not zero.

Additional information: link

Address.isContract(address) (#295-304) uses assembly
- INLINE ASM (#302)
Address._functionCallWithValue(address,bytes,uint256,string) (#388-409) uses assembly
- INLINE ASM (#401-404)
Do not use evm assembly.

Additional information: link

Different versions of Solidity is used:
- Version used: ['^0.6.0', '^0.6.2']
- ^0.6.0 (#3)
- ^0.6.0 (#30)
- ^0.6.0 (#110)
- ^0.6.2 (#272)
- ^0.6.0 (#416)
- ^0.6.2 (#484)
Use one Solidity version.

Additional information: link

RFIToken.includeAccount(address) (#640-651) has costly operations inside a loop:
- _excluded.pop() (#647)
Use a local variable to hold the loop computation result.

Additional information: link

Address._functionCallWithValue(address,bytes,uint256,string) (#388-409) is never used and should be removed
Address.functionCall(address,bytes) (#348-350) is never used and should be removed
Address.functionCall(address,bytes,string) (#358-360) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256) (#373-375) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256,string) (#383-386) is never used and should be removed
Address.isContract(address) (#295-304) is never used and should be removed
Address.sendValue(address,uint256) (#322-328) is never used and should be removed
Context._msgData() (#20-23) is never used and should be removed
SafeMath.mod(uint256,uint256) (#246-248) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#262-265) is never used and should be removed
Remove unused functions.

Additional information: link

RFIToken._rTotal (#499) is set pre-construction with a non-constant function or state variable:
- (MAX - (MAX % _tTotal))
RFIToken._previousTaxFee (#518) is set pre-construction with a non-constant function or state variable:
- _taxFee
RFIToken._previousBurnFee (#520) is set pre-construction with a non-constant function or state variable:
- _burnFee
RFIToken._previousFundFee (#522) is set pre-construction with a non-constant function or state variable:
- _fundFee
RFIToken._previousLPFee (#524) is set pre-construction with a non-constant function or state variable:
- _lpFee
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.6.0 (#3) allows old versions
Pragma version^0.6.0 (#30) allows old versions
Pragma version^0.6.0 (#110) allows old versions
Pragma version^0.6.2 (#272) allows old versions
Pragma version^0.6.0 (#416) allows old versions
Pragma version^0.6.2 (#484) allows old versions
solc-0.6.2 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Address.sendValue(address,uint256) (#322-328):
- (success) = recipient.call{value: amount}() (#326)
Low level call in Address._functionCallWithValue(address,bytes,uint256,string) (#388-409):
- (success,returndata) = target.call{value: weiValue}(data) (#392)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Parameter RFIToken.setFundAddress(address)._fundAddress (#538) is not in mixedCase
Parameter RFIToken.calculateTaxFee(uint256)._amount (#709) is not in mixedCase
Parameter RFIToken.calculateBurnFee(uint256)._amount (#715) is not in mixedCase
Parameter RFIToken.calculateFundFee(uint256)._amount (#721) is not in mixedCase
Parameter RFIToken.calculateLPFee(uint256)._amount (#727) is not in mixedCase
Variable RFIToken._burnPool (#508) is not in mixedCase
Variable RFIToken._taxFee (#517) is not in mixedCase
Variable RFIToken._burnFee (#519) is not in mixedCase
Variable RFIToken._fundFee (#521) is not in mixedCase
Variable RFIToken._lpFee (#523) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#21)" inContext (#15-24)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable RFIToken._transferStandard(address,address,uint256).rTransferAmount (#682) is too similar to RFIToken._transferStandard(address,address,uint256).tTransferAmount (#682)
Variable RFIToken._getRValues(uint256,uint256,uint256,uint256).rTransferAmount (#800) is too similar to RFIToken._getTValues(uint256).tTransferAmount (#783)
Variable RFIToken._getRValues(uint256,uint256,uint256,uint256).rTransferAmount (#800) is too similar to RFIToken._transferStandard(address,address,uint256).tTransferAmount (#682)
Variable RFIToken.reflectionFromToken(uint256,bool).rTransferAmount (#620) is too similar to RFIToken._transferStandard(address,address,uint256).tTransferAmount (#682)
Variable RFIToken.reflectionFromToken(uint256,bool).rTransferAmount (#620) is too similar to RFIToken._getValues(uint256).tTransferAmount (#772)
Variable RFIToken.reflectionFromToken(uint256,bool).rTransferAmount (#620) is too similar to RFIToken._getTValues(uint256).tTransferAmount (#783)
Variable RFIToken._transferStandard(address,address,uint256).rTransferAmount (#682) is too similar to RFIToken._getValues(uint256).tTransferAmount (#772)
Variable RFIToken._getValues(uint256).rTransferAmount (#773) is too similar to RFIToken._transferStandard(address,address,uint256).tTransferAmount (#682)
Variable RFIToken._getValues(uint256).rTransferAmount (#773) is too similar to RFIToken._getValues(uint256).tTransferAmount (#772)
Variable RFIToken._transferStandard(address,address,uint256).rTransferAmount (#682) is too similar to RFIToken._getTValues(uint256).tTransferAmount (#783)
Variable RFIToken._getValues(uint256).rTransferAmount (#773) is too similar to RFIToken._getTValues(uint256).tTransferAmount (#783)
Variable RFIToken._getRValues(uint256,uint256,uint256,uint256).rTransferAmount (#800) is too similar to RFIToken._getValues(uint256).tTransferAmount (#772)
Prevent variables from having similar names.

Additional information: link

RFIToken.slitherConstructorVariables() (#486-822) uses literals with too many digits:
- _tTotal = 210000000 * 10 ** 18 (#498)
RFIToken.slitherConstructorVariables() (#486-822) uses literals with too many digits:
- _burnPool = 0x000000000000000000000000000000000000dEaD (#508)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

RFIToken._burnPool (#508) should be constant
RFIToken._decimals (#506) should be constant
RFIToken._name (#504) should be constant
RFIToken._symbol (#505) should be constant
RFIToken.lpAddress (#510) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#466-469)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#475-479)
setFundAddress(address) should be declared external:
- RFIToken.setFundAddress(address) (#538-540)
name() should be declared external:
- RFIToken.name() (#542-544)
symbol() should be declared external:
- RFIToken.symbol() (#546-548)
decimals() should be declared external:
- RFIToken.decimals() (#550-552)
totalSupply() should be declared external:
- RFIToken.totalSupply() (#554-556)
balanceOf(address) should be declared external:
- RFIToken.balanceOf(address) (#558-561)
transfer(address,uint256) should be declared external:
- RFIToken.transfer(address,uint256) (#563-566)
allowance(address,address) should be declared external:
- RFIToken.allowance(address,address) (#568-570)
approve(address,uint256) should be declared external:
- RFIToken.approve(address,uint256) (#572-575)
transferFrom(address,address,uint256) should be declared external:
- RFIToken.transferFrom(address,address,uint256) (#577-581)
increaseAllowance(address,uint256) should be declared external:
- RFIToken.increaseAllowance(address,uint256) (#583-586)
decreaseAllowance(address,uint256) should be declared external:
- RFIToken.decreaseAllowance(address,uint256) (#588-591)
isExcluded(address) should be declared external:
- RFIToken.isExcluded(address) (#593-595)
totalFees() should be declared external:
- RFIToken.totalFees() (#597-599)
totalBurn() should be declared external:
- RFIToken.totalBurn() (#601-603)
reflect(uint256) should be declared external:
- RFIToken.reflect(uint256) (#605-612)
reflectionFromToken(uint256,bool) should be declared external:
- RFIToken.reflectionFromToken(uint256,bool) (#614-623)
excludeFromFee(address) should be declared external:
- RFIToken.excludeFromFee(address) (#752-754)
includeInFee(address) should be declared external:
- RFIToken.includeInFee(address) (#756-758)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Token has a considerable age, but we're still unable to find its website

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Token has a considerable age, but social accounts / website are missing or have few users

Token has a considerable age, but average PancakeSwap 30d trading volume is low

Young tokens have high risks of price dump / death