Raiders [MoonRaiders] Token

MoonRaiders.contractSwap() (#569-623) sends eth to arbitrary user
Dangerous calls:
- _feeWallets.marketing.transfer(amountETH.mul(fees.marketing).div(totalFees)) (#602-604)
- _feeWallets.dev.transfer(amountETH.mul(fees.dev).div(totalFees)) (#605)
- _feeWallets.rocket.transfer(amountETH.mul(fees.rocket).div(totalFees)) (#606)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Reentrancy in MoonRaiders._transferFrom(address,address,uint256) (#411-463):
External calls:
- contractSwap() (#451)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#590-596)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
External calls sending eth:
- contractSwap() (#451)
- _feeWallets.marketing.transfer(amountETH.mul(fees.marketing).div(totalFees)) (#602-604)
- _feeWallets.dev.transfer(amountETH.mul(fees.dev).div(totalFees)) (#605)
- _feeWallets.rocket.transfer(amountETH.mul(fees.rocket).div(totalFees)) (#606)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
State variables written after the call(s):
- _transferWithFees(sender,recipient,amount) (#459)
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#502)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#560)
- _balances[recipient] = _balances[recipient].add(amountAfterFees) (#563)
- _transferWithoutFees(sender,recipient,amount) (#461)
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#486)
- _balances[recipient] = _balances[recipient].add(amount) (#487)
Apply the check-effects-interactions pattern.

Additional information: link

Contract ownership is not renounced (belongs to a wallet)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

MoonRaiders.checkFee() (#724-740) performs a multiplication on the result of a division:
-fees = _fees.total.mul(100).div(_fees.divisor).mul(_multipliers.buyMultiplier).div(_multipliers.divisor) (#726-731)
MoonRaiders.checkFee() (#724-740) performs a multiplication on the result of a division:
-fees = _fees.total.mul(100).div(_fees.divisor).mul(_multipliers.sellMultiplier).div(_multipliers.divisor) (#733-738)
Consider ordering multiplication before division.

Additional information: link

MoonRaiders.airDrop(address,address[],uint256[]).i (#639) is a local variable never initialized
MoonRaiders._transferWithFees(address,address,uint256).feeAmount (#500) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

MoonRaiders.contractSwap() (#569-623) ignores return value by router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
Ensure that all the return values of the function calls are used.

Additional information: link

Pragma version^0.8.9 (#3) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.9 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

MoonRaiders.setLightYearDuration(uint256) (#650-652) should emit an event for:
- lightYearDuration = _seconds (#651)
MoonRaiders.setMaxHoldingPercent(uint256,uint256) (#662-671) should emit an event for:
- _maxHoldings = (_totalSupply * percent) / base (#666)
MoonRaiders.setMaxHoldingAmount(uint256) (#673-679) should emit an event for:
- _maxHoldings = amount (#674)
MoonRaiders.setMaxTxPercent(uint256,uint256) (#681-687) should emit an event for:
- _maxTxAmount = (_totalSupply * percent) / base (#682)
MoonRaiders.setMaxTxAmount(uint256) (#689-695) should emit an event for:
- _maxTxAmount = amount (#690)
MoonRaiders.setSwapSettings(bool,uint256,uint256) (#780-788) should emit an event for:
- swapThreshold = _swapThreshold (#786)
- swapTransactionThreshold = _swapTransactionThreshold (#787)
MoonRaiders.setTargetLiquidity(uint256,uint256) (#790-796) should emit an event for:
- targetLiquidity = _target (#794)
- targetLiquidityDenominator = _denominator (#795)
MoonRaiders.tradingStatus(bool,uint256) (#814-821) should emit an event for:
- deadBlocks = _deadBlocks (#819)
Emit an event for critical parameter changes.

Additional information: link

Auth.transferOwnership(address).adr (#123) lacks a zero-check on :
- owner = adr (#124)
MoonRaiders.setNftContract(address)._nftContract (#646) lacks a zero-check on :
- nftContract = _nftContract (#647)
MoonRaiders.setAutoLiquidityReceiver(address)._autoLiquidityReceiver (#752) lacks a zero-check on :
- autoLiquidityReceiver = _autoLiquidityReceiver (#756)
Check that the address is not zero.

Additional information: link

Reentrancy in MoonRaiders._transferFrom(address,address,uint256) (#411-463):
External calls:
- contractSwap() (#451)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#590-596)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
External calls sending eth:
- contractSwap() (#451)
- _feeWallets.marketing.transfer(amountETH.mul(fees.marketing).div(totalFees)) (#602-604)
- _feeWallets.dev.transfer(amountETH.mul(fees.dev).div(totalFees)) (#605)
- _feeWallets.rocket.transfer(amountETH.mul(fees.rocket).div(totalFees)) (#606)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
State variables written after the call(s):
- lightYearBlockTimeStamp = block.timestamp (#455)
Reentrancy in MoonRaiders.constructor() (#325-340):
External calls:
- pair = DexFactory(router.factory()).createPair(router.WETH(),address(this)) (#327-330)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = type()(uint256).max (#331)
- _balances[msg.sender] = _totalSupply (#338)
- autoLiquidityReceiver = msg.sender (#337)
- isFeeExempt[msg.sender] = true (#333)
- isFeeExempt[_feeWallets.rocket] = true (#335)
- isTxLimitExempt[msg.sender] = true (#334)
- isTxLimitExempt[_feeWallets.rocket] = true (#336)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in MoonRaiders._transferFrom(address,address,uint256) (#411-463):
External calls:
- contractSwap() (#451)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#590-596)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
External calls sending eth:
- contractSwap() (#451)
- _feeWallets.marketing.transfer(amountETH.mul(fees.marketing).div(totalFees)) (#602-604)
- _feeWallets.dev.transfer(amountETH.mul(fees.dev).div(totalFees)) (#605)
- _feeWallets.rocket.transfer(amountETH.mul(fees.rocket).div(totalFees)) (#606)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#488)
- _transferWithoutFees(sender,recipient,amount) (#461)
- Transfer(sender,address(this),feeAmount) (#561)
- _transferWithFees(sender,recipient,amount) (#459)
- Transfer(sender,recipient,amountAfterFees) (#564)
- _transferWithFees(sender,recipient,amount) (#459)
Reentrancy in MoonRaiders.constructor() (#325-340):
External calls:
- pair = DexFactory(router.factory()).createPair(router.WETH(),address(this)) (#327-330)
Event emitted after the call(s):
- Transfer(address(0),msg.sender,_totalSupply) (#339)
Reentrancy in MoonRaiders.contractSwap() (#569-623):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#590-596)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
External calls sending eth:
- _feeWallets.marketing.transfer(amountETH.mul(fees.marketing).div(totalFees)) (#602-604)
- _feeWallets.dev.transfer(amountETH.mul(fees.dev).div(totalFees)) (#605)
- _feeWallets.rocket.transfer(amountETH.mul(fees.rocket).div(totalFees)) (#606)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
Event emitted after the call(s):
- AutoLiquify(amountETHLiquidity,amountToLiquify) (#621)
Apply the check-effects-interactions pattern.

Additional information: link

MoonRaiders._transferWithFees(address,address,uint256) (#492-567) uses timestamp for comparisons
Dangerous comparisons:
- lightYearEnabled && (block.timestamp < lightYearBlockTimeStamp + lightYearDuration) (#509-510)
- lightYearEnabled && (block.timestamp < lightYearBlockTimeStamp + lightYearDuration) (#531-532)
Avoid relying on block.timestamp.

Additional information: link

Function DexRouter.WETH() (#199) is not in mixedCase
Parameter MoonRaiders.setNftContract(address)._nftContract (#646) is not in mixedCase
Parameter MoonRaiders.setLightYearDuration(uint256)._seconds (#650) is not in mixedCase
Parameter MoonRaiders.enableLightYear(bool)._status (#654) is not in mixedCase
Parameter MoonRaiders.enableNft(bool)._status (#658) is not in mixedCase
Parameter MoonRaiders.setAutoLiquidityReceiver(address)._autoLiquidityReceiver (#752) is not in mixedCase
Parameter MoonRaiders.setLockingMode(bool)._status (#764) is not in mixedCase
Parameter MoonRaiders.setLocks(address,bool)._address (#768) is not in mixedCase
Parameter MoonRaiders.setSwapSettings(bool,uint256,uint256)._enabled (#781) is not in mixedCase
Parameter MoonRaiders.setSwapSettings(bool,uint256,uint256)._swapThreshold (#782) is not in mixedCase
Parameter MoonRaiders.setSwapSettings(bool,uint256,uint256)._swapTransactionThreshold (#783) is not in mixedCase
Parameter MoonRaiders.setTargetLiquidity(uint256,uint256)._target (#790) is not in mixedCase
Parameter MoonRaiders.setTargetLiquidity(uint256,uint256)._denominator (#790) is not in mixedCase
Parameter MoonRaiders.tradingStatus(bool,uint256)._status (#814) is not in mixedCase
Parameter MoonRaiders.tradingStatus(bool,uint256)._deadBlocks (#814) is not in mixedCase
Constant MoonRaiders._name (#231) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MoonRaiders._symbol (#232) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MoonRaiders._decimals (#233) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MoonRaiders._totalSupply (#234) is not in UPPER_CASE_WITH_UNDERSCORES
Variable MoonRaiders._balances (#236) is not in mixedCase
Variable MoonRaiders._allowances (#237) is not in mixedCase
Variable MoonRaiders._maxTxAmount (#239) is not in mixedCase
Variable MoonRaiders._maxHoldings (#240) is not in mixedCase
Variable MoonRaiders._fees (#276-284) is not in mixedCase
Variable MoonRaiders._multipliers (#286-292) is not in mixedCase
Variable MoonRaiders._feeWallets (#294-299) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Reentrancy in MoonRaiders._transferFrom(address,address,uint256) (#411-463):
External calls:
- contractSwap() (#451)
- _feeWallets.marketing.transfer(amountETH.mul(fees.marketing).div(totalFees)) (#602-604)
- _feeWallets.dev.transfer(amountETH.mul(fees.dev).div(totalFees)) (#605)
- _feeWallets.rocket.transfer(amountETH.mul(fees.rocket).div(totalFees)) (#606)
External calls sending eth:
- contractSwap() (#451)
- _feeWallets.marketing.transfer(amountETH.mul(fees.marketing).div(totalFees)) (#602-604)
- _feeWallets.dev.transfer(amountETH.mul(fees.dev).div(totalFees)) (#605)
- _feeWallets.rocket.transfer(amountETH.mul(fees.rocket).div(totalFees)) (#606)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
State variables written after the call(s):
- _transferWithFees(sender,recipient,amount) (#459)
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#502)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#560)
- _balances[recipient] = _balances[recipient].add(amountAfterFees) (#563)
- _transferWithoutFees(sender,recipient,amount) (#461)
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#486)
- _balances[recipient] = _balances[recipient].add(amount) (#487)
- lightYearBlockTimeStamp = block.timestamp (#455)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#488)
- _transferWithoutFees(sender,recipient,amount) (#461)
- Transfer(sender,address(this),feeAmount) (#561)
- _transferWithFees(sender,recipient,amount) (#459)
- Transfer(sender,recipient,amountAfterFees) (#564)
- _transferWithFees(sender,recipient,amount) (#459)
Reentrancy in MoonRaiders.contractSwap() (#569-623):
External calls:
- _feeWallets.marketing.transfer(amountETH.mul(fees.marketing).div(totalFees)) (#602-604)
- _feeWallets.dev.transfer(amountETH.mul(fees.dev).div(totalFees)) (#605)
- _feeWallets.rocket.transfer(amountETH.mul(fees.rocket).div(totalFees)) (#606)
External calls sending eth:
- _feeWallets.marketing.transfer(amountETH.mul(fees.marketing).div(totalFees)) (#602-604)
- _feeWallets.dev.transfer(amountETH.mul(fees.dev).div(totalFees)) (#605)
- _feeWallets.rocket.transfer(amountETH.mul(fees.rocket).div(totalFees)) (#606)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#613-620)
Event emitted after the call(s):
- AutoLiquify(amountETHLiquidity,amountToLiquify) (#621)
Apply the check-effects-interactions pattern.

Additional information: link

MoonRaiders.slitherConstructorConstantVariables() (#226-823) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#229)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

authorize(address) should be declared external:
- Auth.authorize(address) (#106-108)
unauthorize(address) should be declared external:
- Auth.unauthorize(address) (#110-113)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#123-127)
tradingStatus(bool,uint256) should be declared external:
- MoonRaiders.tradingStatus(bool,uint256) (#814-821)
Use the external attribute for functions never called from the contract.

Additional information: link

Token seems to be untradeable: there is no PancakeSwap trading pair and no trading volumes. Ignore for presale.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token contract audit

Unable to verify that token and website are owned by the same team (no listings + unable to find contract on website)

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Token is not listed at Mobula.Finance

Additional information: link

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Unable to verify token contract address on the website

Unable to find audit link on the website

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank