PSHB [PuppyShiba] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Reentrancy in PuppyShiba._transfer(address,address,uint256) (#676-720):
External calls:
- collectFees() (#705)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
- IERC20(marketingWalletAddress).transfer(marketingFeesAddress,IERC20(marketingWalletAddress).balanceOf(address(this))) (#742)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#749-755)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#763-769)
External calls sending eth:
- collectFees() (#705)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
State variables written after the call(s):
- transferToken(from,address(this),feesToContract) (#715)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#785)
- _balances[recipient] = _balances[recipient].add(amount) (#786)
- transferToken(from,deadWalletAddress,toBurnAmount) (#716)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#785)
- _balances[recipient] = _balances[recipient].add(amount) (#786)
- transferToken(from,to,amount) (#719)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#785)
- _balances[recipient] = _balances[recipient].add(amount) (#786)
Apply the check-effects-interactions pattern.

Additional information: link

PuppyShiba.swapAndSendToFee(uint256) (#739-743) ignores return value by IERC20(marketingWalletAddress).transfer(marketingFeesAddress,IERC20(marketingWalletAddress).balanceOf(address(this))) (#742)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Contract ownership is not renounced (belongs to a wallet)

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Reentrancy in PuppyShiba.collectFees() (#721-728):
External calls:
- swapAndLiquify(liquidityTokensToSell) (#725)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#749-755)
- swapAndSendToFee(marketingTokensToSell) (#727)
- IERC20(marketingWalletAddress).transfer(marketingFeesAddress,IERC20(marketingWalletAddress).balanceOf(address(this))) (#742)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#763-769)
External calls sending eth:
- swapAndLiquify(liquidityTokensToSell) (#725)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
State variables written after the call(s):
- swapAndSendToFee(marketingTokensToSell) (#727)
- _allowances[owner][spender] = amount (#599)
Reentrancy in PuppyShiba.constructor() (#531-552):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#533-534)
State variables written after the call(s):
- _balances[_msgSender()] = _totalSupply (#550)
- _burnFee = 1 (#545)
- _isExcludedFromFee[address(this)] = true (#536)
- _isExcludedFromFee[owner()] = true (#537)
- _isExcludedFromMaxBalance[owner()] = true (#539)
- _isExcludedFromMaxBalance[uniswapV2Pair] = true (#540)
- _isExcludedFromMaxBalance[address(this)] = true (#541)
- _liquidityFee = 4 (#544)
- _liquifyThreshhold = 20 * 10 ** 9 * 10 ** _decimals (#548)
- _marketingFee = 5 (#543)
- _maxBalance = 1000 * 10 ** 9 * 10 ** _decimals (#549)
- _totalFee = _liquidityFee.add(_marketingFee).add(_burnFee) (#546)
- _totalFeeToContract = _liquidityFee.add(_marketingFee) (#547)
- uniswapV2Router = _uniswapV2Router (#535)
Reentrancy in PuppyShiba.swapAndLiquify(uint256) (#729-738):
External calls:
- swapTokensForEth(half) (#734)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#749-755)
- addLiquidity(otherHalf,newBalance) (#737)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#737)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (#737)
- _allowances[owner][spender] = amount (#599)
Reentrancy in PuppyShiba.transferFrom(address,address,uint256) (#582-586):
External calls:
- _transfer(sender,recipient,amount) (#583)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
- IERC20(marketingWalletAddress).transfer(marketingFeesAddress,IERC20(marketingWalletAddress).balanceOf(address(this))) (#742)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#749-755)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#763-769)
External calls sending eth:
- _transfer(sender,recipient,amount) (#583)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#584)
- _allowances[owner][spender] = amount (#599)
Apply the check-effects-interactions pattern.

Additional information: link

Redundant expression "this (#9)" inContext (#4-12)
Remove redundant statements if they congest code but offer no value.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#290-293)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#294-298)
name() should be declared external:
- PuppyShiba.name() (#556-558)
symbol() should be declared external:
- PuppyShiba.symbol() (#559-561)
decimals() should be declared external:
- PuppyShiba.decimals() (#562-564)
totalSupply() should be declared external:
- PuppyShiba.totalSupply() (#565-567)
transfer(address,uint256) should be declared external:
- PuppyShiba.transfer(address,uint256) (#571-574)
allowance(address,address) should be declared external:
- PuppyShiba.allowance(address,address) (#575-577)
approve(address,uint256) should be declared external:
- PuppyShiba.approve(address,uint256) (#578-581)
transferFrom(address,address,uint256) should be declared external:
- PuppyShiba.transferFrom(address,address,uint256) (#582-586)
increaseAllowance(address,uint256) should be declared external:
- PuppyShiba.increaseAllowance(address,uint256) (#587-590)
decreaseAllowance(address,uint256) should be declared external:
- PuppyShiba.decreaseAllowance(address,uint256) (#591-594)
isExcludedFromFees(address) should be declared external:
- PuppyShiba.isExcludedFromFees(address) (#637-639)
excludeFromFees(address) should be declared external:
- PuppyShiba.excludeFromFees(address) (#640-642)
includeInFees(address) should be declared external:
- PuppyShiba.includeInFees(address) (#643-645)
isExcludedFromMaxBalance(address) should be declared external:
- PuppyShiba.isExcludedFromMaxBalance(address) (#646-648)
excludeFromMaxBalance(address) should be declared external:
- PuppyShiba.excludeFromMaxBalance(address) (#649-651)
includeInMaxBalance(address) should be declared external:
- PuppyShiba.includeInMaxBalance(address) (#652-654)
totalFees() should be declared external:
- PuppyShiba.totalFees() (#655-657)
liquidityFee() should be declared external:
- PuppyShiba.liquidityFee() (#658-660)
marketingFee() should be declared external:
- PuppyShiba.marketingFee() (#661-663)
burnFee() should be declared external:
- PuppyShiba.burnFee() (#664-666)
maxFees() should be declared external:
- PuppyShiba.maxFees() (#667-669)
liquifyThreshhold() should be declared external:
- PuppyShiba.liquifyThreshhold() (#670-672)
maxBalance() should be declared external:
- PuppyShiba.maxBalance() (#673-675)
Use the external attribute for functions never called from the contract.

Additional information: link

PuppyShiba.addLiquidity(uint256,uint256) (#771-781) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
Ensure that all the return values of the function calls are used.

Additional information: link

PuppyShiba.allowance(address,address).owner (#575) shadows:
- Ownable.owner() (#283-285) (function)
PuppyShiba._approve(address,address,uint256).owner (#595) shadows:
- Ownable.owner() (#283-285) (function)
Rename the local variables that shadow another component.

Additional information: link

PuppyShiba.setLiquifyThreshhold(uint256) (#627-629) should emit an event for:
- _liquifyThreshhold = newLiquifyThreshhold (#628)
PuppyShiba.setMaxBalance(uint256) (#633-636) should emit an event for:
- _maxBalance = newMaxBalance (#635)
Emit an event for critical parameter changes.

Additional information: link

PuppyShiba.setMarketingFeesAddress(address).newMarketingFeesAddress (#602) lacks a zero-check on :
- marketingFeesAddress = newMarketingFeesAddress (#603)
PuppyShiba.setMarketingWalletAddress(address)._marketingWalletAddress (#630) lacks a zero-check on :
- marketingWalletAddress = _marketingWalletAddress (#631)
Check that the address is not zero.

Additional information: link

Reentrancy in PuppyShiba._transfer(address,address,uint256) (#676-720):
External calls:
- collectFees() (#705)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
- IERC20(marketingWalletAddress).transfer(marketingFeesAddress,IERC20(marketingWalletAddress).balanceOf(address(this))) (#742)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#749-755)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#763-769)
External calls sending eth:
- collectFees() (#705)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
Event emitted after the call(s):
- BurnToken(from,toBurnAmount) (#717)
- Transfer(sender,recipient,amount) (#787)
- transferToken(from,to,amount) (#719)
- Transfer(sender,recipient,amount) (#787)
- transferToken(from,deadWalletAddress,toBurnAmount) (#716)
- Transfer(sender,recipient,amount) (#787)
- transferToken(from,address(this),feesToContract) (#715)
Reentrancy in PuppyShiba.collectFees() (#721-728):
External calls:
- swapAndLiquify(liquidityTokensToSell) (#725)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#749-755)
- swapAndSendToFee(marketingTokensToSell) (#727)
- IERC20(marketingWalletAddress).transfer(marketingFeesAddress,IERC20(marketingWalletAddress).balanceOf(address(this))) (#742)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#763-769)
External calls sending eth:
- swapAndLiquify(liquidityTokensToSell) (#725)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#600)
- swapAndSendToFee(marketingTokensToSell) (#727)
Reentrancy in PuppyShiba.constructor() (#531-552):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#533-534)
Event emitted after the call(s):
- Transfer(address(0),_msgSender(),_totalSupply) (#551)
Reentrancy in PuppyShiba.swapAndLiquify(uint256) (#729-738):
External calls:
- swapTokensForEth(half) (#734)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#749-755)
- addLiquidity(otherHalf,newBalance) (#737)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#737)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#600)
- addLiquidity(otherHalf,newBalance) (#737)
Reentrancy in PuppyShiba.transferFrom(address,address,uint256) (#582-586):
External calls:
- _transfer(sender,recipient,amount) (#583)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
- IERC20(marketingWalletAddress).transfer(marketingFeesAddress,IERC20(marketingWalletAddress).balanceOf(address(this))) (#742)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#749-755)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#763-769)
External calls sending eth:
- _transfer(sender,recipient,amount) (#583)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#773-780)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#600)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#584)
Apply the check-effects-interactions pattern.

Additional information: link

Address.isContract(address) (#155-164) uses assembly
- INLINE ASM (#162)
Address._functionCallWithValue(address,bytes,uint256,string) (#248-269) uses assembly
- INLINE ASM (#261-264)
Do not use evm assembly.

Additional information: link

Address._functionCallWithValue(address,bytes,uint256,string) (#248-269) is never used and should be removed
Address.functionCall(address,bytes) (#208-210) is never used and should be removed
Address.functionCall(address,bytes,string) (#218-220) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256) (#233-235) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256,string) (#243-246) is never used and should be removed
Address.isContract(address) (#155-164) is never used and should be removed
Address.sendValue(address,uint256) (#182-188) is never used and should be removed
Context._msgData() (#8-11) is never used and should be removed
SafeMath.mod(uint256,uint256) (#125-127) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#128-131) is never used and should be removed
Remove unused functions.

Additional information: link

PuppyShiba._totalSupply (#502) is set pre-construction with a non-constant function or state variable:
- 100000 * 10 ** 9 * 10 ** _decimals
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Low level call in Address.sendValue(address,uint256) (#182-188):
- (success) = recipient.call{value: amount}() (#186)
Low level call in Address._functionCallWithValue(address,bytes,uint256,string) (#248-269):
- (success,returndata) = target.call{value: weiValue}(data) (#252)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#327) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#328) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#343) is not in mixedCase
Function IUniswapV2Router01.WETH() (#360) is not in mixedCase
Parameter PuppyShiba.setMarketingWalletAddress(address)._marketingWalletAddress (#630) is not in mixedCase
Constant PuppyShiba.deadWalletAddress (#504) is not in UPPER_CASE_WITH_UNDERSCORES
Constant PuppyShiba._maxFee (#513) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#364) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#365)
Prevent variables from having similar names.

Additional information: link

PuppyShiba.slitherConstructorVariables() (#490-790) uses literals with too many digits:
- _totalSupply = 100000 * 10 ** 9 * 10 ** _decimals (#502)
PuppyShiba.slitherConstructorConstantVariables() (#490-790) uses literals with too many digits:
- deadWalletAddress = 0x000000000000000000000000000000000000dEaD (#504)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

Ownable._previousOwner (#274) is never used in PuppyShiba (#490-790)
Ownable._lockTime (#275) is never used in PuppyShiba (#490-790)
Remove unused state variables.

Additional information: link

Ownable._lockTime (#275) should be constant
Ownable._previousOwner (#274) should be constant
PuppyShiba._decimals (#501) should be constant
PuppyShiba._name (#499) should be constant
PuppyShiba._symbol (#500) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Attempt to swap token was unsuccessful. For some reason it is untradeable. If token is not in presale stage and is not traded outside PancakeSwap, then it's a scam

Additional information: link

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average 30d PancakeSwap liquidity is low.

Average 30d number of PancakeSwap swaps is low.

Average PancakeSwap trading volume, liqudity, number of swaps are low. Token seems to be inactive.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Unable to find token contract audit

Token was delisted from CoinHunt

Additional information: link

Unable to find audit link on the website

Token is not listed at Mobula.Finance

Additional information: link

Unable to find code repository for the project

Young tokens have high risks of scam / price dump / death

Token is marked as scam (rug pull, honeypot, phishing, etc.)

Additional information: link

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death