POPCat Token

POPCat.addLiquidity(uint256,uint256) (#708-721) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in POPCat._transfer(address,address,uint256) (#616-653):
External calls:
- swapAndLiquify(contractTokenBalance) (#635)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#697-703)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (#635)
- recipient.transfer(amount) (#581)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#639)
- finalAmount = takeFee(sender,recipient,amount) (#645)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#736)
- _balances[recipient] = _balances[recipient].add(finalAmount) (#648)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ownership is not renounced (belongs to a wallet)

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#247) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#248)
Prevent variables from having similar names.

Additional information: link

POPCat.CharityWalletAddress (#385) should be constant
POPCat._decimals (#382) should be constant
POPCat._name (#380) should be constant
POPCat._symbol (#381) should be constant
POPCat.deadAddress (#387) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

POPCat.slitherConstructorVariables() (#375-748) uses literals with too many digits:
- deadAddress = 0x000000000000000000000000000000000000dEaD (#387)
POPCat.slitherConstructorVariables() (#375-748) uses literals with too many digits:
- _totalSupply = 100000000000 * 10 ** _decimals (#415)
POPCat.slitherConstructorVariables() (#375-748) uses literals with too many digits:
- minimumTokensBeforeSwap = 1000000000 * 5 ** _decimals (#416)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

Reentrancy in POPCat._transfer(address,address,uint256) (#616-653):
External calls:
- swapAndLiquify(contractTokenBalance) (#635)
- recipient.transfer(amount) (#581)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (#635)
- recipient.transfer(amount) (#581)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#639)
- finalAmount = takeFee(sender,recipient,amount) (#645)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#736)
- _balances[recipient] = _balances[recipient].add(finalAmount) (#648)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#737)
- finalAmount = takeFee(sender,recipient,amount) (#645)
- Transfer(sender,recipient,finalAmount) (#650)
Reentrancy in POPCat.swapAndLiquify(uint256) (#662-686):
External calls:
- transferToAddressETH(marketingWalletAddress,amountBNBMarketing) (#680)
- recipient.transfer(amount) (#581)
- transferToAddressETH(CharityWalletAddress,amountBNBCharity) (#682)
- recipient.transfer(amount) (#581)
External calls sending eth:
- transferToAddressETH(marketingWalletAddress,amountBNBMarketing) (#680)
- recipient.transfer(amount) (#581)
- transferToAddressETH(CharityWalletAddress,amountBNBCharity) (#682)
- recipient.transfer(amount) (#581)
- addLiquidity(tokensForLP,amountBNBLiquidity) (#685)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
State variables written after the call(s):
- addLiquidity(tokensForLP,amountBNBLiquidity) (#685)
- _allowances[owner][spender] = amount (#518)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#519)
- addLiquidity(tokensForLP,amountBNBLiquidity) (#685)
Reentrancy in POPCat.transferFrom(address,address,uint256) (#610-614):
External calls:
- _transfer(sender,recipient,amount) (#611)
- recipient.transfer(amount) (#581)
External calls sending eth:
- _transfer(sender,recipient,amount) (#611)
- recipient.transfer(amount) (#581)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#612)
- _allowances[owner][spender] = amount (#518)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#519)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#612)
Apply the check-effects-interactions pattern.

Additional information: link

POPCat.addLiquidity(uint256,uint256) (#708-721) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
Ensure that all the return values of the function calls are used.

Additional information: link

POPCat.allowance(address,address).owner (#491) shadows:
- Ownable.owner() (#149-151) (function)
POPCat._approve(address,address,uint256).owner (#514) shadows:
- Ownable.owner() (#149-151) (function)
Rename the local variables that shadow another component.

Additional information: link

POPCat.setBuyTaxes(uint256,uint256,uint256) (#531-538) should emit an event for:
- _totalTaxIfBuying = _buyLiquidityFee.add(_buyMarketingFee).add(_buyCharityFee) (#537)
POPCat.setSellTaxes(uint256,uint256,uint256) (#540-547) should emit an event for:
- _totalTaxIfSelling = _sellLiquidityFee.add(_sellMarketingFee).add(_sellCharityFee) (#546)
POPCat.setDistributionSettings(uint256,uint256,uint256) (#549-555) should emit an event for:
- _liquidityShare = newLiquidityShare (#550)
- _marketingShare = newMarketingShare (#551)
- _charityShare = newCharityShare (#552)
- _totalDistributionShares = _liquidityShare.add(_marketingShare).add(_charityShare) (#554)
POPCat.setNumTokensBeforeSwap(uint256) (#558-560) should emit an event for:
- minimumTokensBeforeSwap = newLimit (#559)
Emit an event for critical parameter changes.

Additional information: link

POPCat.setMarketingWalletAddress(address).newAddress (#562) lacks a zero-check on :
- marketingWalletAddress = address(newAddress) (#563)
Check that the address is not zero.

Additional information: link

Reentrancy in POPCat.changeRouterVersion(address) (#584-600):
External calls:
- newPairAddress = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#592-593)
State variables written after the call(s):
- isMarketPair[address(uniswapPair)] = true (#599)
- uniswapPair = newPairAddress (#596)
- uniswapV2Router = _uniswapV2Router (#597)
Reentrancy in POPCat.constructor(address) (#448-469):
External calls:
- uniswapPair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#452-453)
State variables written after the call(s):
- _allowances[address(this)][address(uniswapV2Router)] = _totalSupply (#456)
- _balances[ReceiveAddress] = _totalSupply (#467)
- isExcludedFromFee[owner()] = true (#459)
- isExcludedFromFee[address(this)] = true (#460)
- isExcludedFromFee[marketingWalletAddress] = true (#461)
- isExcludedFromFee[CharityWalletAddress] = true (#462)
- isExcludedFromFee[ReceiveAddress] = true (#463)
- isMarketPair[address(uniswapPair)] = true (#465)
- uniswapV2Router = _uniswapV2Router (#455)
Reentrancy in POPCat.swapAndLiquify(uint256) (#662-686):
External calls:
- swapTokensForEth(tokensForSwap) (#667)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#697-703)
- addLiquidity(tokensForLP,amountBNBLiquidity) (#685)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
External calls sending eth:
- transferToAddressETH(marketingWalletAddress,amountBNBMarketing) (#680)
- recipient.transfer(amount) (#581)
- transferToAddressETH(CharityWalletAddress,amountBNBCharity) (#682)
- recipient.transfer(amount) (#581)
- addLiquidity(tokensForLP,amountBNBLiquidity) (#685)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
State variables written after the call(s):
- addLiquidity(tokensForLP,amountBNBLiquidity) (#685)
- _allowances[owner][spender] = amount (#518)
Reentrancy in POPCat.transferFrom(address,address,uint256) (#610-614):
External calls:
- _transfer(sender,recipient,amount) (#611)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#697-703)
External calls sending eth:
- _transfer(sender,recipient,amount) (#611)
- recipient.transfer(amount) (#581)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#612)
- _allowances[owner][spender] = amount (#518)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in POPCat._transfer(address,address,uint256) (#616-653):
External calls:
- swapAndLiquify(contractTokenBalance) (#635)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#697-703)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (#635)
- recipient.transfer(amount) (#581)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#737)
- finalAmount = takeFee(sender,recipient,amount) (#645)
- Transfer(sender,recipient,finalAmount) (#650)
Reentrancy in POPCat.constructor(address) (#448-469):
External calls:
- uniswapPair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#452-453)
Event emitted after the call(s):
- Transfer(address(0),ReceiveAddress,_totalSupply) (#468)
Reentrancy in POPCat.swapAndLiquify(uint256) (#662-686):
External calls:
- swapTokensForEth(tokensForSwap) (#667)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#697-703)
- addLiquidity(tokensForLP,amountBNBLiquidity) (#685)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
External calls sending eth:
- transferToAddressETH(marketingWalletAddress,amountBNBMarketing) (#680)
- recipient.transfer(amount) (#581)
- transferToAddressETH(CharityWalletAddress,amountBNBCharity) (#682)
- recipient.transfer(amount) (#581)
- addLiquidity(tokensForLP,amountBNBLiquidity) (#685)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#519)
- addLiquidity(tokensForLP,amountBNBLiquidity) (#685)
Reentrancy in POPCat.swapTokensForEth(uint256) (#688-706):
External calls:
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#697-703)
Event emitted after the call(s):
- SwapTokensForETH(tokenAmount,path) (#705)
Reentrancy in POPCat.transferFrom(address,address,uint256) (#610-614):
External calls:
- _transfer(sender,recipient,amount) (#611)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#697-703)
External calls sending eth:
- _transfer(sender,recipient,amount) (#611)
- recipient.transfer(amount) (#581)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,marketingWalletAddress,block.timestamp) (#713-720)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#519)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#612)
Apply the check-effects-interactions pattern.

Additional information: link

Address.isContract(address) (#83-92) uses assembly
- INLINE ASM (#90)
Address._functionCallWithValue(address,bytes,uint256,string) (#119-136) uses assembly
- INLINE ASM (#128-131)
Do not use evm assembly.

Additional information: link

Address._functionCallWithValue(address,bytes,uint256,string) (#119-136) is never used and should be removed
Address.functionCall(address,bytes) (#102-104) is never used and should be removed
Address.functionCall(address,bytes,string) (#106-108) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256) (#110-112) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256,string) (#114-117) is never used and should be removed
Address.isContract(address) (#83-92) is never used and should be removed
Address.sendValue(address,uint256) (#94-100) is never used and should be removed
Context._msgData() (#11-14) is never used and should be removed
SafeMath.mod(uint256,uint256) (#71-73) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#75-78) is never used and should be removed
Remove unused functions.

Additional information: link

POPCat._totalSupply (#415) is set pre-construction with a non-constant function or state variable:
- 100000000000 * 10 ** _decimals
POPCat.minimumTokensBeforeSwap (#416) is set pre-construction with a non-constant function or state variable:
- 1000000000 * 5 ** _decimals
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

solc-0.8.14 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Address.sendValue(address,uint256) (#94-100):
- (success) = recipient.call{value: amount}() (#98)
Low level call in Address._functionCallWithValue(address,bytes,uint256,string) (#119-136):
- (success,returndata) = target.call{value: weiValue}(data) (#122)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable Ownable._owner (#140) is not in mixedCase
Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#206) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#207) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#223) is not in mixedCase
Function IUniswapV2Router01.WETH() (#242) is not in mixedCase
Parameter POPCat.setSwapAndLiquifyEnabled(bool)._enabled (#567) is not in mixedCase
Variable POPCat.CharityWalletAddress (#385) is not in mixedCase
Variable POPCat._balances (#389) is not in mixedCase
Variable POPCat._buyLiquidityFee (#396) is not in mixedCase
Variable POPCat._buyMarketingFee (#397) is not in mixedCase
Variable POPCat._buyCharityFee (#398) is not in mixedCase
Variable POPCat._sellLiquidityFee (#401) is not in mixedCase
Variable POPCat._sellMarketingFee (#402) is not in mixedCase
Variable POPCat._sellCharityFee (#403) is not in mixedCase
Variable POPCat._liquidityShare (#406) is not in mixedCase
Variable POPCat._marketingShare (#407) is not in mixedCase
Variable POPCat._charityShare (#408) is not in mixedCase
Variable POPCat._totalTaxIfBuying (#410) is not in mixedCase
Variable POPCat._totalTaxIfSelling (#411) is not in mixedCase
Variable POPCat._totalDistributionShares (#412) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#12)" inContext (#5-15)
Remove redundant statements if they congest code but offer no value.

Additional information: link

waiveOwnership() should be declared external:
- Ownable.waiveOwnership() (#158-161)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#163-167)
getTime() should be declared external:
- Ownable.getTime() (#169-171)
name() should be declared external:
- POPCat.name() (#471-473)
symbol() should be declared external:
- POPCat.symbol() (#475-477)
decimals() should be declared external:
- POPCat.decimals() (#479-481)
totalSupply() should be declared external:
- POPCat.totalSupply() (#483-485)
allowance(address,address) should be declared external:
- POPCat.allowance(address,address) (#491-493)
increaseAllowance(address,uint256) should be declared external:
- POPCat.increaseAllowance(address,uint256) (#495-498)
decreaseAllowance(address,uint256) should be declared external:
- POPCat.decreaseAllowance(address,uint256) (#500-503)
minimumTokensBeforeSwapAmount() should be declared external:
- POPCat.minimumTokensBeforeSwapAmount() (#505-507)
approve(address,uint256) should be declared external:
- POPCat.approve(address,uint256) (#509-512)
setMarketPairStatus(address,bool) should be declared external:
- POPCat.setMarketPairStatus(address,bool) (#522-524)
setIsExcludedFromFee(address,bool) should be declared external:
- POPCat.setIsExcludedFromFee(address,bool) (#527-529)
setSwapAndLiquifyEnabled(bool) should be declared external:
- POPCat.setSwapAndLiquifyEnabled(bool) (#567-570)
setSwapAndLiquifyByLimitOnly(bool) should be declared external:
- POPCat.setSwapAndLiquifyByLimitOnly(bool) (#572-574)
getCirculatingSupply() should be declared external:
- POPCat.getCirculatingSupply() (#576-578)
changeRouterVersion(address) should be declared external:
- POPCat.changeRouterVersion(address) (#584-600)
transfer(address,uint256) should be declared external:
- POPCat.transfer(address,uint256) (#605-608)
transferFrom(address,address,uint256) should be declared external:
- POPCat.transferFrom(address,address,uint256) (#610-614)
Use the external attribute for functions never called from the contract.

Additional information: link

Token seems to be untradeable: there is no PancakeSwap trading pair and no trading volumes. Ignore for presale.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to find token contract audit

Unable to find KYC or doxxing proof

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Token is not listed at Mobula.Finance

Additional information: link

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank