MPOOL [Metapool] Token

Metapool.addLiquidity(uint256,uint256) (#674-680) sends eth to arbitrary user
Dangerous calls:
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#679)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in Metapool._transfer(address,address,uint256) (#531-600):
External calls:
- handle_fees(feeswap,currentTaxes) (#585)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#679)
- (success) = recipient.call{value: amount}() (#362)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#670)
- address(marketingWallet).sendValue(marketingAmt) (#645)
- address(devWallet).sendValue(devAmt) (#650)
- address(metapoolWallet).sendValue(poolAmt) (#655)
External calls sending eth:
- handle_fees(feeswap,currentTaxes) (#585)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#679)
- (success) = recipient.call{value: amount}() (#362)
State variables written after the call(s):
- super._transfer(sender,recipient,amount - fee) (#589)
- _balances[sender] = senderBalance - amount (#271)
- _balances[recipient] += amount (#272)
- super._transfer(sender,address(this),feeAmount) (#595)
- _balances[sender] = senderBalance - amount (#271)
- _balances[recipient] += amount (#272)
Apply the check-effects-interactions pattern.

Additional information: link

Metapool.rescueBEP20(address,uint256) (#757-759) ignores return value by IERC20(tokenAdd).transfer(devWallet,amount) (#758)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Too many vulnerabilities (Unchecked transfer, Reentrancy vulnerability, etc.). High risk of a scam. DYOR & manual audit are advised.

Metapool._transfer(address,address,uint256) (#531-600) uses a dangerous strict equality:
- recipient == pair && genesis_block == 0 (#535)
Don't use strict equality to determine if an account has enough Ether or tokens.

Additional information: link

Metapool._transfer(address,address,uint256).fee (#561) is written in both
fee = 0 (#571)
fee = amount * feeswap / 100 (#581)
Fix or remove the writes.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Variable Metapool.genesis_block (#427) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#41)" inContext (#35-44)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Metapool.marketingWallet (#429) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

getPair() should be declared external:
- Metapool.getPair() (#761-763)
Use the external attribute for functions never called from the contract.

Additional information: link

Metapool.handle_fees(uint256,Metapool.Taxes) (#602-659) performs a multiplication on the result of a division:
-devTokens = swapTaxes.dev * tokenBalance / feeswap (#616)
-devAmt = devTokens * afterBalance / toSwap (#648)
Consider ordering multiplication before division.

Additional information: link

Metapool._transfer(address,address,uint256).currentTaxes (#563) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

Metapool.addLiquidity(uint256,uint256) (#674-680) ignores return value by router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#679)
Ensure that all the return values of the function calls are used.

Additional information: link

Metapool.updateMaxWalletlimit(uint256) (#749-751) should emit an event for:
- maxWalletLimit = amount * 10 ** decimals() (#750)
Emit an event for critical parameter changes.

Additional information: link

Metapool.updateMetapoolWallet(address).newWallet (#710) lacks a zero-check on :
- metapoolWallet = newWallet (#711)
Check that the address is not zero.

Additional information: link

Modifier Metapool.mutexLock() (#459-465) does not always execute _; or revert
All the paths in a modifier must execute _ or revert.

Additional information: link

Reentrancy in Metapool.transferFrom(address,address,uint256) (#503-511):
External calls:
- _transfer(sender,recipient,amount) (#504)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#679)
- (success) = recipient.call{value: amount}() (#362)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#670)
- address(marketingWallet).sendValue(marketingAmt) (#645)
- address(devWallet).sendValue(devAmt) (#650)
- address(metapoolWallet).sendValue(poolAmt) (#655)
External calls sending eth:
- _transfer(sender,recipient,amount) (#504)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#679)
- (success) = recipient.call{value: amount}() (#362)
State variables written after the call(s):
- _approve(sender,_msgSender(),currentAllowance - amount) (#508)
- _allowances[owner][spender] = amount (#337)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in Metapool.transferFrom(address,address,uint256) (#503-511):
External calls:
- _transfer(sender,recipient,amount) (#504)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#679)
- (success) = recipient.call{value: amount}() (#362)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#670)
- address(marketingWallet).sendValue(marketingAmt) (#645)
- address(devWallet).sendValue(devAmt) (#650)
- address(metapoolWallet).sendValue(poolAmt) (#655)
External calls sending eth:
- _transfer(sender,recipient,amount) (#504)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#679)
- (success) = recipient.call{value: amount}() (#362)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#338)
- _approve(sender,_msgSender(),currentAllowance - amount) (#508)
Apply the check-effects-interactions pattern.

Additional information: link

Metapool._transfer(address,address,uint256) (#531-600) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(timePassed >= coolDownTime,Cooldown enabled.) (#555)
Avoid relying on block.timestamp.

Additional information: link

ERC20._burn(address,uint256) (#307-318) is never used and should be removed
Remove unused functions.

Additional information: link

solc-0.8.7 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Address.sendValue(address,uint256) (#359-364):
- (success) = recipient.call{value: amount}() (#362)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Token was delisted (assigned to inactive / untracked listing) from CoinMarketCap

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to find token contract audit

Unable to verify token contract address on the website

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find Telegram link on the website

Unable to find Twitter link on the website

Unable to find token on CoinHunt

Additional information: link

Young tokens have high risks of price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinMarketCap listing / rank

Token has relatively low CoinGecko rank