HNCHY [HappyNewChineseYear] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Reentrancy in HappyNewChineseYear._transfer(address,address,uint256) (#814-851):
External calls:
- swapAndLiquify() (#835)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- address(_marketingWallet).sendValue(ethAmount - ethFromLiquidity) (#910)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#885-891)
- swapAndSendToFee(sellTokens) (#837)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#885-891)
External calls sending eth:
- swapAndLiquify() (#835)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- swapAndSendToFee(sellTokens) (#837)
- address(_marketingWallet).transfer(ethToSend) (#858)
State variables written after the call(s):
- _tOwned[from] -= amount (#841)
- transferAmount = _getValues(amount,from) (#846)
- _tOwned[address(this)] += marketingFee + liquidityFee (#796)
- _tOwned[to] += transferAmount (#849)
- swapping = false (#838)
Apply the check-effects-interactions pattern.

Additional information: link

Not a direct threat, but may indicate unreliable intentions of developer. Widespread names (e.g. Elon, King, Moon, Doge) are common among meme-tokens and scams. The allow to gain free hype and attract unexperienced investors.

HappyNewChineseYear.allowance(address,address).owner (#736) shadows:
- Ownable.owner() (#413-415) (function)
HappyNewChineseYear._approve(address,address,uint256).owner (#806) shadows:
- Ownable.owner() (#413-415) (function)
Rename the local variables that shadow another component.

Additional information: link

HappyNewChineseYear.setMarketingFeePercent(uint256) (#777-779) should emit an event for:
- _marketingFee = marketingFee (#778)
HappyNewChineseYear.setLiquidityFeePercent(uint256) (#781-783) should emit an event for:
- _liquidityFee = liquidityFee (#782)
HappyNewChineseYear.setMaxBuySellPercent(uint256) (#785-787) should emit an event for:
- _maxTxAmount = _tTotal * maxTxPercent / 10 ** 2 (#786)
Emit an event for critical parameter changes.

Additional information: link

HappyNewChineseYear.setMarketingWallet(address).marketingWallet (#773) lacks a zero-check on :
- _marketingWallet = marketingWallet (#774)
Check that the address is not zero.

Additional information: link

Reentrancy in HappyNewChineseYear._transfer(address,address,uint256) (#814-851):
External calls:
- swapAndLiquify() (#835)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- address(_marketingWallet).sendValue(ethAmount - ethFromLiquidity) (#910)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#885-891)
- swapAndSendToFee(sellTokens) (#837)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#885-891)
External calls sending eth:
- swapAndLiquify() (#835)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- swapAndSendToFee(sellTokens) (#837)
- address(_marketingWallet).transfer(ethToSend) (#858)
State variables written after the call(s):
- swapAndSendToFee(sellTokens) (#837)
- _allowances[owner][spender] = amount (#810)
Reentrancy in HappyNewChineseYear.constructor() (#693-709):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#698)
State variables written after the call(s):
- _isExcludedFromFee[owner()] = true (#704)
- _isExcludedFromFee[address(this)] = true (#705)
- _isExcludedFromFee[_marketingWallet] = true (#706)
- uniswapV2Pair = _uniswapV2Pair (#701)
- uniswapV2Router = _uniswapV2Router (#700)
Reentrancy in HappyNewChineseYear.swapAndLiquify() (#861-873):
External calls:
- newBalance = swapTokensForEth(half) (#866)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#885-891)
- addLiquidity(otherHalf,newBalance) (#870)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- address(_marketingWallet).sendValue(ethAmount - ethFromLiquidity) (#910)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#870)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (#870)
- _allowances[owner][spender] = amount (#810)
Reentrancy in HappyNewChineseYear.transferFrom(address,address,uint256) (#745-749):
External calls:
- _transfer(sender,recipient,amount) (#746)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- address(_marketingWallet).sendValue(ethAmount - ethFromLiquidity) (#910)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#885-891)
External calls sending eth:
- _transfer(sender,recipient,amount) (#746)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- address(_marketingWallet).transfer(ethToSend) (#858)
- (success) = recipient.call{value: amount}() (#298)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#747)
- _allowances[owner][spender] = amount (#810)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in HappyNewChineseYear._transfer(address,address,uint256) (#814-851):
External calls:
- swapAndLiquify() (#835)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- address(_marketingWallet).sendValue(ethAmount - ethFromLiquidity) (#910)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#885-891)
- swapAndSendToFee(sellTokens) (#837)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#885-891)
External calls sending eth:
- swapAndLiquify() (#835)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- swapAndSendToFee(sellTokens) (#837)
- address(_marketingWallet).transfer(ethToSend) (#858)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#811)
- swapAndSendToFee(sellTokens) (#837)
- Transfer(from,address(this),marketingFee + liquidityFee) (#797)
- transferAmount = _getValues(amount,from) (#846)
- Transfer(from,to,transferAmount) (#850)
Reentrancy in HappyNewChineseYear.constructor() (#693-709):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#698)
Event emitted after the call(s):
- Transfer(address(0),_msgSender(),_tTotal) (#708)
Reentrancy in HappyNewChineseYear.swapAndLiquify() (#861-873):
External calls:
- newBalance = swapTokensForEth(half) (#866)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#885-891)
- addLiquidity(otherHalf,newBalance) (#870)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- address(_marketingWallet).sendValue(ethAmount - ethFromLiquidity) (#910)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#870)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#811)
- addLiquidity(otherHalf,newBalance) (#870)
- SwapAndLiquify(half,newBalance,otherHalf) (#871)
Reentrancy in HappyNewChineseYear.transferFrom(address,address,uint256) (#745-749):
External calls:
- _transfer(sender,recipient,amount) (#746)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- address(_marketingWallet).sendValue(ethAmount - ethFromLiquidity) (#910)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#885-891)
External calls sending eth:
- _transfer(sender,recipient,amount) (#746)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- address(_marketingWallet).transfer(ethToSend) (#858)
- (success) = recipient.call{value: amount}() (#298)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#811)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#747)
Apply the check-effects-interactions pattern.

Additional information: link

HappyNewChineseYear._transfer(address,address,uint256) (#814-851) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(_lastBuy[to] + _buyCooldown < block.timestamp,Must wait til after coooldown to buy) (#828)
HappyNewChineseYear.addLiquidity(uint256,uint256) (#895-911) uses timestamp for comparisons
Dangerous comparisons:
- ethAmount - ethFromLiquidity > 0 (#909)
Avoid relying on block.timestamp.

Additional information: link

Address.isContract(address) (#267-276) uses assembly
- INLINE ASM (#274)
Address._functionCallWithValue(address,bytes,uint256,string) (#360-381) uses assembly
- INLINE ASM (#373-376)
Do not use evm assembly.

Additional information: link

Address._functionCallWithValue(address,bytes,uint256,string) (#360-381) is never used and should be removed
Address.functionCall(address,bytes) (#320-322) is never used and should be removed
Address.functionCall(address,bytes,string) (#330-332) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256) (#345-347) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256,string) (#355-358) is never used and should be removed
Address.isContract(address) (#267-276) is never used and should be removed
Context._msgData() (#239-242) is never used and should be removed
SafeMath.add(uint256,uint256) (#102-107) is never used and should be removed
SafeMath.div(uint256,uint256) (#176-178) is never used and should be removed
SafeMath.div(uint256,uint256,string) (#192-198) is never used and should be removed
SafeMath.mod(uint256,uint256) (#212-214) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#228-231) is never used and should be removed
SafeMath.mul(uint256,uint256) (#150-162) is never used and should be removed
SafeMath.sub(uint256,uint256) (#119-121) is never used and should be removed
SafeMath.sub(uint256,uint256,string) (#133-138) is never used and should be removed
Remove unused functions.

Additional information: link

Low level call in Address.sendValue(address,uint256) (#294-300):
- (success) = recipient.call{value: amount}() (#298)
Low level call in Address._functionCallWithValue(address,bytes,uint256,string) (#360-381):
- (success,returndata) = target.call{value: weiValue}(data) (#364)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#484) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#485) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#502) is not in mixedCase
Function IUniswapV2Router01.WETH() (#524) is not in mixedCase
Variable HappyNewChineseYear._isBlacklisted (#672) is not in mixedCase
Variable HappyNewChineseYear._maxTxAmount (#675) is not in mixedCase
Constant HappyNewChineseYear._name (#678) is not in UPPER_CASE_WITH_UNDERSCORES
Constant HappyNewChineseYear._symbol (#679) is not in UPPER_CASE_WITH_UNDERSCORES
Constant HappyNewChineseYear._decimals (#680) is not in UPPER_CASE_WITH_UNDERSCORES
Variable HappyNewChineseYear._marketingFee (#682) is not in mixedCase
Variable HappyNewChineseYear._liquidityFee (#683) is not in mixedCase
Variable HappyNewChineseYear._marketingWallet (#684) is not in mixedCase
Variable HappyNewChineseYear._buyCooldown (#686) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#240)" inContext (#234-243)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Reentrancy in HappyNewChineseYear._transfer(address,address,uint256) (#814-851):
External calls:
- swapAndSendToFee(sellTokens) (#837)
- address(_marketingWallet).transfer(ethToSend) (#858)
External calls sending eth:
- swapAndLiquify() (#835)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- (success) = recipient.call{value: amount}() (#298)
- swapAndSendToFee(sellTokens) (#837)
- address(_marketingWallet).transfer(ethToSend) (#858)
State variables written after the call(s):
- _tOwned[from] -= amount (#841)
- transferAmount = _getValues(amount,from) (#846)
- _tOwned[address(this)] += marketingFee + liquidityFee (#796)
- _tOwned[to] += transferAmount (#849)
- swapping = false (#838)
Event emitted after the call(s):
- Transfer(from,address(this),marketingFee + liquidityFee) (#797)
- transferAmount = _getValues(amount,from) (#846)
- Transfer(from,to,transferAmount) (#850)
Reentrancy in HappyNewChineseYear.transferFrom(address,address,uint256) (#745-749):
External calls:
- _transfer(sender,recipient,amount) (#746)
- address(_marketingWallet).transfer(ethToSend) (#858)
External calls sending eth:
- _transfer(sender,recipient,amount) (#746)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#900-907)
- address(_marketingWallet).transfer(ethToSend) (#858)
- (success) = recipient.call{value: amount}() (#298)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#747)
- _allowances[owner][spender] = amount (#810)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#811)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#747)
Apply the check-effects-interactions pattern.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#529) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#530)
Prevent variables from having similar names.

Additional information: link

Address.sendValue(address,uint256) (#294-300) uses literals with too many digits:
- recipient = address(0x000000000000000000000000000000000000dEaD) (#296)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

HappyNewChineseYear._buyCooldown (#686) should be constant
HappyNewChineseYear._tTotal (#674) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#432-435)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#441-445)
name() should be declared external:
- HappyNewChineseYear.name() (#711-713)
symbol() should be declared external:
- HappyNewChineseYear.symbol() (#715-717)
decimals() should be declared external:
- HappyNewChineseYear.decimals() (#719-721)
totalSupply() should be declared external:
- HappyNewChineseYear.totalSupply() (#723-725)
transfer(address,uint256) should be declared external:
- HappyNewChineseYear.transfer(address,uint256) (#731-734)
allowance(address,address) should be declared external:
- HappyNewChineseYear.allowance(address,address) (#736-738)
approve(address,uint256) should be declared external:
- HappyNewChineseYear.approve(address,uint256) (#740-743)
transferFrom(address,address,uint256) should be declared external:
- HappyNewChineseYear.transferFrom(address,address,uint256) (#745-749)
increaseAllowance(address,uint256) should be declared external:
- HappyNewChineseYear.increaseAllowance(address,uint256) (#751-754)
decreaseAllowance(address,uint256) should be declared external:
- HappyNewChineseYear.decreaseAllowance(address,uint256) (#756-759)
excludeFromFee(address) should be declared external:
- HappyNewChineseYear.excludeFromFee(address) (#761-763)
includeInFee(address) should be declared external:
- HappyNewChineseYear.includeInFee(address) (#765-767)
isExcludedFromFee(address) should be declared external:
- HappyNewChineseYear.isExcludedFromFee(address) (#802-804)
Use the external attribute for functions never called from the contract.

Additional information: link

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Contract has 11% buy tax and 13% sell tax.
Taxes are high (over 10%) but contract ownership is renounced.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find website, listings and other project-related information

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank