FOOFIGHT [Fruit Fighters] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

FOOFIGHT.swapBack() (#578-605) sends eth to arbitrary user
Dangerous calls:
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#598)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in FOOFIGHT._transferFrom(address,address,uint256) (#515-539):
External calls:
- swapBack() (#523)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp) (#586-604)
- distributor.deposit{value: amountBNBReflection}() (#597)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#598)
- buyBackTokens() (#524)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#623-630)
External calls sending eth:
- swapBack() (#523)
- distributor.deposit{value: amountBNBReflection}() (#597)
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#598)
- buyBackTokens() (#524)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#623-630)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#527)
- amountReceived = takeFee(sender,recipient,amount) (#529)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#565)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#530)
- buyBackTokens() (#524)
- inSwap = true (#459)
- inSwap = false (#459)
Apply the check-effects-interactions pattern.

Additional information: link

SafeToken.withdraw(address,uint256) (#382-385) ignores return value by IBEP20(_token).transfer(safeManager,_amount) (#384)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Reentrancy in DividendDistributor.setShare(address,uint256) (#242-256):
External calls:
- distributeDividend(shareholder) (#244)
- BUSD.transfer(shareholder,amount) (#332)
State variables written after the call(s):
- shares[shareholder].amount = amount (#254)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#255)
Apply the check-effects-interactions pattern.

Additional information: link

FOOFIGHT.swapBack() (#578-605) ignores return value by address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#598)
Ensure that the return value of a low-level call is checked or logged.

Additional information: link

FOOFIGHT.swapBack().e (#600) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

FOOFIGHT.setSwapBackSettings(bool,uint256) (#671-674) should emit an event for:
- swapThreshold = _amount (#673)
Emit an event for critical parameter changes.

Additional information: link

FOOFIGHT.setMarketingWallet(address)._marketing (#667) lacks a zero-check on :
- marketing = _marketing (#668)
Check that the address is not zero.

Additional information: link

Variable 'FOOFIGHT.swapBack().e (#600)' in FOOFIGHT.swapBack() (#578-605) potentially used before declaration: SwapBackFailed(string(abi.encodePacked(SwapBack failed with error ,e))) (#601)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in DividendDistributor.setShare(address,uint256) (#242-256):
External calls:
- distributeDividend(shareholder) (#244)
- BUSD.transfer(shareholder,amount) (#332)
State variables written after the call(s):
- addShareholder(shareholder) (#248)
- shareholderIndexes[shareholder] = shareholders.length (#359)
- removeShareholder(shareholder) (#250)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#365)
- addShareholder(shareholder) (#248)
- shareholders.push(shareholder) (#360)
- removeShareholder(shareholder) (#250)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#364)
- shareholders.pop() (#366)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#253)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in FOOFIGHT.swapBnbForTokens(uint256) (#616-633):
External calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,DEAD,block.timestamp.add(300)) (#623-630)
Event emitted after the call(s):
- SwapBNBForTokens(amount,path) (#632)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.shouldDistribute(address) (#321-324) uses timestamp for comparisons
Dangerous comparisons:
- shareholderClaims[shareholder] + minPeriod < block.timestamp && getUnpaidEarnings(shareholder) > minDistribution (#322-323)
Avoid relying on block.timestamp.

Additional information: link

DividendDistributor.process(uint256) (#295-319) has costly operations inside a loop:
- currentIndex ++ (#316)
Use a local variable to hold the loop computation result.

Additional information: link

Context._msgData() (#52-55) is never used and should be removed
Remove unused functions.

Additional information: link

FOOFIGHT.swapThreshold (#456) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 5000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

solc-0.8.6 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in FOOFIGHT.swapBack() (#578-605):
- address(marketing).call{gas: 30000,value: amountBNBMarketing}() (#598)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable FOOFIGHT._maxTxAmount (#437) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#53)" inContext (#47-56)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#138) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#139)
Prevent variables from having similar names.

Additional information: link

FOOFIGHT.slitherConstructorVariables() (#417-701) uses literals with too many digits:
- distributorGas = 500000 (#452)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

FOOFIGHT.buyBackUpperLimit (#438) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

getCirculatingSupply() should be declared external:
- FOOFIGHT.getCirculatingSupply() (#685-687)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to crawl data from the website

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Token was delisted (assigned to inactive / untracked listing) from CoinMarketCap

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to find token contract audit

Unable to verify token contract address on the website

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find Telegram link on the website

Unable to find Twitter link on the website

Unable to find token on CoinHunt

Additional information: link

Young tokens have high risks of scam / price dump / death

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death

Token has relatively low CoinGecko rank