BDOG [BIG DOG] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

BIGDOG.addLiquidity(uint256,uint256) (#492-505) sends eth to arbitrary user
Dangerous calls:
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in BIGDOG._transfer(address,address,uint256) (#414-431):
External calls:
- swapAndLiquify(swapTokensAtAmount) (#427)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
- (success) = recipient.call{value: amount}() (#33)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#516-522)
- address(marketingWallet).sendValue(marketingAmt) (#487)
External calls sending eth:
- swapAndLiquify(swapTokensAtAmount) (#427)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
- (success) = recipient.call{value: amount}() (#33)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#430)
- _rOwned[address(this)] += rMarketing (#340)
- _rOwned[address(this)] += rLiquidity (#330)
- _rOwned[deadAddress] += rBurn (#350)
- _rOwned[sender] = _rOwned[sender] - s.rAmount (#446)
- _rOwned[recipient] = _rOwned[recipient] + s.rTransferAmount (#447)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#430)
- _rTotal -= rRfi (#319)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#430)
- _tOwned[deadAddress] += tBurn (#348)
- _tOwned[sender] = _tOwned[sender] - tAmount (#440)
- _tOwned[address(this)] += tMarketing (#338)
- _tOwned[address(this)] += tLiquidity (#328)
- _tOwned[recipient] = _tOwned[recipient] + s.tTransferAmount (#443)
Apply the check-effects-interactions pattern.

Additional information: link

BIGDOG.rescueAnyBEP20Tokens(address,address,uint256) (#560-562) ignores return value by IERC20(_tokenAddr).transfer(_to,_amount) (#561)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

BIGDOG.slitherConstructorConstantVariables() (#107-567) uses literals with too many digits:
- deadAddress = 0x000000000000000000000000000000000000dEaD (#135)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

BIGDOG._tTotal (#127) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

BIGDOG.swapAndLiquify(uint256) (#466-490) performs a multiplication on the result of a division:
-unitBalance = deltaBalance / (denominator - taxes.liquidity) (#477)
-bnbToAddLiquidityWith = unitBalance * taxes.liquidity (#478)
BIGDOG.swapAndLiquify(uint256) (#466-490) performs a multiplication on the result of a division:
-unitBalance = deltaBalance / (denominator - taxes.liquidity) (#477)
-marketingAmt = unitBalance * 2 * taxes.marketing (#485)
Consider ordering multiplication before division.

Additional information: link

BIGDOG.addLiquidity(uint256,uint256) (#492-505) ignores return value by router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
Ensure that all the return values of the function calls are used.

Additional information: link

BIGDOG.allowance(address,address).owner (#225) shadows:
- Ownable.owner() (#58-60) (function)
BIGDOG._approve(address,address,uint256).owner (#406) shadows:
- Ownable.owner() (#58-60) (function)
Rename the local variables that shadow another component.

Additional information: link

BIGDOG.updateMaxTxAmount(uint256) (#530-532) should emit an event for:
- maxTxAmount = amount * 10 ** _decimals (#531)
BIGDOG.updateMaxWalletBalance(uint256) (#534-536) should emit an event for:
- maxWalletAmount = amount * 10 ** _decimals (#535)
BIGDOG.updateSwapTokensAtAmount(uint256) (#538-540) should emit an event for:
- swapTokensAtAmount = amount * 10 ** _decimals (#539)
Emit an event for critical parameter changes.

Additional information: link

BIGDOG.updatemarketingWallet(address).newWallet (#525) lacks a zero-check on :
- marketingWallet = newWallet (#526)
BIGDOG.updateRouterAndPair(address,address).newPair (#546) lacks a zero-check on :
- pair = newPair (#549)
Check that the address is not zero.

Additional information: link

Reentrancy in BIGDOG._transfer(address,address,uint256) (#414-431):
External calls:
- swapAndLiquify(swapTokensAtAmount) (#427)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
- (success) = recipient.call{value: amount}() (#33)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#516-522)
- address(marketingWallet).sendValue(marketingAmt) (#487)
External calls sending eth:
- swapAndLiquify(swapTokensAtAmount) (#427)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
- (success) = recipient.call{value: amount}() (#33)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#430)
- totFeesPaid.marketing += tMarketing (#334)
- totFeesPaid.burn += tBurn (#344)
- totFeesPaid.liquidity += tLiquidity (#324)
- totFeesPaid.rfi += tRfi (#320)
Reentrancy in BIGDOG.constructor() (#180-199):
External calls:
- _pair = IFactory(_router.factory()).createPair(address(this),_router.WETH()) (#183-184)
State variables written after the call(s):
- excludeFromReward(pair) (#189)
- _excluded.push(account) (#284)
- excludeFromReward(deadAddress) (#190)
- _excluded.push(account) (#284)
- excludeFromReward(pair) (#189)
- _isExcluded[account] = true (#283)
- excludeFromReward(deadAddress) (#190)
- _isExcluded[account] = true (#283)
- _isExcludedFromFee[owner()] = true (#193)
- _isExcludedFromFee[address(this)] = true (#194)
- _isExcludedFromFee[marketingWallet] = true (#195)
- _isExcludedFromFee[deadAddress] = true (#196)
- _rOwned[owner()] = _rTotal (#192)
- excludeFromReward(pair) (#189)
- _tOwned[account] = tokenFromReflection(_rOwned[account]) (#281)
- excludeFromReward(deadAddress) (#190)
- _tOwned[account] = tokenFromReflection(_rOwned[account]) (#281)
- pair = _pair (#187)
- router = _router (#186)
Reentrancy in BIGDOG.swapAndLiquify(uint256) (#466-490):
External calls:
- swapTokensForBNB(toSwap) (#474)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#516-522)
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#482)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
External calls sending eth:
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#482)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
State variables written after the call(s):
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#482)
- _allowances[owner][spender] = amount (#409)
Reentrancy in BIGDOG.transferFrom(address,address,uint256) (#234-242):
External calls:
- _transfer(sender,recipient,amount) (#235)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
- (success) = recipient.call{value: amount}() (#33)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#516-522)
- address(marketingWallet).sendValue(marketingAmt) (#487)
External calls sending eth:
- _transfer(sender,recipient,amount) (#235)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
- (success) = recipient.call{value: amount}() (#33)
State variables written after the call(s):
- _approve(sender,_msgSender(),currentAllowance - amount) (#239)
- _allowances[owner][spender] = amount (#409)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in BIGDOG._transfer(address,address,uint256) (#414-431):
External calls:
- swapAndLiquify(swapTokensAtAmount) (#427)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
- (success) = recipient.call{value: amount}() (#33)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#516-522)
- address(marketingWallet).sendValue(marketingAmt) (#487)
External calls sending eth:
- swapAndLiquify(swapTokensAtAmount) (#427)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
- (success) = recipient.call{value: amount}() (#33)
Event emitted after the call(s):
- Transfer(sender,deadAddress,s.tBurn) (#458)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#430)
- Transfer(sender,recipient,s.tTransferAmount) (#461)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#430)
- Transfer(sender,address(this),s.tLiquidity + s.tMarketing) (#462)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#430)
Reentrancy in BIGDOG.constructor() (#180-199):
External calls:
- _pair = IFactory(_router.factory()).createPair(address(this),_router.WETH()) (#183-184)
Event emitted after the call(s):
- Transfer(address(0),owner(),_tTotal) (#198)
Reentrancy in BIGDOG.swapAndLiquify(uint256) (#466-490):
External calls:
- swapTokensForBNB(toSwap) (#474)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#516-522)
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#482)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
External calls sending eth:
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#482)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#410)
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#482)
Reentrancy in BIGDOG.transferFrom(address,address,uint256) (#234-242):
External calls:
- _transfer(sender,recipient,amount) (#235)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
- (success) = recipient.call{value: amount}() (#33)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#516-522)
- address(marketingWallet).sendValue(marketingAmt) (#487)
External calls sending eth:
- _transfer(sender,recipient,amount) (#235)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#497-504)
- (success) = recipient.call{value: amount}() (#33)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#410)
- _approve(sender,_msgSender(),currentAllowance - amount) (#239)
Apply the check-effects-interactions pattern.

Additional information: link

BIGDOG.includeInReward(address) (#287-298) has costly operations inside a loop:
- _excluded.pop() (#294)
Use a local variable to hold the loop computation result.

Additional information: link

Context._msgData() (#43-46) is never used and should be removed
Remove unused functions.

Additional information: link

BIGDOG._rTotal (#128) is set pre-construction with a non-constant function or state variable:
- (MAX - (MAX % _tTotal))
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.8.10 (#5) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.10 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Address.sendValue(address,uint256) (#30-35):
- (success) = recipient.call{value: amount}() (#33)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IRouter.WETH() (#89) is not in mixedCase
Struct BIGDOG.valuesFromGetValues (#158-170) is not in CapWords
Parameter BIGDOG.setTaxes(uint256,uint256,uint256,uint256)._rfi (#314) is not in mixedCase
Parameter BIGDOG.setTaxes(uint256,uint256,uint256,uint256)._marketing (#314) is not in mixedCase
Parameter BIGDOG.setTaxes(uint256,uint256,uint256,uint256)._liquidity (#314) is not in mixedCase
Parameter BIGDOG.setTaxes(uint256,uint256,uint256,uint256)._burn (#314) is not in mixedCase
Parameter BIGDOG.updateSwapEnabled(bool)._enabled (#542) is not in mixedCase
Parameter BIGDOG.rescueAnyBEP20Tokens(address,address,uint256)._tokenAddr (#560) is not in mixedCase
Parameter BIGDOG.rescueAnyBEP20Tokens(address,address,uint256)._to (#560) is not in mixedCase
Parameter BIGDOG.rescueAnyBEP20Tokens(address,address,uint256)._amount (#560) is not in mixedCase
Constant BIGDOG._decimals (#124) is not in UPPER_CASE_WITH_UNDERSCORES
Constant BIGDOG.deadAddress (#135) is not in UPPER_CASE_WITH_UNDERSCORES
Constant BIGDOG._name (#138) is not in UPPER_CASE_WITH_UNDERSCORES
Constant BIGDOG._symbol (#139) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#44)" inContext (#38-47)
Remove redundant statements if they congest code but offer no value.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#67-69)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#71-74)
name() should be declared external:
- BIGDOG.name() (#201-203)
symbol() should be declared external:
- BIGDOG.symbol() (#204-206)
decimals() should be declared external:
- BIGDOG.decimals() (#207-209)
totalSupply() should be declared external:
- BIGDOG.totalSupply() (#211-213)
transfer(address,uint256) should be declared external:
- BIGDOG.transfer(address,uint256) (#220-223)
allowance(address,address) should be declared external:
- BIGDOG.allowance(address,address) (#225-227)
approve(address,uint256) should be declared external:
- BIGDOG.approve(address,uint256) (#229-232)
transferFrom(address,address,uint256) should be declared external:
- BIGDOG.transferFrom(address,address,uint256) (#234-242)
increaseAllowance(address,uint256) should be declared external:
- BIGDOG.increaseAllowance(address,uint256) (#244-247)
decreaseAllowance(address,uint256) should be declared external:
- BIGDOG.decreaseAllowance(address,uint256) (#249-255)
isExcludedFromReward(address) should be declared external:
- BIGDOG.isExcludedFromReward(address) (#257-259)
reflectionFromToken(uint256,bool) should be declared external:
- BIGDOG.reflectionFromToken(uint256,bool) (#261-270)
excludeFromFee(address) should be declared external:
- BIGDOG.excludeFromFee(address) (#301-303)
includeInFee(address) should be declared external:
- BIGDOG.includeInFee(address) (#305-307)
isExcludedFromFee(address) should be declared external:
- BIGDOG.isExcludedFromFee(address) (#310-312)
setTaxes(uint256,uint256,uint256,uint256) should be declared external:
- BIGDOG.setTaxes(uint256,uint256,uint256,uint256) (#314-316)
rescueAnyBEP20Tokens(address,address,uint256) should be declared external:
- BIGDOG.rescueAnyBEP20Tokens(address,address,uint256) (#560-562)
Use the external attribute for functions never called from the contract.

Additional information: link