BDF [Binary DeFi] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

BinaryDeFi.swapBack() (#601-643) sends eth to arbitrary user
Dangerous calls:
- distributor.deposit{value: amountBNBReflection}() (#627)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#628)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
BinaryDeFi.buyTokens(uint256,address) (#672-683) sends eth to arbitrary user
Dangerous calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in BinaryDeFi._transferFrom(address,address,uint256) (#526-549):
External calls:
- swapBack() (#531)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#611-617)
- distributor.deposit{value: amountBNBReflection}() (#627)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
- triggerAutoBuyback() (#532)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
External calls sending eth:
- swapBack() (#531)
- distributor.deposit{value: amountBNBReflection}() (#627)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#628)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
- triggerAutoBuyback() (#532)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#536)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#540)
- amountReceived = takeFee(sender,recipient,amount) (#538)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#588)
- triggerAutoBuyback() (#532)
- inSwap = true (#465)
- inSwap = false (#465)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.distributeDividend(address) (#357-368) ignores return value by BUSD.transfer(shareholder,amount) (#363)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Reentrancy in BinaryDeFi.constructor(address) (#467-491):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#471)
State variables written after the call(s):
- WBNB = router.WETH() (#473)
Reentrancy in DividendDistributor.distributeDividend(address) (#357-368):
External calls:
- BUSD.transfer(shareholder,amount) (#363)
State variables written after the call(s):
- shares[shareholder].totalRealised = shares[shareholder].totalRealised.add(amount) (#365)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#366)
Reentrancy in DividendDistributor.process(uint256) (#326-350):
External calls:
- distributeDividend(shareholders[currentIndex]) (#342)
- BUSD.transfer(shareholder,amount) (#363)
State variables written after the call(s):
- currentIndex ++ (#347)
Reentrancy in DividendDistributor.setShare(address,uint256) (#290-304):
External calls:
- distributeDividend(shareholder) (#292)
- BUSD.transfer(shareholder,amount) (#363)
State variables written after the call(s):
- shares[shareholder].amount = amount (#302)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#303)
Apply the check-effects-interactions pattern.

Additional information: link

BinaryDeFi.swapBack() (#601-643) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
Ensure that all the return values of the function calls are used.

Additional information: link

DividendDistributor.setDistributionCriteria(uint256,uint256) (#285-288) should emit an event for:
- minPeriod = _minPeriod (#286)
- minDistribution = _minDistribution (#287)
BinaryDeFi.setAutoBuybackSettings(bool,uint256,uint256,uint256) (#685-692) should emit an event for:
- autoBuybackCap = _cap (#687)
- autoBuybackAmount = _amount (#689)
BinaryDeFi.setBuybackMultiplierSettings(uint256,uint256,uint256) (#694-699) should emit an event for:
- buybackMultiplierNumerator = numerator (#696)
- buybackMultiplierDenominator = denominator (#697)
- buybackMultiplierLength = length (#698)
BinaryDeFi.setTxLimit(uint256) (#711-714) should emit an event for:
- _maxTxAmount = amount (#713)
BinaryDeFi.setFees(uint256,uint256,uint256,uint256,uint256) (#734-742) should emit an event for:
- liquidityFee = _liquidityFee (#735)
- reflectionFee = _reflectionFee (#737)
- marketingFee = _marketingFee (#738)
- totalFee = _liquidityFee.add(_buybackFee).add(_reflectionFee).add(_marketingFee) (#739)
- feeDenominator = _feeDenominator (#740)
BinaryDeFi.setSwapBackSettings(bool,uint256) (#749-752) should emit an event for:
- swapThreshold = _amount (#751)
BinaryDeFi.setTargetLiquidity(uint256,uint256) (#754-757) should emit an event for:
- targetLiquidity = _target (#755)
- targetLiquidityDenominator = _denominator (#756)
Emit an event for critical parameter changes.

Additional information: link

Auth.transferOwnership(address).adr (#167) lacks a zero-check on :
- owner = adr (#168)
BinaryDeFi.setFeeReceivers(address,address)._autoLiquidityReceiver (#744) lacks a zero-check on :
- autoLiquidityReceiver = _autoLiquidityReceiver (#745)
BinaryDeFi.setFeeReceivers(address,address)._marketingFeeReceiver (#744) lacks a zero-check on :
- marketingFeeReceiver = _marketingFeeReceiver (#746)
Check that the address is not zero.

Additional information: link

DividendDistributor.distributeDividend(address) (#357-368) has external calls inside a loop: BUSD.transfer(shareholder,amount) (#363)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in BinaryDeFi.constructor(address) (#467-491):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#471)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = _totalSupply (#472)
- approve(_dexRouter,_totalSupply) (#487)
- _allowances[msg.sender][spender] = amount (#505)
- approve(address(pair),_totalSupply) (#488)
- _allowances[msg.sender][spender] = amount (#505)
- _balances[msg.sender] = _totalSupply (#489)
- autoLiquidityReceiver = msg.sender (#484)
- buyBacker[msg.sender] = true (#482)
- distributor = new DividendDistributor(_dexRouter) (#474)
- distributorAddress = address(distributor) (#475)
- isDividendExempt[pair] = true (#479)
- isDividendExempt[address(this)] = true (#480)
- isDividendExempt[DEAD] = true (#481)
- isFeeExempt[msg.sender] = true (#477)
- isTxLimitExempt[msg.sender] = true (#478)
- marketingFeeReceiver = msg.sender (#485)
Reentrancy in DividendDistributor.deposit() (#306-324):
External calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: msg.value}(0,path,address(this),block.timestamp) (#313-318)
State variables written after the call(s):
- dividendsPerShare = dividendsPerShare.add(dividendsPerShareAccuracyFactor.mul(amount).div(totalShares)) (#323)
- totalDividends = totalDividends.add(amount) (#322)
Reentrancy in DividendDistributor.distributeDividend(address) (#357-368):
External calls:
- BUSD.transfer(shareholder,amount) (#363)
State variables written after the call(s):
- shareholderClaims[shareholder] = block.timestamp (#364)
Reentrancy in DividendDistributor.setShare(address,uint256) (#290-304):
External calls:
- distributeDividend(shareholder) (#292)
- BUSD.transfer(shareholder,amount) (#363)
State variables written after the call(s):
- addShareholder(shareholder) (#296)
- shareholderIndexes[shareholder] = shareholders.length (#390)
- removeShareholder(shareholder) (#298)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#396)
- addShareholder(shareholder) (#296)
- shareholders.push(shareholder) (#391)
- removeShareholder(shareholder) (#298)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#395)
- shareholders.pop() (#397)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#301)
Reentrancy in BinaryDeFi.triggerAutoBuyback(uint256,bool) (#653-659):
External calls:
- buyTokens(amount,DEAD) (#654)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
State variables written after the call(s):
- buybackMultiplierTriggeredAt = block.timestamp (#656)
Reentrancy in BinaryDeFi.triggerAutoBuyback() (#665-670):
External calls:
- buyTokens(autoBuybackAmount,DEAD) (#666)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
State variables written after the call(s):
- autoBuybackAccumulator = autoBuybackAccumulator.add(autoBuybackAmount) (#668)
- autoBuybackBlockLast = block.number (#667)
- autoBuybackEnabled = false (#669)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in BinaryDeFi._transferFrom(address,address,uint256) (#526-549):
External calls:
- swapBack() (#531)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#611-617)
- distributor.deposit{value: amountBNBReflection}() (#627)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
- triggerAutoBuyback() (#532)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
- distributor.setShare(sender,_balances[sender]) (#542)
- distributor.setShare(recipient,_balances[recipient]) (#543)
- distributor.process(distributorGas) (#545)
External calls sending eth:
- swapBack() (#531)
- distributor.deposit{value: amountBNBReflection}() (#627)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#628)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
- triggerAutoBuyback() (#532)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
Event emitted after the call(s):
- Transfer(sender,recipient,amountReceived) (#547)
Reentrancy in BinaryDeFi._transferFrom(address,address,uint256) (#526-549):
External calls:
- swapBack() (#531)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#611-617)
- distributor.deposit{value: amountBNBReflection}() (#627)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
- triggerAutoBuyback() (#532)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
External calls sending eth:
- swapBack() (#531)
- distributor.deposit{value: amountBNBReflection}() (#627)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#628)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
- triggerAutoBuyback() (#532)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#589)
- amountReceived = takeFee(sender,recipient,amount) (#538)
Reentrancy in BinaryDeFi.constructor(address) (#467-491):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#471)
Event emitted after the call(s):
- Approval(msg.sender,spender,amount) (#506)
- approve(address(pair),_totalSupply) (#488)
- Approval(msg.sender,spender,amount) (#506)
- approve(_dexRouter,_totalSupply) (#487)
- Transfer(address(0),msg.sender,_totalSupply) (#490)
Reentrancy in BinaryDeFi.swapBack() (#601-643):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#611-617)
- distributor.deposit{value: amountBNBReflection}() (#627)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
External calls sending eth:
- distributor.deposit{value: amountBNBReflection}() (#627)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#628)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#641)
Reentrancy in BinaryDeFi.triggerAutoBuyback(uint256,bool) (#653-659):
External calls:
- buyTokens(amount,DEAD) (#654)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
Event emitted after the call(s):
- BuybackMultiplierActive(buybackMultiplierLength) (#657)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.shouldDistribute(address) (#352-355) uses timestamp for comparisons
Dangerous comparisons:
- shareholderClaims[shareholder] + minPeriod < block.timestamp && getUnpaidEarnings(shareholder) > minDistribution (#353-354)
BinaryDeFi.getMultipliedFee() (#574-583) uses timestamp for comparisons
Dangerous comparisons:
- launchedAtTimestamp + 86400 > block.timestamp (#575)
- buybackMultiplierTriggeredAt.add(buybackMultiplierLength) > block.timestamp (#577)
BinaryDeFi.shouldSwapBack() (#594-599) uses timestamp for comparisons
Dangerous comparisons:
- msg.sender != pair && ! inSwap && swapEnabled && _balances[address(this)] >= swapThreshold (#595-598)
BinaryDeFi.isOverLiquified(uint256,uint256) (#776-778) uses timestamp for comparisons
Dangerous comparisons:
- getLiquidityBacking(accuracy) > target (#777)
Avoid relying on block.timestamp.

Additional information: link

BinaryDeFi.onlyBuybacker() (#500) compares to a boolean constant:
-require(bool,string)(buyBacker[msg.sender] == true,) (#500)
Remove the equality to the boolean constant.

Additional information: link

DividendDistributor.process(uint256) (#326-350) has costly operations inside a loop:
- currentIndex = 0 (#338)
DividendDistributor.distributeDividend(address) (#357-368) has costly operations inside a loop:
- totalDistributed = totalDistributed.add(amount) (#362)
DividendDistributor.process(uint256) (#326-350) has costly operations inside a loop:
- currentIndex ++ (#347)
Use a local variable to hold the loop computation result.

Additional information: link

BinaryDeFi.launched() (#701-703) is never used and should be removed
SafeMath.div(uint256,uint256,string) (#83-88) is never used and should be removed
SafeMath.mod(uint256,uint256) (#72-74) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#90-95) is never used and should be removed
SafeMath.tryAdd(uint256,uint256) (#15-21) is never used and should be removed
SafeMath.tryDiv(uint256,uint256) (#42-47) is never used and should be removed
SafeMath.tryMod(uint256,uint256) (#49-54) is never used and should be removed
SafeMath.tryMul(uint256,uint256) (#30-40) is never used and should be removed
SafeMath.trySub(uint256,uint256) (#23-28) is never used and should be removed
Remove unused functions.

Additional information: link

BinaryDeFi._maxTxAmount (#416) is set pre-construction with a non-constant function or state variable:
- _totalSupply.div(400)
BinaryDeFi.swapThreshold (#463) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 2000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.8.0 (#8) allows old versions
solc-0.8.0 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Function IDEXRouter.WETH() (#182) is not in mixedCase
Parameter DividendDistributor.setDistributionCriteria(uint256,uint256)._minPeriod (#285) is not in mixedCase
Parameter DividendDistributor.setDistributionCriteria(uint256,uint256)._minDistribution (#285) is not in mixedCase
Variable DividendDistributor._token (#238) is not in mixedCase
Variable DividendDistributor.BUSD (#246) is not in mixedCase
Variable DividendDistributor.WBNB (#247) is not in mixedCase
Parameter BinaryDeFi.setAutoBuybackSettings(bool,uint256,uint256,uint256)._enabled (#685) is not in mixedCase
Parameter BinaryDeFi.setAutoBuybackSettings(bool,uint256,uint256,uint256)._cap (#685) is not in mixedCase
Parameter BinaryDeFi.setAutoBuybackSettings(bool,uint256,uint256,uint256)._amount (#685) is not in mixedCase
Parameter BinaryDeFi.setAutoBuybackSettings(bool,uint256,uint256,uint256)._period (#685) is not in mixedCase
Parameter BinaryDeFi.setFees(uint256,uint256,uint256,uint256,uint256)._liquidityFee (#734) is not in mixedCase
Parameter BinaryDeFi.setFees(uint256,uint256,uint256,uint256,uint256)._buybackFee (#734) is not in mixedCase
Parameter BinaryDeFi.setFees(uint256,uint256,uint256,uint256,uint256)._reflectionFee (#734) is not in mixedCase
Parameter BinaryDeFi.setFees(uint256,uint256,uint256,uint256,uint256)._marketingFee (#734) is not in mixedCase
Parameter BinaryDeFi.setFees(uint256,uint256,uint256,uint256,uint256)._feeDenominator (#734) is not in mixedCase
Parameter BinaryDeFi.setFeeReceivers(address,address)._autoLiquidityReceiver (#744) is not in mixedCase
Parameter BinaryDeFi.setFeeReceivers(address,address)._marketingFeeReceiver (#744) is not in mixedCase
Parameter BinaryDeFi.setSwapBackSettings(bool,uint256)._enabled (#749) is not in mixedCase
Parameter BinaryDeFi.setSwapBackSettings(bool,uint256)._amount (#749) is not in mixedCase
Parameter BinaryDeFi.setTargetLiquidity(uint256,uint256)._target (#754) is not in mixedCase
Parameter BinaryDeFi.setTargetLiquidity(uint256,uint256)._denominator (#754) is not in mixedCase
Parameter BinaryDeFi.setDistributionCriteria(uint256,uint256)._minPeriod (#759) is not in mixedCase
Parameter BinaryDeFi.setDistributionCriteria(uint256,uint256)._minDistribution (#759) is not in mixedCase
Variable BinaryDeFi.BUSD (#405) is not in mixedCase
Variable BinaryDeFi.WBNB (#406) is not in mixedCase
Variable BinaryDeFi.DEAD (#407) is not in mixedCase
Variable BinaryDeFi.ZERO (#408) is not in mixedCase
Variable BinaryDeFi.DEAD_NON_CHECKSUM (#409) is not in mixedCase
Constant BinaryDeFi._name (#411) is not in UPPER_CASE_WITH_UNDERSCORES
Constant BinaryDeFi._symbol (#412) is not in UPPER_CASE_WITH_UNDERSCORES
Constant BinaryDeFi._decimals (#413) is not in UPPER_CASE_WITH_UNDERSCORES
Variable BinaryDeFi._totalSupply (#415) is not in mixedCase
Variable BinaryDeFi._maxTxAmount (#416) is not in mixedCase
Variable BinaryDeFi._balances (#418) is not in mixedCase
Variable BinaryDeFi._allowances (#419) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Reentrancy in BinaryDeFi._transferFrom(address,address,uint256) (#526-549):
External calls:
- swapBack() (#531)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#628)
External calls sending eth:
- swapBack() (#531)
- distributor.deposit{value: amountBNBReflection}() (#627)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#628)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
- triggerAutoBuyback() (#532)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#677-682)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#536)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#540)
- amountReceived = takeFee(sender,recipient,amount) (#538)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#588)
- triggerAutoBuyback() (#532)
- autoBuybackAccumulator = autoBuybackAccumulator.add(autoBuybackAmount) (#668)
- triggerAutoBuyback() (#532)
- autoBuybackBlockLast = block.number (#667)
- triggerAutoBuyback() (#532)
- autoBuybackEnabled = false (#669)
- triggerAutoBuyback() (#532)
- inSwap = true (#465)
- inSwap = false (#465)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#589)
- amountReceived = takeFee(sender,recipient,amount) (#538)
- Transfer(sender,recipient,amountReceived) (#547)
Reentrancy in BinaryDeFi.swapBack() (#601-643):
External calls:
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#628)
External calls sending eth:
- distributor.deposit{value: amountBNBReflection}() (#627)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#628)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#633-640)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#641)
Apply the check-effects-interactions pattern.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#187) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#188)
Prevent variables from having similar names.

Additional information: link

BinaryDeFi.slitherConstructorVariables() (#401-783) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#407)
BinaryDeFi.slitherConstructorVariables() (#401-783) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#408)
BinaryDeFi.slitherConstructorVariables() (#401-783) uses literals with too many digits:
- DEAD_NON_CHECKSUM = 0x000000000000000000000000000000000000dEaD (#409)
BinaryDeFi.slitherConstructorVariables() (#401-783) uses literals with too many digits:
- distributorGas = 500000 (#460)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

BinaryDeFi.BUSD (#405) is never used in BinaryDeFi (#401-783)
BinaryDeFi.DEAD_NON_CHECKSUM (#409) is never used in BinaryDeFi (#401-783)
Remove unused state variables.

Additional information: link

BinaryDeFi.BUSD (#405) should be constant
BinaryDeFi.DEAD (#407) should be constant
BinaryDeFi.DEAD_NON_CHECKSUM (#409) should be constant
BinaryDeFi.ZERO (#408) should be constant
BinaryDeFi._totalSupply (#415) should be constant
DividendDistributor.WBNB (#247) should be constant
DividendDistributor.dividendsPerShareAccuracyFactor (#260) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

authorize(address) should be declared external:
- Auth.authorize(address) (#139-141)
unauthorize(address) should be declared external:
- Auth.unauthorize(address) (#146-148)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#167-171)
launch() should be declared external:
- BinaryDeFi.launch() (#705-709)
Use the external attribute for functions never called from the contract.

Additional information: link