ACITY [Arabian City] Token

ACITY.claimStuckTokens(address) (#1204-1213) ignores return value by erc20token.transfer(owner(),balance) (#1212)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

ACITY.swapAndSendMarketing(uint256) (#1377-1384) sends eth to arbitrary user
Dangerous calls:
- _marketingWallet.transfer(newBalance) (#1383)
ACITY.addLiquidity(uint256,uint256) (#1386-1399) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in ACITY._transfer(address,address,uint256) (#1296-1375):
External calls:
- swapAndLiquify(swapTokens) (#1325)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1429-1435)
- swapAndSendMarketing(marketingTokens) (#1328)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1429-1435)
External calls sending eth:
- swapAndLiquify(swapTokens) (#1325)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
- swapAndSendMarketing(marketingTokens) (#1328)
- _marketingWallet.transfer(newBalance) (#1383)
State variables written after the call(s):
- super._transfer(from,address(this),feeAmount) (#1369)
- _balances[sender] = senderBalance - amount (#914)
- _balances[recipient] += amount (#916)
- super._transfer(from,to,amount) (#1372)
- _balances[sender] = senderBalance - amount (#914)
- _balances[recipient] += amount (#916)
- swapAndSendMarketing(marketingTokens) (#1328)
- swapping = true (#1118)
- swapping = false (#1120)
Apply the check-effects-interactions pattern.

Additional information: link

Contract ownership is not renounced (belongs to a wallet)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#30) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#31) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#48) is not in mixedCase
Function IUniswapV2Router01.WETH() (#92) is not in mixedCase
Parameter ACITY.claimStuckTokens(address)._token (#1204) is not in mixedCase
Constant ACITY.deadAddress (#1050) is not in UPPER_CASE_WITH_UNDERSCORES
Variable ACITY._marketingWallet (#1083) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

ACITY._transfer(address,address,uint256).fees (#1341) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

Reentrancy in ACITY._transfer(address,address,uint256) (#1296-1375):
External calls:
- swapAndSendMarketing(marketingTokens) (#1328)
- _marketingWallet.transfer(newBalance) (#1383)
External calls sending eth:
- swapAndLiquify(swapTokens) (#1325)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
- swapAndSendMarketing(marketingTokens) (#1328)
- _marketingWallet.transfer(newBalance) (#1383)
State variables written after the call(s):
- super._transfer(from,address(this),feeAmount) (#1369)
- _balances[sender] = senderBalance - amount (#914)
- _balances[recipient] += amount (#916)
- super._transfer(from,to,amount) (#1372)
- _balances[sender] = senderBalance - amount (#914)
- _balances[recipient] += amount (#916)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#918)
- super._transfer(from,address(this),feeAmount) (#1369)
- Transfer(sender,recipient,amount) (#918)
- super._transfer(from,to,amount) (#1372)
Apply the check-effects-interactions pattern.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#97) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#98)
Prevent variables from having similar names.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#541-543)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#549-552)
name() should be declared external:
- ERC20.name() (#742-744)
symbol() should be declared external:
- ERC20.symbol() (#750-752)
decimals() should be declared external:
- ACITY.decimals() (#1167-1169)
- ERC20.decimals() (#767-769)
totalSupply() should be declared external:
- ERC20.totalSupply() (#774-776)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#793-796)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#801-803)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#812-815)
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#830-844)
increaseAllowance(address,uint256) should be declared external:
- ERC20.increaseAllowance(address,uint256) (#858-861)
decreaseAllowance(address,uint256) should be declared external:
- ERC20.decreaseAllowance(address,uint256) (#877-885)
updateUniswapV2Router(address) should be declared external:
- ACITY.updateUniswapV2Router(address) (#1174-1181)
excludeMultipleAccountsFromFees(address[],bool) should be declared external:
- ACITY.excludeMultipleAccountsFromFees(address[],bool) (#1193-1202)
setAutomatedMarketMakerPair(address,bool) should be declared external:
- ACITY.setAutomatedMarketMakerPair(address,bool) (#1223-1233)
isExcludedFromFees(address) should be declared external:
- ACITY.isExcludedFromFees(address) (#1266-1268)
Use the external attribute for functions never called from the contract.

Additional information: link

Pragma version>=0.5.0 (#13) allows old versions
Pragma version>=0.5.0 (#68) allows old versions
Pragma version>=0.6.2 (#88) allows old versions
Pragma version>=0.6.2 (#186) allows old versions
Pragma version^0.8.0 (#235) allows old versions
Pragma version^0.8.0 (#465) allows old versions
Pragma version^0.8.0 (#492) allows old versions
Pragma version^0.8.0 (#570) allows old versions
Pragma version^0.8.0 (#655) allows old versions
Pragma version^0.8.0 (#685) allows old versions
Pragma version^0.8.11 (#1042) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.11 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

ACITY.addLiquidity(uint256,uint256) (#1386-1399) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
Ensure that all the return values of the function calls are used.

Additional information: link

ACITY.setBuyFee(uint16,uint16) (#1245-1253) should emit an event for:
- totalBuyFee = marketingfee + liquidity (#1252)
ACITY.setSellFee(uint16,uint16) (#1255-1263) should emit an event for:
- totalSellFee = marketingfee + liquidity (#1262)
ACITY.setMaxWallet(uint256) (#1280-1282) should emit an event for:
- maxWalletAmount = amount * 10 ** 9 (#1281)
ACITY.setMaxBuyAmount(uint256) (#1284-1286) should emit an event for:
- maxBuyAmount = amount * 10 ** 9 (#1285)
ACITY.setMaxSellAmount(uint256) (#1288-1290) should emit an event for:
- maxSellAmount = amount * 10 ** 9 (#1289)
ACITY.setSwapTokensAtAmount(uint256) (#1292-1294) should emit an event for:
- swapTokensAtAmount = amount * 10 ** 9 (#1293)
Emit an event for critical parameter changes.

Additional information: link

Reentrancy in ACITY._transfer(address,address,uint256) (#1296-1375):
External calls:
- swapAndLiquify(swapTokens) (#1325)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1429-1435)
- swapAndSendMarketing(marketingTokens) (#1328)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1429-1435)
External calls sending eth:
- swapAndLiquify(swapTokens) (#1325)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
- swapAndSendMarketing(marketingTokens) (#1328)
- _marketingWallet.transfer(newBalance) (#1383)
State variables written after the call(s):
- swapAndSendMarketing(marketingTokens) (#1328)
- _allowances[owner][spender] = amount (#993)
Reentrancy in ACITY.constructor() (#1123-1163):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#1143-1144)
State variables written after the call(s):
- _mint(owner(),1 * 10 ** 12 * (10 ** 9)) (#1162)
- _balances[account] += amount (#938)
- excludeFromFees(owner(),true) (#1153)
- _isExcludedFromFees[account] = excluded (#1188)
- excludeFromFees(address(this),true) (#1154)
- _isExcludedFromFees[account] = excluded (#1188)
- _mint(owner(),1 * 10 ** 12 * (10 ** 9)) (#1162)
- _totalSupply += amount (#937)
- _setAutomatedMarketMakerPair(_uniswapV2Pair,true) (#1149)
- automatedMarketMakerPairs[pair] = value (#1240)
- swapEnabled = true (#1156)
- uniswapV2Pair = _uniswapV2Pair (#1147)
- uniswapV2Router = _uniswapV2Router (#1146)
Reentrancy in ACITY.swapAndLiquify(uint256) (#1401-1418):
External calls:
- swapTokensForEth(half) (#1409)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1429-1435)
- addLiquidity(otherHalf,newBalance) (#1415)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1415)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (#1415)
- _allowances[owner][spender] = amount (#993)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in ACITY._transfer(address,address,uint256) (#1296-1375):
External calls:
- swapAndLiquify(swapTokens) (#1325)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1429-1435)
- swapAndSendMarketing(marketingTokens) (#1328)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1429-1435)
External calls sending eth:
- swapAndLiquify(swapTokens) (#1325)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
- swapAndSendMarketing(marketingTokens) (#1328)
- _marketingWallet.transfer(newBalance) (#1383)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#994)
- swapAndSendMarketing(marketingTokens) (#1328)
- Transfer(sender,recipient,amount) (#918)
- super._transfer(from,address(this),feeAmount) (#1369)
- Transfer(sender,recipient,amount) (#918)
- super._transfer(from,to,amount) (#1372)
Reentrancy in ACITY.constructor() (#1123-1163):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#1143-1144)
Event emitted after the call(s):
- ExcludeFromFees(account,excluded) (#1190)
- excludeFromFees(address(this),true) (#1154)
- ExcludeFromFees(account,excluded) (#1190)
- excludeFromFees(owner(),true) (#1153)
- Transfer(address(0),account,amount) (#939)
- _mint(owner(),1 * 10 ** 12 * (10 ** 9)) (#1162)
Reentrancy in ACITY.swapAndLiquify(uint256) (#1401-1418):
External calls:
- swapTokensForEth(half) (#1409)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1429-1435)
- addLiquidity(otherHalf,newBalance) (#1415)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1415)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1391-1398)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#994)
- addLiquidity(otherHalf,newBalance) (#1415)
- SwapAndLiquify(half,newBalance,otherHalf) (#1417)
Apply the check-effects-interactions pattern.

Additional information: link

Different versions of Solidity is used:
- Version used: ['>=0.5.0', '>=0.6.2', '^0.8.0', '^0.8.11']
- >=0.5.0 (#13)
- >=0.5.0 (#68)
- >=0.6.2 (#88)
- >=0.6.2 (#186)
- ^0.8.0 (#235)
- ^0.8.0 (#465)
- ^0.8.0 (#492)
- ^0.8.0 (#570)
- ^0.8.0 (#655)
- ^0.8.0 (#685)
- ^0.8.11 (#1042)
Use one Solidity version.

Additional information: link

Context._msgData() (#482-484) is never used and should be removed
ERC20._burn(address,uint256) (#955-970) is never used and should be removed
SafeMath.add(uint256,uint256) (#324-326) is never used and should be removed
SafeMath.div(uint256,uint256,string) (#422-431) is never used and should be removed
SafeMath.mod(uint256,uint256) (#382-384) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#448-457) is never used and should be removed
SafeMath.sub(uint256,uint256,string) (#399-408) is never used and should be removed
SafeMath.tryAdd(uint256,uint256) (#253-259) is never used and should be removed
SafeMath.tryDiv(uint256,uint256) (#295-300) is never used and should be removed
SafeMath.tryMod(uint256,uint256) (#307-312) is never used and should be removed
SafeMath.tryMul(uint256,uint256) (#278-288) is never used and should be removed
SafeMath.trySub(uint256,uint256) (#266-271) is never used and should be removed
Remove unused functions.

Additional information: link

Attempt to swap token was unsuccessful. For some reason it is untradeable. If token is not in presale stage and is not traded outside PancakeSwap, then it's a scam

Additional information: link

Token is deployed only at one blockchain

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to find token contract audit

Unable to find audit link on the website

Unable to find whitepaper link on the website

Token is not listed at Mobula.Finance

Additional information: link

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Token is marked as scam (rug pull, honeypot, phishing, etc.)

Additional information: link

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death